From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Cc: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Chris Paterson
<chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
Date: Tue, 11 Jul 2017 15:51:40 +0300 [thread overview]
Message-ID: <87b6b38a-ca6b-a0d7-b777-0a4809eaf6fc@cogentembedded.com> (raw)
In-Reply-To: <20170711122100.GM4517-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: Biju Das <biju.das@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Magnus Damm <magnus.damm@gmail.com>,
Chris Paterson <chris.paterson2@renesas.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
Date: Tue, 11 Jul 2017 15:51:40 +0300 [thread overview]
Message-ID: <87b6b38a-ca6b-a0d7-b777-0a4809eaf6fc@cogentembedded.com> (raw)
In-Reply-To: <20170711122100.GM4517@verge.net.au>
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
Date: Tue, 11 Jul 2017 15:51:40 +0300 [thread overview]
Message-ID: <87b6b38a-ca6b-a0d7-b777-0a4809eaf6fc@cogentembedded.com> (raw)
In-Reply-To: <20170711122100.GM4517@verge.net.au>
On 07/11/2017 03:21 PM, Simon Horman wrote:
>>> Add a new compatible string for the RZ/G1M (R8A7743) SoC.
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> ---
>>> v1->v2
>>> * Changed the subject
>>> * re-formatted the required properties
>>>
>>> .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++---------
>>> 1 file changed, 17 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> index b519503..4717bc2 100644
>>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
>>> @@ -4,19 +4,24 @@ This file provides information on what the device node for the Ethernet AVB
>>> interface contains.
>>>
>>> Required properties:
>>> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
>>> - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
>>> - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
>>> - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
>>> - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
>>> - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
>>> - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
>>> - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible interface.
>>> - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible interface.
>>> +- compatible: Must contain one or more of the following:
>>
>> No, it can't contain more than one SoC specific value.
>
> The text above does not say it can unless one is under the delusion
> that, f.e. an r8a7790 SoC is also an r8a7791 SoC.
Hm, you're right. Sorry about my misunderstanding...
The only problem I'm still seeing with the current wording is that gen2/3
fallback
values are declared optional, while you can't get the driver to bind without
them on
the newer SoCs. But this is probably not a new problem...
> If you would prefer an alternate wording please provide a suggestion.
Perhaps we should emphasize that the gen2/3 fallback values are mandatory?
>>> + - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
>>> + - "renesas,etheravb-r8a7790" for the R8A7790 SoC.
>>> + - "renesas,etheravb-r8a7791" for the R8A7791 SoC.
>>> + - "renesas,etheravb-r8a7792" for the R8A7792 SoC.
>>> + - "renesas,etheravb-r8a7793" for the R8A7793 SoC.
>>> + - "renesas,etheravb-r8a7794" for the R8A7794 SoC.
>>> + - "renesas,etheravb-rcar-gen2" as a fallback for the above
>>> + R-Car Gen2 and RZ/G1 devices.
[...]
WBR, Sergei
next prev parent reply other threads:[~2017-07-11 12:51 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 13:01 [PATCH v 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:01 ` [PATCH v 1/2] ravb: Add support for r8a7743 SoC Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:20 ` Sergei Shtylyov
2017-07-05 13:20 ` Sergei Shtylyov
[not found] ` <afcd181c-c805-8f3c-955f-652d001a03d4-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-07-05 15:02 ` Biju Das
2017-07-05 15:02 ` Biju Das
2017-07-05 15:02 ` Biju Das
2017-07-05 15:56 ` [PATCH v2 0/2] Add RZ/G1M (R8A7743) Ethernet AVB support Biju Das
2017-07-05 15:56 ` Biju Das
2017-07-05 15:56 ` [PATCH v2 1/2] ravb: Document binding for r8a7743 SoC Biju Das
2017-07-05 15:56 ` Biju Das
[not found] ` <1499270189-29945-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-05 15:56 ` [PATCH v2 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB Biju Das
2017-07-05 15:56 ` Biju Das
2017-07-05 15:56 ` Biju Das
[not found] ` <1499270189-29945-3-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-05 16:13 ` Sergei Shtylyov
2017-07-06 8:05 ` Chris Paterson
2017-07-06 8:05 ` Chris Paterson
2017-07-06 8:05 ` Chris Paterson
2017-07-10 8:38 ` Simon Horman
2017-07-10 8:38 ` Simon Horman
2017-07-05 13:47 ` [PATCH v 1/2] ravb: Add support for r8a7743 SoC Geert Uytterhoeven
2017-07-05 13:47 ` Geert Uytterhoeven
2017-07-05 13:47 ` Geert Uytterhoeven
2017-07-05 13:51 ` Chris Paterson
2017-07-05 13:51 ` Chris Paterson
2017-07-05 14:55 ` Geert Uytterhoeven
2017-07-05 14:55 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUXxHU8JaO0riJ7h7hJpCwAw27titTfo3Ox6CqO3i8E9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-05 14:59 ` Chris Paterson
2017-07-05 14:59 ` Chris Paterson
2017-07-05 14:59 ` Chris Paterson
[not found] ` <1499259711-56175-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-10 1:20 ` Rob Herring
2017-07-10 1:20 ` Rob Herring
2017-07-10 1:20 ` Rob Herring
2017-07-10 8:20 ` Biju Das
2017-07-10 8:20 ` Biju Das
2017-07-10 9:31 ` Sergei Shtylyov
2017-07-10 9:31 ` Sergei Shtylyov
2017-07-10 15:32 ` [PATCH v2] dt-bindings: net: ravb : " Biju Das
2017-07-10 15:32 ` Biju Das
[not found] ` <1499700776-54504-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-10 15:51 ` Geert Uytterhoeven
2017-07-11 9:07 ` Simon Horman
2017-07-11 9:07 ` Simon Horman
2017-07-11 12:12 ` Sergei Shtylyov
2017-07-11 12:12 ` Sergei Shtylyov
[not found] ` <52eb0b92-5d25-e1f4-df54-e4fcf648c90e-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:20 ` Chris Paterson
2017-07-11 12:55 ` Sergei Shtylyov
2017-07-11 12:55 ` Sergei Shtylyov
2017-07-11 12:21 ` Simon Horman
2017-07-11 12:21 ` Simon Horman
[not found] ` <20170711122100.GM4517-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-07-11 12:51 ` Sergei Shtylyov [this message]
2017-07-11 12:51 ` Sergei Shtylyov
2017-07-11 12:51 ` Sergei Shtylyov
2017-07-12 5:52 ` Simon Horman
2017-07-12 5:52 ` Simon Horman
2017-07-05 13:01 ` [PATCH v 2/2] ARM: shmobile: defconfig: Enable Ethernet AVB Biju Das
2017-07-05 13:01 ` Biju Das
2017-07-05 13:45 ` Geert Uytterhoeven
2017-07-05 13:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b6b38a-ca6b-a0d7-b777-0a4809eaf6fc@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \
--cc=chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.