RE: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC

From: Chris Paterson <Chris.Paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Sergei Shtylyov
	<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
	Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v2] dt-bindings: net: ravb : Add support for r8a7743 SoC
Date: Tue, 11 Jul 2017 12:20:06 +0000	[thread overview]
Message-ID: <TY1PR06MB07023342440946F384B7C80EB7AE0@TY1PR06MB0702.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <52eb0b92-5d25-e1f4-df54-e4fcf648c90e-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Hello Sergei,

> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: 11 July 2017 13:12
> 
> Hello!
> 
> On 07/10/2017 06:32 PM, Biju Das wrote:
> 
> > Add a new compatible string for the RZ/G1M (R8A7743) SoC.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > v1->v2
> > * Changed the subject
> > * re-formatted the required properties
> >
> >  .../devicetree/bindings/net/renesas,ravb.txt       | 29 +++++++++++++------
> ---
> >  1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b519503..4717bc2 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -4,19 +4,24 @@ This file provides information on what the device
> > node for the Ethernet AVB  interface contains.
> >
> >  Required properties:
> > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790
> SoC.
> > -	      "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
> > -	      "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
> > -	      "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
> > -	      "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
> > -	      "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
> > -	      "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC.
> > -	      "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible
> interface.
> > -	      "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible
> interface.
> > +- compatible: Must contain one or more of the following:
> 
>     No, it can't contain more than one SoC specific value.

Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example?

As indeed dictated by the instruction further down:

> > +	When compatible with the generic version, nodes must list the
> > +	SoC-specific version corresponding to the platform first followed by
> > +	the generic version.

Kind regards, Chris