From: Jani Nikula <jani.nikula@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
Date: Mon, 30 Oct 2017 11:52:07 +0200 [thread overview]
Message-ID: <87d155gdyw.fsf@intel.com> (raw)
In-Reply-To: <1864580.oVLIQZJ4NS@avalon>
On Sun, 29 Oct 2017, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Jani,
>
> On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
>> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
>> > Add a jump target so that a bit of exception handling can be better reused
>> > at the end of this function.
>> >
>> > This issue was detected by using the Coccinelle software.
>>
>> Please also look into the GCC software, which will detect that your
>> patch does not compile.
>
> Just for the record, I've been bitten in the past by applying one of Markus'
> patches that seemed to make sense, only to discover later that it introduced a
> security hole. I now drop his patches altogether, so could you please keep an
> eye open to make sure none of them touching the rcar-du driver will be applied
> through drm-misc ?
Ack. You're the maintainer, and we need to respect that.
In general, I'll pick up any patches that are good, but the current
track record is that Markus' patches need extra scrutiny, and many of
the patches contain subjective changes that lead to debate that is not
constructive. There's no return on investment here.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
Date: Mon, 30 Oct 2017 09:52:07 +0000 [thread overview]
Message-ID: <87d155gdyw.fsf@intel.com> (raw)
In-Reply-To: <1864580.oVLIQZJ4NS@avalon>
On Sun, 29 Oct 2017, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Jani,
>
> On Friday, 27 October 2017 21:45:17 EET Jani Nikula wrote:
>> On Tue, 24 Oct 2017, SF Markus Elfring wrote:
>> > Add a jump target so that a bit of exception handling can be better reused
>> > at the end of this function.
>> >
>> > This issue was detected by using the Coccinelle software.
>>
>> Please also look into the GCC software, which will detect that your
>> patch does not compile.
>
> Just for the record, I've been bitten in the past by applying one of Markus'
> patches that seemed to make sense, only to discover later that it introduced a
> security hole. I now drop his patches altogether, so could you please keep an
> eye open to make sure none of them touching the rcar-du driver will be applied
> through drm-misc ?
Ack. You're the maintainer, and we need to respect that.
In general, I'll pick up any patches that are good, but the current
track record is that Markus' patches need extra scrutiny, and many of
the patches contain subjective changes that lead to debate that is not
constructive. There's no return on investment here.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2017-10-30 9:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 16:00 [PATCH 0/2] R-Car Display Unit: Fine-tuning for some function implementations SF Markus Elfring
2017-10-24 16:00 ` SF Markus Elfring
2017-10-24 16:01 ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() SF Markus Elfring
2017-10-24 16:01 ` SF Markus Elfring
2017-10-25 6:01 ` Dan Carpenter
2017-10-25 6:01 ` Dan Carpenter
2017-10-25 6:01 ` Dan Carpenter
2017-10-25 6:35 ` Clarification for approaches around exception handling SF Markus Elfring
2017-10-25 6:35 ` SF Markus Elfring
2017-10-25 6:35 ` SF Markus Elfring
2017-10-26 12:40 ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() kbuild test robot
2017-10-26 12:40 ` kbuild test robot
2017-10-26 12:40 ` kbuild test robot
2017-11-01 15:38 ` [PATCH v2 0/2] R-Car Display Unit: Fine-tuning for some function implementations SF Markus Elfring
2017-11-01 15:38 ` SF Markus Elfring
2017-11-01 15:38 ` SF Markus Elfring
2017-11-01 15:39 ` [PATCH v2 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() SF Markus Elfring
2017-11-01 15:39 ` SF Markus Elfring
2017-11-01 15:39 ` SF Markus Elfring
2017-11-01 15:41 ` [PATCH v2 2/2] drm/rcar-du: Adjust 14 checks for null pointers SF Markus Elfring
2017-11-01 15:41 ` SF Markus Elfring
2017-11-01 15:41 ` SF Markus Elfring
2017-10-27 18:45 ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() Jani Nikula
2017-10-27 18:45 ` Jani Nikula
2017-10-27 18:45 ` Jani Nikula
2017-10-29 11:01 ` Geert Uytterhoeven
2017-10-29 11:01 ` Geert Uytterhoeven
2017-10-29 17:12 ` Laurent Pinchart
2017-10-29 17:12 ` Laurent Pinchart
2017-10-29 18:19 ` SF Markus Elfring
2017-10-29 18:19 ` SF Markus Elfring
2017-10-29 18:19 ` SF Markus Elfring
2017-10-30 9:52 ` Jani Nikula [this message]
2017-10-30 9:52 ` [PATCH 1/2] " Jani Nikula
2017-10-30 10:03 ` SF Markus Elfring
2017-10-30 10:03 ` SF Markus Elfring
2017-10-30 10:03 ` SF Markus Elfring
2017-10-30 13:18 ` [PATCH 1/2] " Laurent Pinchart
2017-10-30 13:18 ` Laurent Pinchart
2017-10-24 16:02 ` [PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers SF Markus Elfring
2017-10-24 16:02 ` SF Markus Elfring
2017-10-24 16:02 ` SF Markus Elfring
2017-10-25 6:02 ` Dan Carpenter
2017-10-25 6:02 ` Dan Carpenter
2017-10-25 6:02 ` Dan Carpenter
2017-10-25 6:44 ` SF Markus Elfring
2017-10-25 6:44 ` SF Markus Elfring
2017-10-25 7:32 ` Dan Carpenter
2017-10-25 7:32 ` Dan Carpenter
2017-10-25 7:32 ` Dan Carpenter
2017-10-25 7:39 ` Unicode characters in commit messages? SF Markus Elfring
2017-10-25 7:39 ` SF Markus Elfring
2017-10-25 8:43 ` Dan Carpenter
2017-10-25 8:43 ` Dan Carpenter
2017-10-25 8:43 ` Dan Carpenter
2017-10-25 9:16 ` SF Markus Elfring
2017-10-25 9:16 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d155gdyw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.