All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
Date: Fri, 27 Oct 2017 21:45:17 +0300	[thread overview]
Message-ID: <87tvyke8g2.fsf@intel.com> (raw)
In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net>

On Tue, 24 Oct 2017, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle software.

Please also look into the GCC software, which will detect that your
patch does not compile.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
Date: Fri, 27 Oct 2017 18:45:17 +0000	[thread overview]
Message-ID: <87tvyke8g2.fsf@intel.com> (raw)
In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net>

On Tue, 24 Oct 2017, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle software.

Please also look into the GCC software, which will detect that your
patch does not compile.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
Date: Fri, 27 Oct 2017 21:45:17 +0300	[thread overview]
Message-ID: <87tvyke8g2.fsf@intel.com> (raw)
In-Reply-To: <9fafa688-f699-c587-ef77-840efa71bf76@users.sourceforge.net>

On Tue, 24 Oct 2017, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle software.

Please also look into the GCC software, which will detect that your
patch does not compile.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-10-27 18:45 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 16:00 [PATCH 0/2] R-Car Display Unit: Fine-tuning for some function implementations SF Markus Elfring
2017-10-24 16:00 ` SF Markus Elfring
2017-10-24 16:01 ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() SF Markus Elfring
2017-10-24 16:01   ` SF Markus Elfring
2017-10-25  6:01   ` Dan Carpenter
2017-10-25  6:01     ` Dan Carpenter
2017-10-25  6:01     ` Dan Carpenter
2017-10-25  6:35     ` Clarification for approaches around exception handling SF Markus Elfring
2017-10-25  6:35       ` SF Markus Elfring
2017-10-25  6:35       ` SF Markus Elfring
2017-10-26 12:40   ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() kbuild test robot
2017-10-26 12:40     ` kbuild test robot
2017-10-26 12:40     ` kbuild test robot
2017-11-01 15:38     ` [PATCH v2 0/2] R-Car Display Unit: Fine-tuning for some function implementations SF Markus Elfring
2017-11-01 15:38       ` SF Markus Elfring
2017-11-01 15:38       ` SF Markus Elfring
2017-11-01 15:39       ` [PATCH v2 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() SF Markus Elfring
2017-11-01 15:39         ` SF Markus Elfring
2017-11-01 15:39         ` SF Markus Elfring
2017-11-01 15:41       ` [PATCH v2 2/2] drm/rcar-du: Adjust 14 checks for null pointers SF Markus Elfring
2017-11-01 15:41         ` SF Markus Elfring
2017-11-01 15:41         ` SF Markus Elfring
2017-10-27 18:45   ` Jani Nikula [this message]
2017-10-27 18:45     ` [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init() Jani Nikula
2017-10-27 18:45     ` Jani Nikula
2017-10-29 11:01     ` Geert Uytterhoeven
2017-10-29 11:01       ` Geert Uytterhoeven
2017-10-29 17:12     ` Laurent Pinchart
2017-10-29 17:12       ` Laurent Pinchart
2017-10-29 18:19       ` SF Markus Elfring
2017-10-29 18:19         ` SF Markus Elfring
2017-10-29 18:19         ` SF Markus Elfring
2017-10-30  9:52       ` [PATCH 1/2] " Jani Nikula
2017-10-30  9:52         ` Jani Nikula
2017-10-30 10:03         ` SF Markus Elfring
2017-10-30 10:03           ` SF Markus Elfring
2017-10-30 10:03           ` SF Markus Elfring
2017-10-30 13:18         ` [PATCH 1/2] " Laurent Pinchart
2017-10-30 13:18           ` Laurent Pinchart
2017-10-24 16:02 ` [PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers SF Markus Elfring
2017-10-24 16:02   ` SF Markus Elfring
2017-10-24 16:02   ` SF Markus Elfring
2017-10-25  6:02   ` Dan Carpenter
2017-10-25  6:02     ` Dan Carpenter
2017-10-25  6:02     ` Dan Carpenter
2017-10-25  6:44     ` SF Markus Elfring
2017-10-25  6:44       ` SF Markus Elfring
2017-10-25  7:32       ` Dan Carpenter
2017-10-25  7:32         ` Dan Carpenter
2017-10-25  7:32         ` Dan Carpenter
2017-10-25  7:39         ` Unicode characters in commit messages? SF Markus Elfring
2017-10-25  7:39           ` SF Markus Elfring
2017-10-25  8:43           ` Dan Carpenter
2017-10-25  8:43             ` Dan Carpenter
2017-10-25  8:43             ` Dan Carpenter
2017-10-25  9:16             ` SF Markus Elfring
2017-10-25  9:16               ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvyke8g2.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.