Re: [PATCH 2/2] ath11k: mhi: use mhi_sync_power_up()

From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: <ath11k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath11k: mhi: use mhi_sync_power_up()
Date: Fri, 28 Jan 2022 11:06:20 +0200	[thread overview]
Message-ID: <87k0eki60j.fsf@kernel.org> (raw)
In-Reply-To: <a0f8c8fa-2f26-e522-a3b9-e530aba9994b@quicinc.com> (Jeff Johnson's message of "Thu, 27 Jan 2022 15:36:54 -0800")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 1/27/2022 1:01 AM, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>>
>> If amss.bin was missing ath11k would crash during 'rmmod ath11k_pci'. The
>> reason for that was that we were using mhi_async_power_up() which does not
>> check any errors. But mhi_sync_power_up() on the other hand does check for
>> errors so let's use that to fix the crash.
>>
>> I was not able to find a reason why an async version was used. This call ends
>> is called from ath11k_hif_power_up() which can sleep, so sync version should be
>> safe to use.
>
> I could not parse the 2nd sentence: This call ends is called

Heh, that is a pretty horrible sentence. How about this:

"ath11k_mhi_start() (which enables state ATH11K_MHI_POWER_ON) is called
from ath11k_hif_power_up(), which can sleep. So sync version should be
safe to use here."

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k