From: Jani Nikula <jani.nikula@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging
Date: Thu, 19 Dec 2019 16:23:49 +0200 [thread overview]
Message-ID: <87woaswg0a.fsf@intel.com> (raw)
In-Reply-To: <20191217185712.GC30809@ravnborg.org>
On Tue, 17 Dec 2019, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote:
>> Prefer drm_dbg_kms() and drm_err() over all other logging.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thanks for the review, pushed up to this patch.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> index b9bcd310ca2d..3a7ace19a902 100644
>> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> @@ -74,8 +74,7 @@ drm_gem_fb_alloc(struct drm_device *dev,
>>
>> ret = drm_framebuffer_init(dev, fb, funcs);
>> if (ret) {
>> - DRM_DEV_ERROR(dev->dev, "Failed to init framebuffer: %d\n",
>> - ret);
>> + drm_err(dev, "Failed to init framebuffer: %d\n", ret);
>> kfree(fb);
>> return ERR_PTR(ret);
>> }
>> @@ -160,7 +159,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
>>
>> objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
>> if (!objs[i]) {
>> - DRM_DEBUG_KMS("Failed to lookup GEM object\n");
>> + drm_dbg_kms(dev, "Failed to lookup GEM object\n");
>> ret = -ENOENT;
>> goto err_gem_object_put;
>> }
>> --
>> 2.20.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/8] drm/gem-fb-helper: convert to drm device based logging
Date: Thu, 19 Dec 2019 16:23:49 +0200 [thread overview]
Message-ID: <87woaswg0a.fsf@intel.com> (raw)
In-Reply-To: <20191217185712.GC30809@ravnborg.org>
On Tue, 17 Dec 2019, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote:
>> Prefer drm_dbg_kms() and drm_err() over all other logging.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thanks for the review, pushed up to this patch.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> index b9bcd310ca2d..3a7ace19a902 100644
>> --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c
>> @@ -74,8 +74,7 @@ drm_gem_fb_alloc(struct drm_device *dev,
>>
>> ret = drm_framebuffer_init(dev, fb, funcs);
>> if (ret) {
>> - DRM_DEV_ERROR(dev->dev, "Failed to init framebuffer: %d\n",
>> - ret);
>> + drm_err(dev, "Failed to init framebuffer: %d\n", ret);
>> kfree(fb);
>> return ERR_PTR(ret);
>> }
>> @@ -160,7 +159,7 @@ drm_gem_fb_create_with_funcs(struct drm_device *dev, struct drm_file *file,
>>
>> objs[i] = drm_gem_object_lookup(file, mode_cmd->handles[i]);
>> if (!objs[i]) {
>> - DRM_DEBUG_KMS("Failed to lookup GEM object\n");
>> + drm_dbg_kms(dev, "Failed to lookup GEM object\n");
>> ret = -ENOENT;
>> goto err_gem_object_put;
>> }
>> --
>> 2.20.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-19 14:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 12:30 [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-10 12:30 ` [PATCH 2/8] drm/client: convert to drm device based logging Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-17 18:51 ` Sam Ravnborg
2019-12-17 18:51 ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 3/8] drm/fb-helper: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-17 18:56 ` Sam Ravnborg
2019-12-17 18:56 ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 4/8] drm/gem-fb-helper: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-17 18:57 ` Sam Ravnborg
2019-12-17 18:57 ` [Intel-gfx] " Sam Ravnborg
2019-12-19 14:23 ` Jani Nikula [this message]
2019-12-19 14:23 ` Jani Nikula
2019-12-10 12:30 ` [PATCH 5/8] drm/mipi-dbi: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-17 19:00 ` Sam Ravnborg
2019-12-17 19:00 ` [Intel-gfx] " Sam Ravnborg
2019-12-17 19:10 ` Sam Ravnborg
2019-12-17 19:10 ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 6/8] drm/atomic: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-12 8:07 ` [6/8] " james qian wang (Arm Technology China)
2019-12-12 8:07 ` [Intel-gfx] " james qian wang (Arm Technology China)
2019-12-12 8:33 ` Jani Nikula
2019-12-12 8:33 ` [Intel-gfx] " Jani Nikula
2019-12-17 19:07 ` [PATCH 6/8] " Sam Ravnborg
2019-12-17 19:07 ` [Intel-gfx] " Sam Ravnborg
2019-12-10 12:30 ` [PATCH 7/8] drm/i915/uc: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-10 12:30 ` [PATCH 8/8] drm/i915/wopcm: " Jani Nikula
2019-12-10 12:30 ` [Intel-gfx] " Jani Nikula
2019-12-10 12:34 ` [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-10 12:34 ` [Intel-gfx] " Jani Nikula
2019-12-10 22:07 ` Daniel Vetter
2019-12-10 22:07 ` [Intel-gfx] " Daniel Vetter
2019-12-10 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] " Patchwork
2019-12-10 19:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-12 21:53 ` [PATCH 1/8] " Sam Ravnborg
2019-12-12 21:53 ` [Intel-gfx] " Sam Ravnborg
2019-12-13 14:41 ` Jani Nikula
2019-12-13 14:41 ` [Intel-gfx] " Jani Nikula
2019-12-13 13:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros (rev2) Patchwork
2019-12-13 15:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-13 19:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/print: introduce new struct drm_device based logging macros (rev3) Patchwork
2019-12-13 20:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-14 16:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-17 14:45 ` [PATCH 1/8] drm/print: introduce new struct drm_device based logging macros Jani Nikula
2019-12-17 14:45 ` [Intel-gfx] " Jani Nikula
2019-12-17 16:11 ` Sam Ravnborg
2019-12-17 16:11 ` [Intel-gfx] " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woaswg0a.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.