From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
Mathias Nyman <mathias.nyman@intel.com>,
devicetree@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Igal Liberman <igall@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 05/10] phy: add A3700 UTMI PHY driver
Date: Fri, 18 Jan 2019 17:36:36 +0100 [thread overview]
Message-ID: <87zhrxly7f.fsf@FE-laptop> (raw)
In-Reply-To: <20190111133133.24803-6-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Fri, 11 Jan 2019 14:31:28 +0100")
Hi Miquel,
I have only a few smallish remarks:
On ven., janv. 11 2019, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Marvell Armada 3700 SoC has two USB controllers, each of them being
> wired to an internal UTMI PHY. Add a driver to control them.
>
> Igal Liberman worked on supporting the PHY, I took the while 'register
> configuration' from his work and rewrote almost entirely the
> driver/bindings around it.
>
> Co-developed-by: Igal Liberman <igall@marvell.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Igal Liberman <igall@marvell.com>
> ---
[...]
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> new file mode 100644
> index 000000000000..97d8235d661d
> --- /dev/null
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> @@ -0,0 +1,297 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018 Marvell
> + *
> + * Authors:
> + * Evan Wang <xswang@marvell.com>
> + * Miquèl Raynal <miquel.raynal@bootlin.com>
If it is co-developed with Igal Liberman, shouldn't be added here too?
[...]
> +static int mvebu_a3700_utmi_phy_power_on(struct phy *phy)
> +{
> + struct mvebu_a3700_utmi *utmi = phy_get_drvdata(phy);
> + struct device *dev = &phy->dev;
> + int usb32 = utmi->caps->usb32;
> + int ret = 0;
> + u32 reg;
> +
> + if (!utmi)
> + return -ENODEV;
> +
> + /*
> + * Setup PLL. 40MHz clock used to be the default, bein 25MHz now.
bein?
> + * See "PLL Settings for Typical REFCLK" table.
[...]
> +
> + /* Wait for squetch calibration */
squetch?
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Igal Liberman <igall@marvell.com>
Subject: [v2,05/10] phy: add A3700 UTMI PHY driver
Date: Fri, 18 Jan 2019 17:36:36 +0100 [thread overview]
Message-ID: <87zhrxly7f.fsf@FE-laptop> (raw)
Hi Miquel,
I have only a few smallish remarks:
On ven., janv. 11 2019, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Marvell Armada 3700 SoC has two USB controllers, each of them being
> wired to an internal UTMI PHY. Add a driver to control them.
>
> Igal Liberman worked on supporting the PHY, I took the while 'register
> configuration' from his work and rewrote almost entirely the
> driver/bindings around it.
>
> Co-developed-by: Igal Liberman <igall@marvell.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Igal Liberman <igall@marvell.com>
> ---
[...]
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> new file mode 100644
> index 000000000000..97d8235d661d
> --- /dev/null
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> @@ -0,0 +1,297 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018 Marvell
> + *
> + * Authors:
> + * Evan Wang <xswang@marvell.com>
> + * Miquèl Raynal <miquel.raynal@bootlin.com>
If it is co-developed with Igal Liberman, shouldn't be added here too?
[...]
> +static int mvebu_a3700_utmi_phy_power_on(struct phy *phy)
> +{
> + struct mvebu_a3700_utmi *utmi = phy_get_drvdata(phy);
> + struct device *dev = &phy->dev;
> + int usb32 = utmi->caps->usb32;
> + int ret = 0;
> + u32 reg;
> +
> + if (!utmi)
> + return -ENODEV;
> +
> + /*
> + * Setup PLL. 40MHz clock used to be the default, bein 25MHz now.
bein?
> + * See "PLL Settings for Typical REFCLK" table.
[...]
> +
> + /* Wait for squetch calibration */
squetch?
Gregory
next prev parent reply other threads:[~2019-01-18 16:36 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 13:31 [PATCH v2 00/10] A3700 USB S2RAM support Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 01/10] usb: core: comply to PHY framework Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,01/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 02/10] usb: host: xhci: mvebu: add reset on resume quirk Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,02/10] " Miquel Raynal
2019-01-18 16:04 ` [PATCH v2 02/10] " Gregory CLEMENT
2019-01-18 16:04 ` Gregory CLEMENT
2019-01-18 16:04 ` [v2,02/10] " Gregory CLEMENT
2019-01-21 10:54 ` [PATCH v2 02/10] " Miquel Raynal
2019-01-21 10:54 ` [v2,02/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 03/10] usb: ehci-orion: avoid double PHY initialization Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,03/10] " Miquel Raynal
2019-01-11 18:03 ` [PATCH v2 03/10] " Sergei Shtylyov
2019-01-11 18:03 ` Sergei Shtylyov
2019-01-11 18:03 ` [v2,03/10] " Sergei Shtylyov
2019-01-21 10:00 ` [PATCH v2 03/10] " Miquel Raynal
2019-01-21 10:00 ` [v2,03/10] " Miquel Raynal
2019-01-18 16:25 ` [PATCH v2 03/10] " Gregory CLEMENT
2019-01-18 16:25 ` Gregory CLEMENT
2019-01-18 16:25 ` [v2,03/10] " Gregory CLEMENT
2019-01-21 9:55 ` [PATCH v2 03/10] " Miquel Raynal
2019-01-21 9:55 ` [v2,03/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 04/10] usb: ehci-orion: add S2RAM support Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,04/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 05/10] phy: add A3700 UTMI PHY driver Miquel Raynal
2019-01-11 13:31 ` [v2,05/10] " Miquel Raynal
2019-01-15 2:40 ` [PATCH v2 05/10] " Chunfeng Yun
2019-01-15 2:40 ` [v2,05/10] " Chunfeng Yun
2019-01-16 9:20 ` [PATCH v2 05/10] " Kishon Vijay Abraham I
2019-01-16 9:20 ` [v2,05/10] " Kishon Vijay Abraham I
2019-01-21 10:37 ` [PATCH v2 05/10] " Miquel Raynal
2019-01-21 10:37 ` [v2,05/10] " Miquel Raynal
2019-01-18 16:36 ` Gregory CLEMENT [this message]
2019-01-18 16:36 ` Gregory CLEMENT
2019-01-21 10:24 ` [PATCH v2 05/10] " Miquel Raynal
2019-01-21 10:24 ` [v2,05/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 06/10] dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,06/10] " Miquel Raynal
2019-01-15 21:44 ` [PATCH v2 06/10] " Rob Herring
2019-01-15 21:44 ` Rob Herring
2019-01-15 21:44 ` [v2,06/10] " Rob Herring
2019-01-16 13:20 ` [PATCH v2 06/10] " Miquel Raynal
2019-01-16 13:20 ` [v2,06/10] " Miquel Raynal
2019-01-16 14:49 ` [PATCH v2 06/10] " Rob Herring
2019-01-16 21:05 ` Rob Herring
2019-01-16 21:05 ` Rob Herring
2019-01-16 21:05 ` [v2,06/10] " Rob Herring
2019-01-11 13:31 ` [PATCH v2 07/10] MAINTAINERS: phy: fill Armada 3700 PHY drivers entry Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,07/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 08/10] ARM64: dts: marvell: armada-37xx: fix USB2 memory region Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,08/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 09/10] ARM64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,09/10] " Miquel Raynal
2019-01-11 13:31 ` [PATCH v2 10/10] ARM64: dts: marvell: armada-37xx: link USB hosts with their PHYs Miquel Raynal
2019-01-11 13:31 ` Miquel Raynal
2019-01-11 13:31 ` [v2,10/10] " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhrxly7f.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=igall@marvell.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.