From: Auger Eric <eric.auger@redhat.com>
To: Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, maz@kernel.org,
james.morse@arm.com, julien.thierry.kdev@gmail.com,
suzuki.poulose@arm.com
Subject: Re: [PATCH 4/5] KVM: arm64: Update comment in kvm_vgic_map_resources()
Date: Mon, 14 Dec 2020 13:59:32 +0100 [thread overview]
Message-ID: <8a57fd41-d707-d88e-dd00-ac643acfd7c0@redhat.com> (raw)
In-Reply-To: <20201201150157.223625-5-alexandru.elisei@arm.com>
Hi Alexandru,
On 12/1/20 4:01 PM, Alexandru Elisei wrote:
> vgic_v3_map_resources() returns -EBUSY if the VGIC isn't initialized,
> update the comment to kvm_vgic_map_resources() to match what the function
> does.
>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> ---
> arch/arm64/kvm/vgic/vgic-init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c
> index a2f4d1c85f00..8942b2191bcf 100644
> --- a/arch/arm64/kvm/vgic/vgic-init.c
> +++ b/arch/arm64/kvm/vgic/vgic-init.c
> @@ -419,7 +419,8 @@ int vgic_lazy_init(struct kvm *kvm)
> * Map the MMIO regions depending on the VGIC model exposed to the guest
> * called on the first VCPU run.
> * Also map the virtual CPU interface into the VM.
> - * v2/v3 derivatives call vgic_init if not already done.
> + * v2 calls vgic_init if not already done.
nit: s/vgic_init/vgic_init()?
> + * v3 and derivatives return an error if the VGIC is not initialized.
> * vgic_ready() returns true if this function has succeeded.
> * @kvm: kvm struct pointer
> */
>
Besides
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Auger Eric <eric.auger@redhat.com>
To: Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, maz@kernel.org,
james.morse@arm.com, julien.thierry.kdev@gmail.com,
suzuki.poulose@arm.com
Subject: Re: [PATCH 4/5] KVM: arm64: Update comment in kvm_vgic_map_resources()
Date: Mon, 14 Dec 2020 13:59:32 +0100 [thread overview]
Message-ID: <8a57fd41-d707-d88e-dd00-ac643acfd7c0@redhat.com> (raw)
In-Reply-To: <20201201150157.223625-5-alexandru.elisei@arm.com>
Hi Alexandru,
On 12/1/20 4:01 PM, Alexandru Elisei wrote:
> vgic_v3_map_resources() returns -EBUSY if the VGIC isn't initialized,
> update the comment to kvm_vgic_map_resources() to match what the function
> does.
>
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
> ---
> arch/arm64/kvm/vgic/vgic-init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/vgic/vgic-init.c b/arch/arm64/kvm/vgic/vgic-init.c
> index a2f4d1c85f00..8942b2191bcf 100644
> --- a/arch/arm64/kvm/vgic/vgic-init.c
> +++ b/arch/arm64/kvm/vgic/vgic-init.c
> @@ -419,7 +419,8 @@ int vgic_lazy_init(struct kvm *kvm)
> * Map the MMIO regions depending on the VGIC model exposed to the guest
> * called on the first VCPU run.
> * Also map the virtual CPU interface into the VM.
> - * v2/v3 derivatives call vgic_init if not already done.
> + * v2 calls vgic_init if not already done.
nit: s/vgic_init/vgic_init()?
> + * v3 and derivatives return an error if the VGIC is not initialized.
> * vgic_ready() returns true if this function has succeeded.
> * @kvm: kvm struct pointer
> */
>
Besides
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-14 12:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:01 [PATCH 0/5] KVM: arm64: Miscellaneous improvements Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-01 15:01 ` [PATCH 1/5] KVM: Documentation: Add arm64 KVM_RUN error codes Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-01 15:01 ` [PATCH 2/5] KVM: arm64: arch_timer: Remove VGIC initialization check Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-14 12:45 ` Auger Eric
2020-12-14 12:45 ` Auger Eric
2020-12-01 15:01 ` [PATCH 3/5] KVM: arm64: Move double-checked lock to kvm_vgic_map_resources() Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-14 12:55 ` Auger Eric
2020-12-14 12:55 ` Auger Eric
2020-12-27 14:36 ` Marc Zyngier
2020-12-27 14:36 ` Marc Zyngier
2020-12-01 15:01 ` [PATCH 4/5] KVM: arm64: Update comment in kvm_vgic_map_resources() Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-14 12:59 ` Auger Eric [this message]
2020-12-14 12:59 ` Auger Eric
2020-12-01 15:01 ` [PATCH 5/5] KVM: arm64: Remove redundant call to kvm_pmu_vcpu_reset() Alexandru Elisei
2020-12-01 15:01 ` Alexandru Elisei
2020-12-14 13:48 ` Auger Eric
2020-12-14 13:48 ` Auger Eric
2020-12-14 14:02 ` Alexandru Elisei
2020-12-14 14:02 ` Alexandru Elisei
2020-12-15 9:15 ` Auger Eric
2020-12-15 9:15 ` Auger Eric
2020-12-27 14:41 ` [PATCH 0/5] KVM: arm64: Miscellaneous improvements Marc Zyngier
2020-12-27 14:41 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a57fd41-d707-d88e-dd00-ac643acfd7c0@redhat.com \
--to=eric.auger@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.