From: Logan Gunthorpe <logang@deltatee.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] RISC-V: Implement sparsemem
Date: Thu, 11 Oct 2018 16:24:33 +0000 [thread overview]
Message-ID: <8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com> (raw)
In-Reply-To: <20181011133730.GB7276@lst.de>
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote:
>> +/*
>> + * Log2 of the upper bound of the size of a struct page. Used for sizing
>> + * the vmemmap region only, does not affect actual memory footprint.
>> + * We don't use sizeof(struct page) directly since taking its size here
>> + * requires its definition to be available at this point in the inclusion
>> + * chain, and it may not be a power of 2 in the first place.
>> + */
>> +#define STRUCT_PAGE_MAX_SHIFT 6
>
> I know this is copied from arm64, but wouldn't this be a good time
> to move this next to the struct page defintion?
>
> Also this:
>
> arch/arm64/mm/init.c: BUILD_BUG_ON(sizeof(struct page) > (1 << STRUCT_PAGE_MAX_SHIFT));
>
> should move to comment code (or would have to be duplicated for riscv)
Makes sense. Where is a good place for the BUILD_BUG_ON in common code?
I've queued up changes for your other feedback.
Thanks,
Logan
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Andrew Waterman <andrew@sifive.com>,
linux-sh@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,
Zong Li <zong@andestech.com>,
linux-mm@kvack.org, Olof Johansson <olof@lixom.net>,
linux-riscv@lists.infradead.org,
Michael Clark <michaeljclark@mac.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] RISC-V: Implement sparsemem
Date: Thu, 11 Oct 2018 10:24:33 -0600 [thread overview]
Message-ID: <8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com> (raw)
In-Reply-To: <20181011133730.GB7276@lst.de>
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote:
>> +/*
>> + * Log2 of the upper bound of the size of a struct page. Used for sizing
>> + * the vmemmap region only, does not affect actual memory footprint.
>> + * We don't use sizeof(struct page) directly since taking its size here
>> + * requires its definition to be available at this point in the inclusion
>> + * chain, and it may not be a power of 2 in the first place.
>> + */
>> +#define STRUCT_PAGE_MAX_SHIFT 6
>
> I know this is copied from arm64, but wouldn't this be a good time
> to move this next to the struct page defintion?
>
> Also this:
>
> arch/arm64/mm/init.c: BUILD_BUG_ON(sizeof(struct page) > (1 << STRUCT_PAGE_MAX_SHIFT));
>
> should move to comment code (or would have to be duplicated for riscv)
Makes sense. Where is a good place for the BUILD_BUG_ON in common code?
I've queued up changes for your other feedback.
Thanks,
Logan
WARNING: multiple messages have this Message-ID (diff)
From: logang@deltatee.com (Logan Gunthorpe)
To: linux-riscv@lists.infradead.org
Subject: [PATCH 5/5] RISC-V: Implement sparsemem
Date: Thu, 11 Oct 2018 10:24:33 -0600 [thread overview]
Message-ID: <8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com> (raw)
In-Reply-To: <20181011133730.GB7276@lst.de>
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote:
>> +/*
>> + * Log2 of the upper bound of the size of a struct page. Used for sizing
>> + * the vmemmap region only, does not affect actual memory footprint.
>> + * We don't use sizeof(struct page) directly since taking its size here
>> + * requires its definition to be available at this point in the inclusion
>> + * chain, and it may not be a power of 2 in the first place.
>> + */
>> +#define STRUCT_PAGE_MAX_SHIFT 6
>
> I know this is copied from arm64, but wouldn't this be a good time
> to move this next to the struct page defintion?
>
> Also this:
>
> arch/arm64/mm/init.c: BUILD_BUG_ON(sizeof(struct page) > (1 << STRUCT_PAGE_MAX_SHIFT));
>
> should move to comment code (or would have to be duplicated for riscv)
Makes sense. Where is a good place for the BUILD_BUG_ON in common code?
I've queued up changes for your other feedback.
Thanks,
Logan
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Andrew Waterman <andrew@sifive.com>,
linux-sh@vger.kernel.org, Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, Stephen Bates <sbates@raithlin.com>,
Zong Li <zong@andestech.com>,
linux-mm@kvack.org, Olof Johansson <olof@lixom.net>,
linux-riscv@lists.infradead.org,
Michael Clark <michaeljclark@mac.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] RISC-V: Implement sparsemem
Date: Thu, 11 Oct 2018 10:24:33 -0600 [thread overview]
Message-ID: <8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com> (raw)
Message-ID: <20181011162433.K9Y9kRpFvqJPYG88VbD5N_lvSGjgWFFn9zwHqk_I2oo@z> (raw)
In-Reply-To: <20181011133730.GB7276@lst.de>
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote:
>> +/*
>> + * Log2 of the upper bound of the size of a struct page. Used for sizing
>> + * the vmemmap region only, does not affect actual memory footprint.
>> + * We don't use sizeof(struct page) directly since taking its size here
>> + * requires its definition to be available at this point in the inclusion
>> + * chain, and it may not be a power of 2 in the first place.
>> + */
>> +#define STRUCT_PAGE_MAX_SHIFT 6
>
> I know this is copied from arm64, but wouldn't this be a good time
> to move this next to the struct page defintion?
>
> Also this:
>
> arch/arm64/mm/init.c: BUILD_BUG_ON(sizeof(struct page) > (1 << STRUCT_PAGE_MAX_SHIFT));
>
> should move to comment code (or would have to be duplicated for riscv)
Makes sense. Where is a good place for the BUILD_BUG_ON in common code?
I've queued up changes for your other feedback.
Thanks,
Logan
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: logang@deltatee.com (Logan Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] RISC-V: Implement sparsemem
Date: Thu, 11 Oct 2018 10:24:33 -0600 [thread overview]
Message-ID: <8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com> (raw)
In-Reply-To: <20181011133730.GB7276@lst.de>
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote:
>> +/*
>> + * Log2 of the upper bound of the size of a struct page. Used for sizing
>> + * the vmemmap region only, does not affect actual memory footprint.
>> + * We don't use sizeof(struct page) directly since taking its size here
>> + * requires its definition to be available at this point in the inclusion
>> + * chain, and it may not be a power of 2 in the first place.
>> + */
>> +#define STRUCT_PAGE_MAX_SHIFT 6
>
> I know this is copied from arm64, but wouldn't this be a good time
> to move this next to the struct page defintion?
>
> Also this:
>
> arch/arm64/mm/init.c: BUILD_BUG_ON(sizeof(struct page) > (1 << STRUCT_PAGE_MAX_SHIFT));
>
> should move to comment code (or would have to be duplicated for riscv)
Makes sense. Where is a good place for the BUILD_BUG_ON in common code?
I've queued up changes for your other feedback.
Thanks,
Logan
next prev parent reply other threads:[~2018-10-11 16:24 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 16:16 [PATCH 0/5] sparsemem support for RISC-V Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 1/5] mm/sparse: add common helper to mark all memblocks present Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-11 13:30 ` Christoph Hellwig
2018-10-11 13:30 ` Christoph Hellwig
2018-10-11 13:30 ` Christoph Hellwig
2018-10-11 13:30 ` Christoph Hellwig
2018-10-11 13:30 ` Christoph Hellwig
2018-10-05 16:16 ` [PATCH 2/5] ARM: mm: make use of new memblocks_present() helper Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 3/5] arm64: " Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:16 ` [PATCH 4/5] sh: " Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 5/5] RISC-V: Implement sparsemem Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-05 16:16 ` Logan Gunthorpe
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 12:18 ` Stephen Bates
2018-10-11 12:18 ` Stephen Bates
2018-10-11 12:18 ` Stephen Bates
2018-10-11 12:18 ` Stephen Bates
2018-10-11 12:18 ` Stephen Bates
2018-10-11 12:18 ` Stephen Bates
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 16:24 ` Logan Gunthorpe [this message]
2018-10-11 16:24 ` Logan Gunthorpe
2018-10-11 16:24 ` Logan Gunthorpe
2018-10-11 16:24 ` Logan Gunthorpe
2018-10-11 16:24 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cea5ffa-5fbf-8ea2-b673-20e2d09a910d@deltatee.com \
--to=logang@deltatee.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.