From: Shawn Lin <shawn.lin@rock-chips.com>
To: Xing Zheng <zhengxing@rock-chips.com>, heiko@sntech.de
Cc: shawn.lin@rock-chips.com, mturquette@baylibre.com,
sboyd@codeaurora.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, briannorris@chromium.org,
huangtao@rock-chips.com, zhangqing@rock-chips.com
Subject: Re: [RESEND PATCH 5/6] clk: rockchip: rk3399: delete the CLK_IGNORE_UNUSED for aclk_pcie
Date: Mon, 1 Aug 2016 16:47:32 +0800 [thread overview]
Message-ID: <8ee66f8c-f758-45ef-6e21-f757157d2fe4@rock-chips.com> (raw)
In-Reply-To: <1470025485-4218-1-git-send-email-zhengxing@rock-chips.com>
On 2016/8/1 12:24, Xing Zheng wrote:
> From: Elaine Zhang <zhangqing@rock-chips.com>
>
> allow aclk_pcie and aclk_perf_pcie disabled when unused.
>
Thanks for landing it. Yes, my pcie driver will control it
manually, and this patch looks the same as what we land on
the downstream tree, so
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>
> ---
>
> drivers/clk/rockchip/clk-rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 74afec0..4a15ce5b 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -848,9 +848,9 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = {
> RK3399_CLKSEL_CON(14), 12, 2, DFLAGS,
> RK3399_CLKGATE_CON(5), 4, GFLAGS),
>
> - GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 2, GFLAGS),
> - GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 10, GFLAGS),
> GATE(0, "aclk_perihp_noc", "aclk_perihp", CLK_IGNORE_UNUSED,
> RK3399_CLKGATE_CON(20), 12, GFLAGS),
>
--
Best Regards
Shawn Lin
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RESEND PATCH 5/6] clk: rockchip: rk3399: delete the CLK_IGNORE_UNUSED for aclk_pcie
Date: Mon, 1 Aug 2016 16:47:32 +0800 [thread overview]
Message-ID: <8ee66f8c-f758-45ef-6e21-f757157d2fe4@rock-chips.com> (raw)
In-Reply-To: <1470025485-4218-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
On 2016/8/1 12:24, Xing Zheng wrote:
> From: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> allow aclk_pcie and aclk_perf_pcie disabled when unused.
>
Thanks for landing it. Yes, my pcie driver will control it
manually, and this patch looks the same as what we land on
the downstream tree, so
Reviewed-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> ---
>
> drivers/clk/rockchip/clk-rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 74afec0..4a15ce5b 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -848,9 +848,9 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = {
> RK3399_CLKSEL_CON(14), 12, 2, DFLAGS,
> RK3399_CLKGATE_CON(5), 4, GFLAGS),
>
> - GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 2, GFLAGS),
> - GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 10, GFLAGS),
> GATE(0, "aclk_perihp_noc", "aclk_perihp", CLK_IGNORE_UNUSED,
> RK3399_CLKGATE_CON(20), 12, GFLAGS),
>
--
Best Regards
Shawn Lin
WARNING: multiple messages have this Message-ID (diff)
From: shawn.lin@rock-chips.com (Shawn Lin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 5/6] clk: rockchip: rk3399: delete the CLK_IGNORE_UNUSED for aclk_pcie
Date: Mon, 1 Aug 2016 16:47:32 +0800 [thread overview]
Message-ID: <8ee66f8c-f758-45ef-6e21-f757157d2fe4@rock-chips.com> (raw)
In-Reply-To: <1470025485-4218-1-git-send-email-zhengxing@rock-chips.com>
On 2016/8/1 12:24, Xing Zheng wrote:
> From: Elaine Zhang <zhangqing@rock-chips.com>
>
> allow aclk_pcie and aclk_perf_pcie disabled when unused.
>
Thanks for landing it. Yes, my pcie driver will control it
manually, and this patch looks the same as what we land on
the downstream tree, so
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>
> ---
>
> drivers/clk/rockchip/clk-rk3399.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 74afec0..4a15ce5b 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -848,9 +848,9 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = {
> RK3399_CLKSEL_CON(14), 12, 2, DFLAGS,
> RK3399_CLKGATE_CON(5), 4, GFLAGS),
>
> - GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PERF_PCIE, "aclk_perf_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 2, GFLAGS),
> - GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", CLK_IGNORE_UNUSED,
> + GATE(ACLK_PCIE, "aclk_pcie", "aclk_perihp", 0,
> RK3399_CLKGATE_CON(20), 10, GFLAGS),
> GATE(0, "aclk_perihp_noc", "aclk_perihp", CLK_IGNORE_UNUSED,
> RK3399_CLKGATE_CON(20), 12, GFLAGS),
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2016-08-01 9:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 4:23 [RESEND PATCH 0/6] fix and optimize some clock configuration for the RK3399 platfom Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:23 ` [RESEND PATCH 1/6] clk: rockchip: rk3399: export USBPHYx_480M_SRC clock IDs Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:23 ` [RESEND PATCH 2/6] clk: rockchip: rk3399: export 480M_SRC clock id for usbphy0/usbphy1 Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:23 ` [RESEND PATCH 3/6] clk: rockchip: rk3399: fix incorrect aclk_emmc source gate bits Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:23 ` [RESEND PATCH 4/6] clk: rockchip: rk3399: add 65MHz and 106.5MHz clocks for HDMI Xing Zheng
2016-08-01 4:23 ` Xing Zheng
2016-08-01 4:24 ` [RESEND PATCH 5/6] clk: rockchip: rk3399: delete the CLK_IGNORE_UNUSED for aclk_pcie Xing Zheng
2016-08-01 4:24 ` Xing Zheng
2016-08-01 8:47 ` Shawn Lin [this message]
2016-08-01 8:47 ` Shawn Lin
2016-08-01 8:47 ` Shawn Lin
2016-08-01 4:25 ` [RESEND PATCH 6/6] clk: rockchip: rk3399: Add support frac mode frequencies Xing Zheng
2016-08-01 4:25 ` Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee66f8c-f758-45ef-6e21-f757157d2fe4@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zhangqing@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.