From: Marc Zyngier <maz@kernel.org> To: Thomas Gleixner <tglx@linutronix.de> Cc: Frank Wunderlich <frank-w@public-files.de>, Ryder Lee <ryder.lee@mediatek.com>, linux-mediatek@lists.infradead.org, Frank Wunderlich <linux@fw-web.de>, linux-kernel@vger.kernel.org, Matthias Brugger <matthias.bgg@gmail.com>, linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com> Subject: Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h Date: Tue, 03 Nov 2020 09:54:23 +0000 [thread overview] Message-ID: <901c5eb8bbaa3fe53ddc8f65917e48ef@kernel.org> (raw) In-Reply-To: <877dr38kt8.fsf@nanos.tec.linutronix.de> On 2020-11-02 22:18, Thomas Gleixner wrote: > On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: >> On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: >>> --- a/drivers/pci/probe.c >>> +++ b/drivers/pci/probe.c >>> @@ -871,6 +871,8 @@ static void pci_set_bus_msi_domain(struct pci_bus >>> *bus) >>> d = pci_host_bridge_msi_domain(b); >>> >>> dev_set_msi_domain(&bus->dev, d); >>> + if (!d) >>> + bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; >> >> Hrm, that might break legacy setups (no irqdomain support). I'd rather >> prefer to explicitly tell the pci core at host registration time. > > s/might break/ breaks / Just validated :) For my own edification, can you point me to the failing case? > So we really need some other solution and removing the warning is not > an > option. If MSI is enabled then we want to get a warning when a PCI > device has no MSI domain associated. Explicitly expressing the PCIE > brigde misfeature of not supporting MSI is way better than silently > returning an error code which is swallowed anyway. I don't disagree here, though the PCI_MSI_ARCH_FALLBACKS mechanism makes it more difficult to establish. > Whatever the preferred way is via flags at host probe time or flagging > it post probe I don't care much as long as it is consistent. Host probe time is going to require some changes in the core PCI api, as everything that checks for a MSI domain is based on the pci_bus structure, which is only allocated much later. I'll have a think. M. -- Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org> To: Thomas Gleixner <tglx@linutronix.de> Cc: Ryder Lee <ryder.lee@mediatek.com>, Frank Wunderlich <frank-w@public-files.de>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, Frank Wunderlich <linux@fw-web.de> Subject: Re: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h Date: Tue, 03 Nov 2020 09:54:23 +0000 [thread overview] Message-ID: <901c5eb8bbaa3fe53ddc8f65917e48ef@kernel.org> (raw) In-Reply-To: <877dr38kt8.fsf@nanos.tec.linutronix.de> On 2020-11-02 22:18, Thomas Gleixner wrote: > On Mon, Nov 02 2020 at 17:16, Thomas Gleixner wrote: >> On Mon, Nov 02 2020 at 11:30, Marc Zyngier wrote: >>> --- a/drivers/pci/probe.c >>> +++ b/drivers/pci/probe.c >>> @@ -871,6 +871,8 @@ static void pci_set_bus_msi_domain(struct pci_bus >>> *bus) >>> d = pci_host_bridge_msi_domain(b); >>> >>> dev_set_msi_domain(&bus->dev, d); >>> + if (!d) >>> + bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; >> >> Hrm, that might break legacy setups (no irqdomain support). I'd rather >> prefer to explicitly tell the pci core at host registration time. > > s/might break/ breaks / Just validated :) For my own edification, can you point me to the failing case? > So we really need some other solution and removing the warning is not > an > option. If MSI is enabled then we want to get a warning when a PCI > device has no MSI domain associated. Explicitly expressing the PCIE > brigde misfeature of not supporting MSI is way better than silently > returning an error code which is swallowed anyway. I don't disagree here, though the PCI_MSI_ARCH_FALLBACKS mechanism makes it more difficult to establish. > Whatever the preferred way is via flags at host probe time or flagging > it post probe I don't care much as long as it is consistent. Host probe time is going to require some changes in the core PCI api, as everything that checks for a MSI domain is based on the pci_bus structure, which is only allocated much later. I'll have a think. M. -- Jazz is not dead. It just smells funny... _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-11-03 9:54 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-31 14:03 [PATCH] pci: mediatek: fix warning in msi.h Frank Wunderlich 2020-10-31 14:03 ` Frank Wunderlich 2020-10-31 21:49 ` Thomas Gleixner 2020-10-31 21:49 ` Thomas Gleixner 2020-11-01 9:25 ` Frank Wunderlich 2020-11-01 9:25 ` Frank Wunderlich 2020-11-01 11:17 ` Thomas Gleixner 2020-11-01 11:17 ` Thomas Gleixner 2020-11-01 11:43 ` Marc Zyngier 2020-11-01 11:43 ` Marc Zyngier 2020-11-01 15:58 ` Aw: " Frank Wunderlich 2020-11-01 15:58 ` Frank Wunderlich 2020-11-01 17:54 ` Ryder Lee 2020-11-01 17:54 ` Ryder Lee 2020-11-01 18:27 ` Aw: " Frank Wunderlich 2020-11-01 18:27 ` Frank Wunderlich 2020-11-01 21:47 ` Marc Zyngier 2020-11-01 21:47 ` Marc Zyngier 2020-11-01 22:27 ` Thomas Gleixner 2020-11-01 22:27 ` Thomas Gleixner 2020-11-02 11:30 ` Marc Zyngier 2020-11-02 11:30 ` Marc Zyngier 2020-11-02 11:56 ` Aw: " Frank Wunderlich 2020-11-02 11:56 ` Frank Wunderlich 2020-11-02 13:58 ` Marc Zyngier 2020-11-02 13:58 ` Marc Zyngier 2020-11-02 14:27 ` Aw: " Frank Wunderlich 2020-11-02 14:27 ` Frank Wunderlich 2020-11-02 16:16 ` Aw: " Thomas Gleixner 2020-11-02 16:16 ` Thomas Gleixner 2020-11-02 22:18 ` Thomas Gleixner 2020-11-02 22:18 ` Thomas Gleixner 2020-11-03 9:54 ` Marc Zyngier [this message] 2020-11-03 9:54 ` Marc Zyngier 2020-11-03 10:16 ` Thomas Gleixner 2020-11-03 10:16 ` Thomas Gleixner 2020-11-03 10:29 ` Marc Zyngier 2020-11-03 10:29 ` Marc Zyngier 2020-11-04 16:49 ` Aw: " Frank Wunderlich 2020-11-04 16:49 ` Frank Wunderlich 2020-11-04 23:14 ` Thomas Gleixner 2020-11-04 23:14 ` Thomas Gleixner 2020-11-05 9:20 ` Marc Zyngier 2020-11-05 9:20 ` Marc Zyngier 2020-11-05 13:59 ` Aw: " Frank Wunderlich 2020-11-05 13:59 ` Frank Wunderlich 2020-11-05 23:00 ` Aw: " Thomas Gleixner 2020-11-05 23:00 ` Thomas Gleixner 2020-11-06 9:43 ` Marc Zyngier 2020-11-06 9:43 ` Marc Zyngier 2020-11-21 16:12 ` Aw: " Frank Wunderlich 2020-11-21 16:12 ` Frank Wunderlich 2021-01-03 13:08 ` Frank Wunderlich 2021-01-03 13:08 ` Frank Wunderlich 2021-02-02 16:21 ` Frank Wunderlich 2021-02-02 16:21 ` Frank Wunderlich 2020-11-03 10:31 ` Aw: " Thomas Gleixner 2020-11-03 10:31 ` Thomas Gleixner 2020-11-03 11:41 ` Marc Zyngier 2020-11-03 11:41 ` Marc Zyngier 2020-11-03 14:23 ` Thomas Gleixner 2020-11-03 14:23 ` Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=901c5eb8bbaa3fe53ddc8f65917e48ef@kernel.org \ --to=maz@kernel.org \ --cc=bhelgaas@google.com \ --cc=frank-w@public-files.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux@fw-web.de \ --cc=matthias.bgg@gmail.com \ --cc=ryder.lee@mediatek.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.