From: Frank Wunderlich <frank-w@public-files.de> To: Marc Zyngier <maz@kernel.org> Cc: linux-mediatek@lists.infradead.org, Thomas Gleixner <tglx@linutronix.de>, Frank Wunderlich <linux@fw-web.de>, linux-kernel@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, chuanjia.liu@mediatek.com Subject: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h Date: Sun, 1 Nov 2020 16:58:26 +0100 [thread overview] Message-ID: <trinity-65ad7212-0f00-45e4-b6ba-2ebf0d6ce496-1604246306570@3c-app-gmx-bap08> (raw) In-Reply-To: <87lfflti8q.wl-maz@kernel.org> > Gesendet: Sonntag, 01. November 2020 um 12:43 Uhr > Von: "Marc Zyngier" <maz@kernel.org> > On Sun, 01 Nov 2020 09:25:04 +0000, > Frank Wunderlich <frank-w@public-files.de> wrote: > > It looks like for mt7623 there is no msi domain setup (done via > > mtk_pcie_setup_irq callback + mtk_pcie_init_irq_domain) in mtk pcie > > driver. > > Does this mean that this SoC never handled MSIs the first place? Which > would explain the warning, as there is no MSI domain registered for > the device, and we end-up falling back to arch_setup_msi_irqs(). i tried 5.10-rc1 (without my patch of course) on bananapi-r64 to check if driver on mt7622 works better (this does setup a msi-domain in pcie-driver)....and i got no warning. so mt7623 needs to create an msi-domain or handle it in the correct way e.g. by returning -ENOSPC like in your code. > If this system truly is unable to handle MSIs, one potential > workaround would be to register a PCI-MSI domain that would always > fail its allocation with -ENOSPC. It is really ugly, but would keep > the horror localised. See the patchlet below, which I can't test. > > If this situation is more common than we expect, we may need something > in core code instead. thanks for your code-example, here we need a response from MTK (CC'd Chuanjia Liu) regards Frank
WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <frank-w@public-files.de> To: Marc Zyngier <maz@kernel.org> Cc: Ryder Lee <ryder.lee@mediatek.com>, chuanjia.liu@mediatek.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, Thomas Gleixner <tglx@linutronix.de>, Frank Wunderlich <linux@fw-web.de> Subject: Aw: Re: [PATCH] pci: mediatek: fix warning in msi.h Date: Sun, 1 Nov 2020 16:58:26 +0100 [thread overview] Message-ID: <trinity-65ad7212-0f00-45e4-b6ba-2ebf0d6ce496-1604246306570@3c-app-gmx-bap08> (raw) In-Reply-To: <87lfflti8q.wl-maz@kernel.org> > Gesendet: Sonntag, 01. November 2020 um 12:43 Uhr > Von: "Marc Zyngier" <maz@kernel.org> > On Sun, 01 Nov 2020 09:25:04 +0000, > Frank Wunderlich <frank-w@public-files.de> wrote: > > It looks like for mt7623 there is no msi domain setup (done via > > mtk_pcie_setup_irq callback + mtk_pcie_init_irq_domain) in mtk pcie > > driver. > > Does this mean that this SoC never handled MSIs the first place? Which > would explain the warning, as there is no MSI domain registered for > the device, and we end-up falling back to arch_setup_msi_irqs(). i tried 5.10-rc1 (without my patch of course) on bananapi-r64 to check if driver on mt7622 works better (this does setup a msi-domain in pcie-driver)....and i got no warning. so mt7623 needs to create an msi-domain or handle it in the correct way e.g. by returning -ENOSPC like in your code. > If this system truly is unable to handle MSIs, one potential > workaround would be to register a PCI-MSI domain that would always > fail its allocation with -ENOSPC. It is really ugly, but would keep > the horror localised. See the patchlet below, which I can't test. > > If this situation is more common than we expect, we may need something > in core code instead. thanks for your code-example, here we need a response from MTK (CC'd Chuanjia Liu) regards Frank _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-11-01 15:59 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-31 14:03 [PATCH] pci: mediatek: fix warning in msi.h Frank Wunderlich 2020-10-31 14:03 ` Frank Wunderlich 2020-10-31 21:49 ` Thomas Gleixner 2020-10-31 21:49 ` Thomas Gleixner 2020-11-01 9:25 ` Frank Wunderlich 2020-11-01 9:25 ` Frank Wunderlich 2020-11-01 11:17 ` Thomas Gleixner 2020-11-01 11:17 ` Thomas Gleixner 2020-11-01 11:43 ` Marc Zyngier 2020-11-01 11:43 ` Marc Zyngier 2020-11-01 15:58 ` Frank Wunderlich [this message] 2020-11-01 15:58 ` Aw: " Frank Wunderlich 2020-11-01 17:54 ` Ryder Lee 2020-11-01 17:54 ` Ryder Lee 2020-11-01 18:27 ` Aw: " Frank Wunderlich 2020-11-01 18:27 ` Frank Wunderlich 2020-11-01 21:47 ` Marc Zyngier 2020-11-01 21:47 ` Marc Zyngier 2020-11-01 22:27 ` Thomas Gleixner 2020-11-01 22:27 ` Thomas Gleixner 2020-11-02 11:30 ` Marc Zyngier 2020-11-02 11:30 ` Marc Zyngier 2020-11-02 11:56 ` Aw: " Frank Wunderlich 2020-11-02 11:56 ` Frank Wunderlich 2020-11-02 13:58 ` Marc Zyngier 2020-11-02 13:58 ` Marc Zyngier 2020-11-02 14:27 ` Aw: " Frank Wunderlich 2020-11-02 14:27 ` Frank Wunderlich 2020-11-02 16:16 ` Aw: " Thomas Gleixner 2020-11-02 16:16 ` Thomas Gleixner 2020-11-02 22:18 ` Thomas Gleixner 2020-11-02 22:18 ` Thomas Gleixner 2020-11-03 9:54 ` Marc Zyngier 2020-11-03 9:54 ` Marc Zyngier 2020-11-03 10:16 ` Thomas Gleixner 2020-11-03 10:16 ` Thomas Gleixner 2020-11-03 10:29 ` Marc Zyngier 2020-11-03 10:29 ` Marc Zyngier 2020-11-04 16:49 ` Aw: " Frank Wunderlich 2020-11-04 16:49 ` Frank Wunderlich 2020-11-04 23:14 ` Thomas Gleixner 2020-11-04 23:14 ` Thomas Gleixner 2020-11-05 9:20 ` Marc Zyngier 2020-11-05 9:20 ` Marc Zyngier 2020-11-05 13:59 ` Aw: " Frank Wunderlich 2020-11-05 13:59 ` Frank Wunderlich 2020-11-05 23:00 ` Aw: " Thomas Gleixner 2020-11-05 23:00 ` Thomas Gleixner 2020-11-06 9:43 ` Marc Zyngier 2020-11-06 9:43 ` Marc Zyngier 2020-11-21 16:12 ` Aw: " Frank Wunderlich 2020-11-21 16:12 ` Frank Wunderlich 2021-01-03 13:08 ` Frank Wunderlich 2021-01-03 13:08 ` Frank Wunderlich 2021-02-02 16:21 ` Frank Wunderlich 2021-02-02 16:21 ` Frank Wunderlich 2020-11-03 10:31 ` Aw: " Thomas Gleixner 2020-11-03 10:31 ` Thomas Gleixner 2020-11-03 11:41 ` Marc Zyngier 2020-11-03 11:41 ` Marc Zyngier 2020-11-03 14:23 ` Thomas Gleixner 2020-11-03 14:23 ` Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=trinity-65ad7212-0f00-45e4-b6ba-2ebf0d6ce496-1604246306570@3c-app-gmx-bap08 \ --to=frank-w@public-files.de \ --cc=bhelgaas@google.com \ --cc=chuanjia.liu@mediatek.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux@fw-web.de \ --cc=matthias.bgg@gmail.com \ --cc=maz@kernel.org \ --cc=ryder.lee@mediatek.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.