From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
"Tobin C . Harding" <me@tobin.cc>,
kernel-hardening@lists.openwall.com,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: Stop printing the virtual memory layout
Date: Thu, 05 Mar 2020 20:56:15 +0000 [thread overview]
Message-ID: <91C97773-5873-4336-9926-A013BB96B75C@physik.fu-berlin.de> (raw)
In-Reply-To: <20200305205158.GF6506@cisco>
> On Mar 5, 2020, at 9:52 PM, Tycho Andersen <tycho@tycho.ws> wrote:
>
> On Thu, Mar 05, 2020 at 10:56:29AM -0500, Arvind Sankar wrote:
>>> On Thu, Mar 05, 2020 at 04:49:22PM +0100, John Paul Adrian Glaubitz wrote:
>>> On 3/5/20 4:46 PM, Arvind Sankar wrote:
>>>> Not really too late. I can do s/pr_info/pr_devel and resubmit.
>>>>
>>>> parisc for eg actually hides this in #if 0 rather than deleting the
>>>> code.
>>>>
>>>> Kees, you fine with that?
>>>
>>> But wasn't it removed for all the other architectures already? Or are these
>>> changes not in Linus' tree yet?
>>>
>>> Adrian
>>
>> The ones mentioned in the commit message, yes, those are long gone. But
>> I don't see any reason why the remaining ones (there are 6 left that I
>> submitted patches just now for) couldn't switch to pr_devel instead.
>
> If you do happen to re-send with pr_debug() instead, feel free to add
> my ack to that series as well.
Since it already got removed for most other architectures, I don’t think it makes much sense to keep it for consistency.
I just didn’t understand why it was made configurable for debugging purposes in the first place.
Also, many distributions disable access to the kernel buffer for unprivileged users anyway.
Adrian
WARNING: multiple messages have this Message-ID (diff)
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
"Tobin C . Harding" <me@tobin.cc>,
kernel-hardening@lists.openwall.com,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: Stop printing the virtual memory layout
Date: Thu, 5 Mar 2020 21:56:15 +0100 [thread overview]
Message-ID: <91C97773-5873-4336-9926-A013BB96B75C@physik.fu-berlin.de> (raw)
In-Reply-To: <20200305205158.GF6506@cisco>
> On Mar 5, 2020, at 9:52 PM, Tycho Andersen <tycho@tycho.ws> wrote:
>
> On Thu, Mar 05, 2020 at 10:56:29AM -0500, Arvind Sankar wrote:
>>> On Thu, Mar 05, 2020 at 04:49:22PM +0100, John Paul Adrian Glaubitz wrote:
>>> On 3/5/20 4:46 PM, Arvind Sankar wrote:
>>>> Not really too late. I can do s/pr_info/pr_devel and resubmit.
>>>>
>>>> parisc for eg actually hides this in #if 0 rather than deleting the
>>>> code.
>>>>
>>>> Kees, you fine with that?
>>>
>>> But wasn't it removed for all the other architectures already? Or are these
>>> changes not in Linus' tree yet?
>>>
>>> Adrian
>>
>> The ones mentioned in the commit message, yes, those are long gone. But
>> I don't see any reason why the remaining ones (there are 6 left that I
>> submitted patches just now for) couldn't switch to pr_devel instead.
>
> If you do happen to re-send with pr_debug() instead, feel free to add
> my ack to that series as well.
Since it already got removed for most other architectures, I don’t think it makes much sense to keep it for consistency.
I just didn’t understand why it was made configurable for debugging purposes in the first place.
Also, many distributions disable access to the kernel buffer for unprivileged users anyway.
Adrian
next prev parent reply other threads:[~2020-03-05 20:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:50 [PATCH] x86/mm/init_32: Don't print out kernel memory layout if KASLR Arvind Sankar
2020-02-29 23:51 ` Kees Cook
2020-03-01 0:11 ` Arvind Sankar
2020-03-02 18:38 ` Kees Cook
2020-03-05 15:05 ` [PATCH] microblaze: Stop printing the virtual memory layout Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-09 10:09 ` Michal Simek
2020-03-05 15:06 ` [PATCH] nds32/mm: " Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-05 15:08 ` [PATCH] powerpc/32: " Arvind Sankar
2020-03-05 15:08 ` Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-05 20:50 ` Tycho Andersen
2022-03-09 19:35 ` Christophe Leroy
2020-03-05 15:10 ` [PATCH] sh: " Arvind Sankar
2020-03-05 15:10 ` Arvind Sankar
2020-03-05 15:18 ` John Paul Adrian Glaubitz
2020-03-05 15:18 ` John Paul Adrian Glaubitz
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:41 ` John Paul Adrian Glaubitz
2020-03-05 15:41 ` John Paul Adrian Glaubitz
2020-03-05 15:46 ` Arvind Sankar
2020-03-05 15:46 ` Arvind Sankar
2020-03-05 15:49 ` John Paul Adrian Glaubitz
2020-03-05 15:49 ` John Paul Adrian Glaubitz
2020-03-05 15:56 ` Arvind Sankar
2020-03-05 15:56 ` Arvind Sankar
2020-03-05 20:51 ` Tycho Andersen
2020-03-05 20:51 ` Tycho Andersen
2020-03-05 20:56 ` John Paul Adrian Glaubitz [this message]
2020-03-05 20:56 ` John Paul Adrian Glaubitz
2020-03-05 21:17 ` Kees Cook
2020-03-05 21:17 ` Kees Cook
2020-03-05 17:34 ` Kees Cook
2020-03-05 17:34 ` Kees Cook
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-08 12:17 ` Kaiwan N Billimoria
2020-03-08 12:29 ` Kaiwan N Billimoria
2020-03-08 12:17 ` Kaiwan N Billimoria
2020-03-05 15:11 ` [PATCH] xtensa/mm: " Arvind Sankar
2020-03-05 20:51 ` Tycho Andersen
2020-03-06 7:54 ` Max Filippov
2020-03-06 7:54 ` Max Filippov
2020-03-01 0:22 ` [PATCH v2] x86/mm/init_32: " Arvind Sankar
2020-03-02 15:29 ` Tycho Andersen
2020-03-02 18:39 ` Kees Cook
2020-03-05 15:01 ` [PATCH v3] " Arvind Sankar
2020-03-05 17:28 ` Kees Cook
2020-03-05 20:49 ` Tycho Andersen
2020-03-05 23:00 ` [tip: x86/mm] x86/mm/init/32: " tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91C97773-5873-4336-9926-A013BB96B75C@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=me@tobin.cc \
--cc=nivedita@alum.mit.edu \
--cc=tycho@tycho.ws \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.