From: Kaiwan N Billimoria <kaiwan@kaiwantech.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Kees Cook <keescook@chromium.org>,
"Tobin C . Harding" <me@tobin.cc>,
Tycho Andersen <tycho@tycho.ws>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Stop printing the virtual memory layout
Date: Sun, 08 Mar 2020 12:29:50 +0000 [thread overview]
Message-ID: <CAPDLWs-b0NjDx4A=wdd6aJu84Wrc2wk6QZAf6EYGbqWyy-4ZFw@mail.gmail.com> (raw)
In-Reply-To: <f672417e-1323-4ef2-58a1-1158c482d569@physik.fu-berlin.de>
On Thu, Mar 5, 2020 at 8:48 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> On 3/5/20 4:10 PM, Arvind Sankar wrote:
> > For security, don't display the kernel's virtual memory layout.
> >
> > Kees Cook points out:
> > "These have been entirely removed on other architectures, so let's
> > just do the same for ia32 and remove it unconditionally."
> >
> > 071929dbdd86 ("arm64: Stop printing the virtual memory layout")
> > 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")
> > 31833332f798 ("m68k/mm: Stop printing the virtual memory layout")
> > fd8d0ca25631 ("parisc: Hide virtual kernel memory layout")
> > adb1fe9ae2ee ("mm/page_alloc: Remove kernel address exposure in free_reserved_area()")
> Aww, why wasn't this made configurable? I found these memory map printouts
> very useful for development.
Same here! IMO, the kernel segment layout is useful for devs/debug purposes.
Perhaps:
a) all these printk's could be gathered into one function and invoked
only when DEBUG (or equivalent) is defined?
b) else, the s/pr_info/pr_devel approach with %pK should be good?
-Kaiwan.
WARNING: multiple messages have this Message-ID (diff)
From: Kaiwan N Billimoria <kaiwan@kaiwantech.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Kees Cook <keescook@chromium.org>,
"Tobin C . Harding" <me@tobin.cc>,
Tycho Andersen <tycho@tycho.ws>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Stop printing the virtual memory layout
Date: Sun, 8 Mar 2020 17:47:50 +0530 [thread overview]
Message-ID: <CAPDLWs-b0NjDx4A=wdd6aJu84Wrc2wk6QZAf6EYGbqWyy-4ZFw@mail.gmail.com> (raw)
In-Reply-To: <f672417e-1323-4ef2-58a1-1158c482d569@physik.fu-berlin.de>
On Thu, Mar 5, 2020 at 8:48 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> On 3/5/20 4:10 PM, Arvind Sankar wrote:
> > For security, don't display the kernel's virtual memory layout.
> >
> > Kees Cook points out:
> > "These have been entirely removed on other architectures, so let's
> > just do the same for ia32 and remove it unconditionally."
> >
> > 071929dbdd86 ("arm64: Stop printing the virtual memory layout")
> > 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")
> > 31833332f798 ("m68k/mm: Stop printing the virtual memory layout")
> > fd8d0ca25631 ("parisc: Hide virtual kernel memory layout")
> > adb1fe9ae2ee ("mm/page_alloc: Remove kernel address exposure in free_reserved_area()")
> Aww, why wasn't this made configurable? I found these memory map printouts
> very useful for development.
Same here! IMO, the kernel segment layout is useful for devs/debug purposes.
Perhaps:
a) all these printk's could be gathered into one function and invoked
only when DEBUG (or equivalent) is defined?
b) else, the s/pr_info/pr_devel approach with %pK should be good?
-Kaiwan.
WARNING: multiple messages have this Message-ID (diff)
From: Kaiwan N Billimoria <kaiwan@kaiwantech.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Kees Cook <keescook@chromium.org>,
"Tobin C . Harding" <me@tobin.cc>,
Tycho Andersen <tycho@tycho.ws>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Stop printing the virtual memory layout
Date: Sun, 8 Mar 2020 17:47:50 +0530 [thread overview]
Message-ID: <CAPDLWs-b0NjDx4A=wdd6aJu84Wrc2wk6QZAf6EYGbqWyy-4ZFw@mail.gmail.com> (raw)
In-Reply-To: <f672417e-1323-4ef2-58a1-1158c482d569@physik.fu-berlin.de>
On Thu, Mar 5, 2020 at 8:48 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> On 3/5/20 4:10 PM, Arvind Sankar wrote:
> > For security, don't display the kernel's virtual memory layout.
> >
> > Kees Cook points out:
> > "These have been entirely removed on other architectures, so let's
> > just do the same for ia32 and remove it unconditionally."
> >
> > 071929dbdd86 ("arm64: Stop printing the virtual memory layout")
> > 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout")
> > 31833332f798 ("m68k/mm: Stop printing the virtual memory layout")
> > fd8d0ca25631 ("parisc: Hide virtual kernel memory layout")
> > adb1fe9ae2ee ("mm/page_alloc: Remove kernel address exposure in free_reserved_area()")
> Aww, why wasn't this made configurable? I found these memory map printouts
> very useful for development.
Same here! IMO, the kernel segment layout is useful for devs/debug purposes.
Perhaps:
a) all these printk's could be gathered into one function and invoked
only when DEBUG (or equivalent) is defined?
b) else, the s/pr_info/pr_devel approach with %pK should be good?
-Kaiwan.
next prev parent reply other threads:[~2020-03-08 12:29 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 21:50 [PATCH] x86/mm/init_32: Don't print out kernel memory layout if KASLR Arvind Sankar
2020-02-29 23:51 ` Kees Cook
2020-03-01 0:11 ` Arvind Sankar
2020-03-02 18:38 ` Kees Cook
2020-03-05 15:05 ` [PATCH] microblaze: Stop printing the virtual memory layout Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-09 10:09 ` Michal Simek
2020-03-05 15:06 ` [PATCH] nds32/mm: " Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-05 15:08 ` [PATCH] powerpc/32: " Arvind Sankar
2020-03-05 15:08 ` Arvind Sankar
2020-03-05 20:50 ` Tycho Andersen
2020-03-05 20:50 ` Tycho Andersen
2022-03-09 19:35 ` Christophe Leroy
2020-03-05 15:10 ` [PATCH] sh: " Arvind Sankar
2020-03-05 15:10 ` Arvind Sankar
2020-03-05 15:18 ` John Paul Adrian Glaubitz
2020-03-05 15:18 ` John Paul Adrian Glaubitz
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:38 ` Joe Perches
2020-03-05 15:41 ` John Paul Adrian Glaubitz
2020-03-05 15:41 ` John Paul Adrian Glaubitz
2020-03-05 15:46 ` Arvind Sankar
2020-03-05 15:46 ` Arvind Sankar
2020-03-05 15:49 ` John Paul Adrian Glaubitz
2020-03-05 15:49 ` John Paul Adrian Glaubitz
2020-03-05 15:56 ` Arvind Sankar
2020-03-05 15:56 ` Arvind Sankar
2020-03-05 20:51 ` Tycho Andersen
2020-03-05 20:51 ` Tycho Andersen
2020-03-05 20:56 ` John Paul Adrian Glaubitz
2020-03-05 20:56 ` John Paul Adrian Glaubitz
2020-03-05 21:17 ` Kees Cook
2020-03-05 21:17 ` Kees Cook
2020-03-05 17:34 ` Kees Cook
2020-03-05 17:34 ` Kees Cook
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-06 8:04 ` Geert Uytterhoeven
2020-03-08 12:17 ` Kaiwan N Billimoria [this message]
2020-03-08 12:29 ` Kaiwan N Billimoria
2020-03-08 12:17 ` Kaiwan N Billimoria
2020-03-05 15:11 ` [PATCH] xtensa/mm: " Arvind Sankar
2020-03-05 20:51 ` Tycho Andersen
2020-03-06 7:54 ` Max Filippov
2020-03-06 7:54 ` Max Filippov
2020-03-01 0:22 ` [PATCH v2] x86/mm/init_32: " Arvind Sankar
2020-03-02 15:29 ` Tycho Andersen
2020-03-02 18:39 ` Kees Cook
2020-03-05 15:01 ` [PATCH v3] " Arvind Sankar
2020-03-05 17:28 ` Kees Cook
2020-03-05 20:49 ` Tycho Andersen
2020-03-05 23:00 ` [tip: x86/mm] x86/mm/init/32: " tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDLWs-b0NjDx4A=wdd6aJu84Wrc2wk6QZAf6EYGbqWyy-4ZFw@mail.gmail.com' \
--to=kaiwan@kaiwantech.com \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=me@tobin.cc \
--cc=nivedita@alum.mit.edu \
--cc=tycho@tycho.ws \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.