From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Adam Ford <aford173@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE
Date: Tue, 15 May 2018 19:01:52 +0530 [thread overview]
Message-ID: <9203489d-0a5a-103a-67ea-d3e89bb7ebc4@ti.com> (raw)
In-Reply-To: <20180509172606.29387-3-david@lechnology.com>
On Wednesday 09 May 2018 10:55 PM, David Lechner wrote:
> +void of_da850_pll0_init(struct device_node *node)
> {
> - return of_davinci_pll_init(dev, dev->of_node, &da850_pll0_info,
> - &da850_pll0_obsclk_info,
> - da850_pll0_sysclk_info, 7, base, cfgchip);
> + void __iomem *base;
> + struct regmap *cfgchip;
> +
> + base = of_iomap(node, 0);
> + if (!base) {
> + pr_err("%s: ioremap failed\n", __func__);
> + return;
> + }
> +
> + cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
It will be nice to handle the error case here.
> +
> + of_davinci_pll_init(NULL, node, &da850_pll0_info,
> + &da850_pll0_obsclk_info,
> + da850_pll0_sysclk_info, 7, base, cfgchip);
Apart from that, it looks good to me.
Reviewed-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Adam Ford <aford173@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE
Date: Tue, 15 May 2018 19:01:52 +0530 [thread overview]
Message-ID: <9203489d-0a5a-103a-67ea-d3e89bb7ebc4@ti.com> (raw)
In-Reply-To: <20180509172606.29387-3-david@lechnology.com>
On Wednesday 09 May 2018 10:55 PM, David Lechner wrote:
> +void of_da850_pll0_init(struct device_node *node)
> {
> - return of_davinci_pll_init(dev, dev->of_node, &da850_pll0_info,
> - &da850_pll0_obsclk_info,
> - da850_pll0_sysclk_info, 7, base, cfgchip);
> + void __iomem *base;
> + struct regmap *cfgchip;
> +
> + base = of_iomap(node, 0);
> + if (!base) {
> + pr_err("%s: ioremap failed\n", __func__);
> + return;
> + }
> +
> + cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
It will be nice to handle the error case here.
> +
> + of_davinci_pll_init(NULL, node, &da850_pll0_info,
> + &da850_pll0_obsclk_info,
> + da850_pll0_sysclk_info, 7, base, cfgchip);
Apart from that, it looks good to me.
Reviewed-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE
Date: Tue, 15 May 2018 19:01:52 +0530 [thread overview]
Message-ID: <9203489d-0a5a-103a-67ea-d3e89bb7ebc4@ti.com> (raw)
In-Reply-To: <20180509172606.29387-3-david@lechnology.com>
On Wednesday 09 May 2018 10:55 PM, David Lechner wrote:
> +void of_da850_pll0_init(struct device_node *node)
> {
> - return of_davinci_pll_init(dev, dev->of_node, &da850_pll0_info,
> - &da850_pll0_obsclk_info,
> - da850_pll0_sysclk_info, 7, base, cfgchip);
> + void __iomem *base;
> + struct regmap *cfgchip;
> +
> + base = of_iomap(node, 0);
> + if (!base) {
> + pr_err("%s: ioremap failed\n", __func__);
> + return;
> + }
> +
> + cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
It will be nice to handle the error case here.
> +
> + of_davinci_pll_init(NULL, node, &da850_pll0_info,
> + &da850_pll0_obsclk_info,
> + da850_pll0_sysclk_info, 7, base, cfgchip);
Apart from that, it looks good to me.
Reviewed-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2018-05-15 13:33 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 17:25 [PATCH v10 00/27] ARM: davinci: convert to common clock framework David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 01/27] clk: davinci: pll: allow dev == NULL David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-15 13:31 ` Sekhar Nori [this message]
2018-05-15 13:31 ` Sekhar Nori
2018-05-15 13:31 ` Sekhar Nori
2018-05-15 15:42 ` David Lechner
2018-05-15 15:42 ` David Lechner
2018-05-16 5:51 ` Sekhar Nori
2018-05-16 5:51 ` Sekhar Nori
2018-05-16 5:51 ` Sekhar Nori
2018-05-09 17:25 ` [PATCH v10 03/27] clk: davinci: psc: allow for dev == NULL David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-15 13:42 ` Sekhar Nori
2018-05-15 13:42 ` Sekhar Nori
2018-05-15 13:42 ` Sekhar Nori
2018-05-09 17:25 ` [PATCH v10 04/27] ARM: davinci: pass clock as parameter to davinci_timer_init() David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 05/27] ARM: davinci: da830: add new clock init using common clock framework David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 06/27] ARM: davinci: da850: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 07/27] ARM: davinci: dm355: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 08/27] ARM: davinci: dm365: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 09/27] ARM: davinci: dm644x: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 10/27] ARM: davinci: dm646x: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 11/27] ARM: davinci: da8xx: add new USB PHY " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 12/27] ARM: davinci: da8xx: add new sata_refclk " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 13/27] ARM: davinci: remove CONFIG_DAVINCI_RESET_CLOCKS David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 14/27] ARM: davinci_all_defconfig: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 15/27] ARM: davinci: switch to common clock framework David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 16/27] ARM: davinci: da830: Remove legacy clock init David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 17/27] ARM: davinci: da850: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 18/27] ARM: davinci: dm355: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 19/27] ARM: davinci: dm365: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:25 ` [PATCH v10 20/27] ARM: davinci: dm644x: " David Lechner
2018-05-09 17:25 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 21/27] ARM: davinci: dm646x: " David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 22/27] ARM: davinci: da8xx: Remove legacy USB and SATA " David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 23/27] ARM: davinci: remove legacy clocks David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 24/27] dt-bindings: timer: new bindings for TI DaVinci timer David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-18 14:24 ` Rob Herring
2018-05-18 14:24 ` Rob Herring
2018-05-09 17:26 ` [PATCH v10 25/27] ARM: davinci: add device tree support to timer David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-17 14:35 ` Sekhar Nori
2018-05-17 14:35 ` Sekhar Nori
2018-05-17 14:35 ` Sekhar Nori
2018-05-17 15:09 ` David Lechner
2018-05-17 15:09 ` David Lechner
2018-05-18 6:05 ` Sekhar Nori
2018-05-18 6:05 ` Sekhar Nori
2018-05-18 6:05 ` Sekhar Nori
2018-05-18 15:35 ` David Lechner
2018-05-18 15:35 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 26/27] ARM: davinci: da8xx-dt: switch to device tree clocks David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-09 17:26 ` [PATCH v10 27/27] ARM: dts: da850: Add clocks David Lechner
2018-05-09 17:26 ` David Lechner
2018-05-11 15:26 ` [PATCH v10 00/27] ARM: davinci: convert to common clock framework Sekhar Nori
2018-05-11 15:26 ` Sekhar Nori
2018-05-11 15:26 ` Sekhar Nori
2018-05-12 21:11 ` David Lechner
2018-05-12 21:11 ` David Lechner
2018-05-14 0:40 ` Adam Ford
2018-05-14 0:40 ` Adam Ford
2018-05-14 1:50 ` David Lechner
2018-05-14 1:50 ` David Lechner
2018-05-15 9:25 ` Bartosz Golaszewski
2018-05-15 9:25 ` Bartosz Golaszewski
2018-05-15 22:44 ` Adam Ford
2018-05-15 22:44 ` Adam Ford
2018-05-16 0:31 ` David Lechner
2018-05-16 0:31 ` David Lechner
2018-05-16 7:47 ` Bartosz Golaszewski
2018-05-16 7:47 ` Bartosz Golaszewski
2018-05-16 10:43 ` Sekhar Nori
2018-05-16 10:43 ` Sekhar Nori
2018-05-17 0:46 ` Adam Ford
2018-05-17 0:46 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9203489d-0a5a-103a-67ea-d3e89bb7ebc4@ti.com \
--to=nsekhar@ti.com \
--cc=aford173@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.