From: Andrew Lunn <andrew@lunn.ch> To: Marco Felsch <m.felsch@pengutronix.de> Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Date: Tue, 18 Jul 2023 15:10:15 +0200 [thread overview] Message-ID: <9214ae14-b501-4d94-9d52-fd7dab2a86af@lunn.ch> (raw) In-Reply-To: <20230718083841.p67wflhjlwnu56j4@pengutronix.de> On Tue, Jul 18, 2023 at 10:38:41AM +0200, Marco Felsch wrote: > On 23-07-18, Andrew Lunn wrote: > > > +static int stmmac_phy_power(struct platform_device *pdev, > > > + struct plat_stmmacenet_data *plat, > > > + bool enable) > > > +{ > > > + struct regulator *regulator = plat->phy_regulator; > > > + int ret = 0; > > > + > > > + if (regulator) { > > > + if (enable) > > > + ret = regulator_enable(regulator); > > > + else > > > + regulator_disable(regulator); > > > + } > > > + > > > + if (ret) > > > + dev_err(&pdev->dev, "Fail to enable regulator\n"); > > > > 'enable' is only correct 50% of the time. > > You mean to move it under the enable path. Or don't use the word 'enable'. 'modify' ? > Good point didn't consider WOL. Is there a way to check if WOL is > enabled? Yes, plenty of MAC drivers do this. Look around. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Marco Felsch <m.felsch@pengutronix.de> Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Date: Tue, 18 Jul 2023 15:10:15 +0200 [thread overview] Message-ID: <9214ae14-b501-4d94-9d52-fd7dab2a86af@lunn.ch> (raw) In-Reply-To: <20230718083841.p67wflhjlwnu56j4@pengutronix.de> On Tue, Jul 18, 2023 at 10:38:41AM +0200, Marco Felsch wrote: > On 23-07-18, Andrew Lunn wrote: > > > +static int stmmac_phy_power(struct platform_device *pdev, > > > + struct plat_stmmacenet_data *plat, > > > + bool enable) > > > +{ > > > + struct regulator *regulator = plat->phy_regulator; > > > + int ret = 0; > > > + > > > + if (regulator) { > > > + if (enable) > > > + ret = regulator_enable(regulator); > > > + else > > > + regulator_disable(regulator); > > > + } > > > + > > > + if (ret) > > > + dev_err(&pdev->dev, "Fail to enable regulator\n"); > > > > 'enable' is only correct 50% of the time. > > You mean to move it under the enable path. Or don't use the word 'enable'. 'modify' ? > Good point didn't consider WOL. Is there a way to check if WOL is > enabled? Yes, plenty of MAC drivers do this. Look around. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-18 13:11 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-17 16:43 [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch 2023-07-17 16:43 ` Marco Felsch 2023-07-17 16:43 ` [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Marco Felsch 2023-07-17 16:43 ` Marco Felsch 2023-07-17 22:27 ` Andrew Lunn 2023-07-17 22:27 ` Andrew Lunn 2023-07-18 8:38 ` Marco Felsch 2023-07-18 8:38 ` Marco Felsch 2023-07-18 13:10 ` Andrew Lunn [this message] 2023-07-18 13:10 ` Andrew Lunn 2023-07-18 13:15 ` Marco Felsch 2023-07-18 13:15 ` Marco Felsch 2023-07-17 22:30 ` Andrew Lunn 2023-07-17 22:30 ` Andrew Lunn 2023-07-18 8:35 ` Marco Felsch 2023-07-18 8:35 ` Marco Felsch 2023-07-18 13:08 ` Andrew Lunn 2023-07-18 13:08 ` Andrew Lunn 2023-07-18 13:15 ` Marco Felsch 2023-07-18 13:15 ` Marco Felsch 2023-07-17 16:47 ` [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Krzysztof Kozlowski 2023-07-17 16:47 ` Krzysztof Kozlowski 2023-07-17 16:57 ` Marco Felsch 2023-07-17 16:57 ` Marco Felsch 2023-07-18 7:59 ` Krzysztof Kozlowski 2023-07-18 7:59 ` Krzysztof Kozlowski 2023-07-18 8:00 ` Krzysztof Kozlowski 2023-07-18 8:00 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9214ae14-b501-4d94-9d52-fd7dab2a86af@lunn.ch \ --to=andrew@lunn.ch \ --cc=alexandre.torgue@foss.st.com \ --cc=conor+dt@kernel.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=joabreu@synopsys.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=m.felsch@pengutronix.de \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=peppe.cavallaro@st.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.