From: Andrew Lunn <andrew@lunn.ch>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply
Date: Tue, 18 Jul 2023 00:30:19 +0200 [thread overview]
Message-ID: <accc8d89-7565-460e-a874-a491b755bbb8@lunn.ch> (raw)
In-Reply-To: <20230717164307.2868264-2-m.felsch@pengutronix.de>
On Mon, Jul 17, 2023 at 06:43:07PM +0200, Marco Felsch wrote:
> Add generic phy-supply handling support to control the phy regulator.
> Use the common stmmac_platform code path so all drivers using
> stmmac_probe_config_dt() and stmmac_pltfr_pm_ops can use it.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> .../ethernet/stmicro/stmmac/stmmac_platform.c | 51 +++++++++++++++++++
> include/linux/stmmac.h | 1 +
> 2 files changed, 52 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index eb0b2898daa3d..6193d42b53fb7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -10,6 +10,7 @@
>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/module.h>
> #include <linux/io.h>
> #include <linux/of.h>
> @@ -423,6 +424,15 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
> if (plat->interface < 0)
> plat->interface = plat->phy_interface;
>
> + /* Optional regulator for PHY */
> + plat->phy_regulator = devm_regulator_get_optional(&pdev->dev, "phy");
> + if (IS_ERR(plat->phy_regulator)) {
> + if (PTR_ERR(plat->phy_regulator) == -EPROBE_DEFER)
> + return ERR_CAST(plat->phy_regulator);
> + dev_info(&pdev->dev, "No regulator found\n");
> + plat->phy_regulator = NULL;
> + }
> +
So this gets the regulator. When do you actually turn it on?
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply
Date: Tue, 18 Jul 2023 00:30:19 +0200 [thread overview]
Message-ID: <accc8d89-7565-460e-a874-a491b755bbb8@lunn.ch> (raw)
In-Reply-To: <20230717164307.2868264-2-m.felsch@pengutronix.de>
On Mon, Jul 17, 2023 at 06:43:07PM +0200, Marco Felsch wrote:
> Add generic phy-supply handling support to control the phy regulator.
> Use the common stmmac_platform code path so all drivers using
> stmmac_probe_config_dt() and stmmac_pltfr_pm_ops can use it.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> .../ethernet/stmicro/stmmac/stmmac_platform.c | 51 +++++++++++++++++++
> include/linux/stmmac.h | 1 +
> 2 files changed, 52 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index eb0b2898daa3d..6193d42b53fb7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -10,6 +10,7 @@
>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/module.h>
> #include <linux/io.h>
> #include <linux/of.h>
> @@ -423,6 +424,15 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
> if (plat->interface < 0)
> plat->interface = plat->phy_interface;
>
> + /* Optional regulator for PHY */
> + plat->phy_regulator = devm_regulator_get_optional(&pdev->dev, "phy");
> + if (IS_ERR(plat->phy_regulator)) {
> + if (PTR_ERR(plat->phy_regulator) == -EPROBE_DEFER)
> + return ERR_CAST(plat->phy_regulator);
> + dev_info(&pdev->dev, "No regulator found\n");
> + plat->phy_regulator = NULL;
> + }
> +
So this gets the regulator. When do you actually turn it on?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-17 22:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:43 [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch
2023-07-17 16:43 ` Marco Felsch
2023-07-17 16:43 ` [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Marco Felsch
2023-07-17 16:43 ` Marco Felsch
2023-07-17 22:27 ` Andrew Lunn
2023-07-17 22:27 ` Andrew Lunn
2023-07-18 8:38 ` Marco Felsch
2023-07-18 8:38 ` Marco Felsch
2023-07-18 13:10 ` Andrew Lunn
2023-07-18 13:10 ` Andrew Lunn
2023-07-18 13:15 ` Marco Felsch
2023-07-18 13:15 ` Marco Felsch
2023-07-17 22:30 ` Andrew Lunn [this message]
2023-07-17 22:30 ` Andrew Lunn
2023-07-18 8:35 ` Marco Felsch
2023-07-18 8:35 ` Marco Felsch
2023-07-18 13:08 ` Andrew Lunn
2023-07-18 13:08 ` Andrew Lunn
2023-07-18 13:15 ` Marco Felsch
2023-07-18 13:15 ` Marco Felsch
2023-07-17 16:47 ` [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Krzysztof Kozlowski
2023-07-17 16:47 ` Krzysztof Kozlowski
2023-07-17 16:57 ` Marco Felsch
2023-07-17 16:57 ` Marco Felsch
2023-07-18 7:59 ` Krzysztof Kozlowski
2023-07-18 7:59 ` Krzysztof Kozlowski
2023-07-18 8:00 ` Krzysztof Kozlowski
2023-07-18 8:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accc8d89-7565-460e-a874-a491b755bbb8@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=m.felsch@pengutronix.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.