From: Sergey Shtylyov <s.shtylyov@omp.ru> To: Stefan Wahren <stefan.wahren@i2se.com>, Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org> Cc: Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>, <bcm-kernel-feedback-list@broadcom.com>, <linux-rpi-kernel@lists.infradead.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Date: Mon, 12 Jun 2023 22:43:57 +0300 [thread overview] Message-ID: <988ec49f-5d73-c8ad-4bba-348f336688b7@omp.ru> (raw) In-Reply-To: <13fd5204-4670-264d-5553-1475af3b203e@i2se.com> On 6/9/23 12:39 AM, Stefan Wahren wrote: [...] >> The driver overrides the error codes and IRQ0 returned by platform_get_irq() >> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe >> permanently instead of the deferred probing. Switch to propagating the error >> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now >> can safely ignore it... >> >> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.") > > I know this is very theoretical, but does the statement "IRQ0 is no longer returned by platform_get_irq()" also applies to the time of the fixes commit? Unfortunately, no. IRQ0 finally ceased to be returned in 5.19; there was a fat warning in platform_get_irq() and friends before that (which is still there)... > I'm asking because the fix could be backported to Linux 4.14. I think the deferred probing can currently occur only with DT platforms (I may be wrong here). Is this your case? > Best regards > >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru> To: Stefan Wahren <stefan.wahren@i2se.com>, Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org> Cc: Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>, <bcm-kernel-feedback-list@broadcom.com>, <linux-rpi-kernel@lists.infradead.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Date: Mon, 12 Jun 2023 22:43:57 +0300 [thread overview] Message-ID: <988ec49f-5d73-c8ad-4bba-348f336688b7@omp.ru> (raw) In-Reply-To: <13fd5204-4670-264d-5553-1475af3b203e@i2se.com> On 6/9/23 12:39 AM, Stefan Wahren wrote: [...] >> The driver overrides the error codes and IRQ0 returned by platform_get_irq() >> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe >> permanently instead of the deferred probing. Switch to propagating the error >> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now >> can safely ignore it... >> >> Fixes: 660fc733bd74 ("mmc: bcm2835: Add new driver for the sdhost controller.") > > I know this is very theoretical, but does the statement "IRQ0 is no longer returned by platform_get_irq()" also applies to the time of the fixes commit? Unfortunately, no. IRQ0 finally ceased to be returned in 5.19; there was a fat warning in platform_get_irq() and friends before that (which is still there)... > I'm asking because the fix could be backported to Linux 4.14. I think the deferred probing can currently occur only with DT platforms (I may be wrong here). Is this your case? > Best regards > >> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-12 19:44 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-08 19:45 [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-08 21:39 ` Stefan Wahren 2023-06-08 21:39 ` Stefan Wahren 2023-06-12 19:43 ` Sergey Shtylyov [this message] 2023-06-12 19:43 ` Sergey Shtylyov 2023-06-13 8:56 ` Stefan Wahren 2023-06-13 8:56 ` Stefan Wahren 2023-06-13 21:08 ` Sergey Shtylyov 2023-06-13 21:08 ` Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 02/12] mmc: meson-gx: " Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-09 7:20 ` Neil Armstrong 2023-06-09 7:20 ` Neil Armstrong 2023-06-09 7:20 ` Neil Armstrong 2023-06-08 19:45 ` [PATCH v2 03/12] mmc: mtk-sd: " Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 04/12] mmc: mvsdio: " Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 05/12] mmc: omap: " Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 06/12] mmc: omap_hsmmc: " Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 07/12] mmc: owl: " Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 08/12] mmc: sdhci-acpi: " Sergey Shtylyov 2023-06-09 5:43 ` Adrian Hunter 2023-06-08 19:45 ` [PATCH v2 09/12] mmc: sdhci-spear: " Sergey Shtylyov 2023-06-09 4:40 ` Viresh Kumar 2023-06-09 5:44 ` Adrian Hunter 2023-06-08 19:45 ` [PATCH v2 10/12] mmc: sh_mmcif: " Sergey Shtylyov 2023-06-08 19:45 ` [PATCH v2 11/12] mmc: sunxi: " Sergey Shtylyov 2023-06-08 19:45 ` Sergey Shtylyov 2023-06-09 20:48 ` Jernej Škrabec 2023-06-09 20:48 ` Jernej Škrabec 2023-06-08 19:45 ` [PATCH v2 12/12] mmc: usdhi60rol0: " Sergey Shtylyov 2023-06-12 14:16 ` [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Ulf Hansson 2023-06-12 19:48 ` Sergey Shtylyov 2023-06-12 20:18 ` Ulf Hansson 2023-06-13 20:04 ` Sergey Shtylyov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=988ec49f-5d73-c8ad-4bba-348f336688b7@omp.ru \ --to=s.shtylyov@omp.ru \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=nsaenz@kernel.org \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=stefan.wahren@i2se.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.