From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/12] mmc: meson-gx: fix deferred probing
Date: Fri, 9 Jun 2023 09:20:54 +0200 [thread overview]
Message-ID: <c0d6c95a-e96c-a258-666d-f81a05a86db8@linaro.org> (raw)
In-Reply-To: <20230608194519.10665-3-s.shtylyov@omp.ru>
On 08/06/2023 21:45, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> Changes in version 2:
> - updated the fix due to the surrounding code change;
> - refreshed the patch;
> - removed stray newline in the Fixes: tag;
> - slightly reformatted the patch description.
>
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index b8514d9d5e73..75f97dce7ef3 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1192,8 +1192,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> return PTR_ERR(host->regs);
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0)
> - return -EINVAL;
> + if (host->irq < 0)
> + return host->irq;
>
> cd_irq = platform_get_irq_optional(pdev, 1);
> mmc_gpio_set_cd_irq(mmc, cd_irq);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/12] mmc: meson-gx: fix deferred probing
Date: Fri, 9 Jun 2023 09:20:54 +0200 [thread overview]
Message-ID: <c0d6c95a-e96c-a258-666d-f81a05a86db8@linaro.org> (raw)
In-Reply-To: <20230608194519.10665-3-s.shtylyov@omp.ru>
On 08/06/2023 21:45, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> Changes in version 2:
> - updated the fix due to the surrounding code change;
> - refreshed the patch;
> - removed stray newline in the Fixes: tag;
> - slightly reformatted the patch description.
>
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index b8514d9d5e73..75f97dce7ef3 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1192,8 +1192,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> return PTR_ERR(host->regs);
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0)
> - return -EINVAL;
> + if (host->irq < 0)
> + return host->irq;
>
> cd_irq = platform_get_irq_optional(pdev, 1);
> mmc_gpio_set_cd_irq(mmc, cd_irq);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/12] mmc: meson-gx: fix deferred probing
Date: Fri, 9 Jun 2023 09:20:54 +0200 [thread overview]
Message-ID: <c0d6c95a-e96c-a258-666d-f81a05a86db8@linaro.org> (raw)
In-Reply-To: <20230608194519.10665-3-s.shtylyov@omp.ru>
On 08/06/2023 21:45, Sergey Shtylyov wrote:
> The driver overrides the error codes and IRQ0 returned by platform_get_irq()
> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the error
> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now
> can safely ignore it...
>
> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> Changes in version 2:
> - updated the fix due to the surrounding code change;
> - refreshed the patch;
> - removed stray newline in the Fixes: tag;
> - slightly reformatted the patch description.
>
> drivers/mmc/host/meson-gx-mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index b8514d9d5e73..75f97dce7ef3 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1192,8 +1192,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> return PTR_ERR(host->regs);
>
> host->irq = platform_get_irq(pdev, 0);
> - if (host->irq <= 0)
> - return -EINVAL;
> + if (host->irq < 0)
> + return host->irq;
>
> cd_irq = platform_get_irq_optional(pdev, 1);
> mmc_gpio_set_cd_irq(mmc, cd_irq);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-09 7:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 19:45 [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 01/12] mmc: bcm2835: fix deferred probing Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-08 21:39 ` Stefan Wahren
2023-06-08 21:39 ` Stefan Wahren
2023-06-12 19:43 ` Sergey Shtylyov
2023-06-12 19:43 ` Sergey Shtylyov
2023-06-13 8:56 ` Stefan Wahren
2023-06-13 8:56 ` Stefan Wahren
2023-06-13 21:08 ` Sergey Shtylyov
2023-06-13 21:08 ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 02/12] mmc: meson-gx: " Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-09 7:20 ` Neil Armstrong [this message]
2023-06-09 7:20 ` Neil Armstrong
2023-06-09 7:20 ` Neil Armstrong
2023-06-08 19:45 ` [PATCH v2 03/12] mmc: mtk-sd: " Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 04/12] mmc: mvsdio: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 05/12] mmc: omap: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 06/12] mmc: omap_hsmmc: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 07/12] mmc: owl: " Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 08/12] mmc: sdhci-acpi: " Sergey Shtylyov
2023-06-09 5:43 ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 09/12] mmc: sdhci-spear: " Sergey Shtylyov
2023-06-09 4:40 ` Viresh Kumar
2023-06-09 5:44 ` Adrian Hunter
2023-06-08 19:45 ` [PATCH v2 10/12] mmc: sh_mmcif: " Sergey Shtylyov
2023-06-08 19:45 ` [PATCH v2 11/12] mmc: sunxi: " Sergey Shtylyov
2023-06-08 19:45 ` Sergey Shtylyov
2023-06-09 20:48 ` Jernej Škrabec
2023-06-09 20:48 ` Jernej Škrabec
2023-06-08 19:45 ` [PATCH v2 12/12] mmc: usdhi60rol0: " Sergey Shtylyov
2023-06-12 14:16 ` [PATCH v2 00/12] Fix deferred probing in the MMC/SD drivers Ulf Hansson
2023-06-12 19:48 ` Sergey Shtylyov
2023-06-12 20:18 ` Ulf Hansson
2023-06-13 20:04 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d6c95a-e96c-a258-666d-f81a05a86db8@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=s.shtylyov@omp.ru \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.