From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 05/11] dt-bindings: serio: add Arm PL050 DT schema
Date: Fri, 29 Apr 2022 08:29:26 +0200 [thread overview]
Message-ID: <993d74fa-be5b-6db2-6bba-2323de7757f3@linaro.org> (raw)
In-Reply-To: <20220428182708.0c1065f8@donnerap.cambridge.arm.com>
On 28/04/2022 19:27, Andre Przywara wrote:
>>> + clock-names:
>>> + items:
>>> + - const: KMIREFCLK
>>
>> lowercase letters only
>
> I am afraid this ship has sailed: the various DTs in the kernel tree use
> it in that way, and the Linux driver insists on that spelling.
The driver is coming from ancient times, so it is understandable it has
some old coding style. But it definitely not sailed away. :)
> So by
> changing this we would break both the existing DT's compliance and also
> existing Linux kernels.
> So is lowercase something that is mandated by DT schema, or can we just
> make an exception here?
This uppercase clock name affects even ARM64 devices, so it seems the
device is still being used. Therefore I propose to add new clock name,
old as deprecated and support both in the driver:
kmi->clk = clk_get(&dev->dev, "kmirefclk");
if (IS_ERR(kmi->clk)) {
kmi->clk = clk_get(&dev->dev, "KMIREFCLK");
and convert the DTS as well later on.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 05/11] dt-bindings: serio: add Arm PL050 DT schema
Date: Fri, 29 Apr 2022 08:29:26 +0200 [thread overview]
Message-ID: <993d74fa-be5b-6db2-6bba-2323de7757f3@linaro.org> (raw)
In-Reply-To: <20220428182708.0c1065f8@donnerap.cambridge.arm.com>
On 28/04/2022 19:27, Andre Przywara wrote:
>>> + clock-names:
>>> + items:
>>> + - const: KMIREFCLK
>>
>> lowercase letters only
>
> I am afraid this ship has sailed: the various DTs in the kernel tree use
> it in that way, and the Linux driver insists on that spelling.
The driver is coming from ancient times, so it is understandable it has
some old coding style. But it definitely not sailed away. :)
> So by
> changing this we would break both the existing DT's compliance and also
> existing Linux kernels.
> So is lowercase something that is mandated by DT schema, or can we just
> make an exception here?
This uppercase clock name affects even ARM64 devices, so it seems the
device is still being used. Therefore I propose to add new clock name,
old as deprecated and support both in the driver:
kmi->clk = clk_get(&dev->dev, "kmirefclk");
if (IS_ERR(kmi->clk)) {
kmi->clk = clk_get(&dev->dev, "KMIREFCLK");
and convert the DTS as well later on.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-29 6:29 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 11:25 [PATCH 00/11] dt-bindings: convert various Arm Ltd. IP to DT schema Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` [PATCH 01/11] dt-bindings: iommu: arm,smmu-v3: make PRI IRQ optional Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 12:04 ` Robin Murphy
2022-04-27 12:04 ` Robin Murphy
2022-04-27 12:04 ` Robin Murphy
2022-04-28 6:56 ` Krzysztof Kozlowski
2022-04-28 6:56 ` Krzysztof Kozlowski
2022-04-28 6:56 ` Krzysztof Kozlowski
2022-04-28 9:23 ` Robin Murphy
2022-04-28 9:23 ` Robin Murphy
2022-04-28 9:23 ` Robin Murphy
2022-04-28 9:25 ` Krzysztof Kozlowski
2022-04-28 9:25 ` Krzysztof Kozlowski
2022-04-28 9:25 ` Krzysztof Kozlowski
2022-05-06 15:19 ` Andre Przywara
2022-05-06 15:19 ` Andre Przywara
2022-05-06 15:19 ` Andre Przywara
2022-04-27 11:25 ` [PATCH 02/11] dt-bindings: arm: spe-pmu: convert to DT schema Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-28 6:57 ` Krzysztof Kozlowski
2022-04-28 6:57 ` Krzysztof Kozlowski
2022-04-27 11:25 ` [PATCH 03/11] dt-bindings: arm: sp810: " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-28 7:01 ` Krzysztof Kozlowski
2022-04-28 7:01 ` Krzysztof Kozlowski
2022-04-27 11:25 ` [PATCH 04/11] dt-bindings: sound: add Arm PL041 AACI " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:41 ` Mark Brown
2022-04-27 11:41 ` Mark Brown
2022-04-27 11:41 ` Mark Brown
2022-04-27 13:33 ` Andre Przywara
2022-04-27 13:33 ` Andre Przywara
2022-04-27 13:33 ` Andre Przywara
2022-04-27 13:39 ` Mark Brown
2022-04-27 13:39 ` Mark Brown
2022-04-27 13:39 ` Mark Brown
2022-04-27 13:32 ` Mark Brown
2022-04-27 13:32 ` Mark Brown
2022-04-27 13:32 ` Mark Brown
2022-04-27 13:52 ` Andre Przywara
2022-04-27 13:52 ` Andre Przywara
2022-04-27 13:52 ` Andre Przywara
2022-04-27 14:11 ` Mark Brown
2022-04-27 14:11 ` Mark Brown
2022-04-27 14:11 ` Mark Brown
2022-04-28 7:06 ` Krzysztof Kozlowski
2022-04-28 7:06 ` Krzysztof Kozlowski
2022-04-28 7:06 ` Krzysztof Kozlowski
2022-04-27 11:25 ` [PATCH 05/11] dt-bindings: serio: add Arm PL050 " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-28 7:07 ` Krzysztof Kozlowski
2022-04-28 7:07 ` Krzysztof Kozlowski
2022-04-28 17:27 ` Andre Przywara
2022-04-28 17:27 ` Andre Przywara
2022-04-29 6:29 ` Krzysztof Kozlowski [this message]
2022-04-29 6:29 ` Krzysztof Kozlowski
2022-04-29 6:35 ` Krzysztof Kozlowski
2022-04-29 6:35 ` Krzysztof Kozlowski
2022-04-29 10:06 ` Andre Przywara
2022-04-29 10:06 ` Andre Przywara
2022-04-27 11:25 ` [PATCH 06/11] dt-bindings: arm: convert vexpress-sysregs to " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 19:33 ` Rob Herring
2022-04-27 19:33 ` Rob Herring
2022-04-27 11:25 ` [PATCH 07/11] dt-bindings: arm: convert vexpress-config " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 19:37 ` Rob Herring
2022-04-27 19:37 ` Rob Herring
2022-04-27 11:25 ` [PATCH 08/11] dt-bindings: display: convert PL110/PL111 " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` [PATCH 09/11] dt-bindings: display: convert Arm HDLCD " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 19:39 ` Rob Herring
2022-04-27 19:39 ` Rob Herring
2022-04-27 19:39 ` Rob Herring
2022-04-27 11:25 ` [PATCH 10/11] dt-bindings: display: convert Arm Mali-DP " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 19:39 ` Rob Herring
2022-04-27 19:39 ` Rob Herring
2022-04-27 19:39 ` Rob Herring
2022-04-27 11:25 ` [PATCH 11/11] dt-bindings: display: convert Arm Komeda " Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 11:25 ` Andre Przywara
2022-04-27 19:29 ` [PATCH 00/11] dt-bindings: convert various Arm Ltd. IP " Rob Herring
2022-04-27 19:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=993d74fa-be5b-6db2-6bba-2323de7757f3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.