From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Fri, 22 Sep 2017 18:46:46 -0700 [thread overview]
Message-ID: <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> (raw)
In-Reply-To: <20170922092621.uq2xsvxangeetewi@sirena.org.uk>
On 09/22/17 02:26, Mark Brown wrote:
> On Thu, Sep 21, 2017 at 11:02:31AM -0700, Randy Dunlap wrote:
>
>> spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'
>>
>> v2: allow build with or without HWSPINLOCK, but restrict to =m
>> if HWSPINLOCK=m.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Please put inter version changelogs after the --- as covered in
> SubmittingPatches. This still seems like the stubs aren't doing the
Yep.
> right thing - if we can use hwspinlocks in a module when they're enabled
> I'd expect to be able to build the stubs that way too.
Sorry, I'm not understanding what you are trying to say on that one.
The hwspinlock stubs are present if HWSPINLOCK is not enabled (when
<linux/hwspinlock.h> is #included).
The following kconfig combinations build:
HWSPINLOCK SPI_SPRD_ADI
n y
n m
y y
y m
m m
but this combo is not allowed (with the patch) or causes build errors
(without the patch):
m y
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Fri, 22 Sep 2017 18:46:46 -0700 [thread overview]
Message-ID: <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> (raw)
In-Reply-To: <20170922092621.uq2xsvxangeetewi-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 09/22/17 02:26, Mark Brown wrote:
> On Thu, Sep 21, 2017 at 11:02:31AM -0700, Randy Dunlap wrote:
>
>> spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'
>>
>> v2: allow build with or without HWSPINLOCK, but restrict to =m
>> if HWSPINLOCK=m.
>>
>> Signed-off-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>
> Please put inter version changelogs after the --- as covered in
> SubmittingPatches. This still seems like the stubs aren't doing the
Yep.
> right thing - if we can use hwspinlocks in a module when they're enabled
> I'd expect to be able to build the stubs that way too.
Sorry, I'm not understanding what you are trying to say on that one.
The hwspinlock stubs are present if HWSPINLOCK is not enabled (when
<linux/hwspinlock.h> is #included).
The following kconfig combinations build:
HWSPINLOCK SPI_SPRD_ADI
n y
n m
y y
y m
m m
but this combo is not allowed (with the patch) or causes build errors
(without the patch):
m y
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-23 1:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:02 [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap
2017-09-22 9:26 ` Mark Brown
2017-09-22 9:26 ` Mark Brown
2017-09-23 1:46 ` Randy Dunlap [this message]
2017-09-23 1:46 ` Randy Dunlap
2017-09-25 16:12 ` Mark Brown
2017-09-25 16:12 ` Mark Brown
2017-09-25 17:19 ` Randy Dunlap
2017-09-25 17:36 ` Mark Brown
2017-09-25 17:36 ` Mark Brown
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:22 ` Mark Brown
2017-09-25 19:31 ` Randy Dunlap
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 21:11 ` Mark Brown
2017-09-25 21:11 ` Mark Brown
2017-09-25 22:32 ` Randy Dunlap
2017-09-25 22:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.