From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-spi <linux-spi@vger.kernel.org>,
Baolin Wang <Baolin.Wang@spreadtrum.com>
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Mon, 25 Sep 2017 15:32:56 -0700 [thread overview]
Message-ID: <faf455ad-b7ef-beac-ac6d-4822f350cd71@infradead.org> (raw)
In-Reply-To: <20170925211154.j23g4b2xmu4f3cxc@sirena.org.uk>
On 09/25/17 14:11, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 12:53:20PM -0700, Randy Dunlap wrote:
>> On 09/25/17 12:44, Mark Brown wrote:
>
>>> That would then get in the way of build test coverage.
>
>> I don't agree, but whatever. I give up.
>
> OK. Just as a general thing it's really important that dependency
> changes be thought through and express what the constraints are in ways
> that reflect what's actually going on and what's useful for users, it
> seems to be a frequent problem and it does get in the way.
Yes, it's a frequent problem that drivers do not build due to some kconfig
dependency issue(s).
I would prefer to see the driver maintainer(s) fix build errors themselves,
but they are not always aware of the idiosyncrasies of kconfig.
I think that people often submit drivers (or driver changes) after building
it in one (working) configuration only, without regard for the other possible
combinations.
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Baolin Wang <Baolin.Wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Mon, 25 Sep 2017 15:32:56 -0700 [thread overview]
Message-ID: <faf455ad-b7ef-beac-ac6d-4822f350cd71@infradead.org> (raw)
In-Reply-To: <20170925211154.j23g4b2xmu4f3cxc-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 09/25/17 14:11, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 12:53:20PM -0700, Randy Dunlap wrote:
>> On 09/25/17 12:44, Mark Brown wrote:
>
>>> That would then get in the way of build test coverage.
>
>> I don't agree, but whatever. I give up.
>
> OK. Just as a general thing it's really important that dependency
> changes be thought through and express what the constraints are in ways
> that reflect what's actually going on and what's useful for users, it
> seems to be a frequent problem and it does get in the way.
Yes, it's a frequent problem that drivers do not build due to some kconfig
dependency issue(s).
I would prefer to see the driver maintainer(s) fix build errors themselves,
but they are not always aware of the idiosyncrasies of kconfig.
I think that people often submit drivers (or driver changes) after building
it in one (working) configuration only, without regard for the other possible
combinations.
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-25 22:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 18:02 [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap
2017-09-22 9:26 ` Mark Brown
2017-09-22 9:26 ` Mark Brown
2017-09-23 1:46 ` Randy Dunlap
2017-09-23 1:46 ` Randy Dunlap
2017-09-25 16:12 ` Mark Brown
2017-09-25 16:12 ` Mark Brown
2017-09-25 17:19 ` Randy Dunlap
2017-09-25 17:36 ` Mark Brown
2017-09-25 17:36 ` Mark Brown
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:20 ` Geert Uytterhoeven
2017-09-25 19:22 ` Mark Brown
2017-09-25 19:31 ` Randy Dunlap
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:44 ` Mark Brown
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 19:53 ` Randy Dunlap
2017-09-25 21:11 ` Mark Brown
2017-09-25 21:11 ` Mark Brown
2017-09-25 22:32 ` Randy Dunlap [this message]
2017-09-25 22:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faf455ad-b7ef-beac-ac6d-4822f350cd71@infradead.org \
--to=rdunlap@infradead.org \
--cc=Baolin.Wang@spreadtrum.com \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.