From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: vkoul@kernel.org, kishon@ti.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, jonathan@marek.ca,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Wesley Cheng <wcheng@codeaurora.org>
Subject: Re: [PATCH 2/2] phy: qcom-qmp: Register as a typec switch for orientation detection
Date: Wed, 7 Jul 2021 01:35:43 +0100 [thread overview]
Message-ID: <9f213505-c118-b6fd-676b-1bafd83d8380@linaro.org> (raw)
In-Reply-To: <YOTuh2hYp7IC+4rt@yoga>
On 07/07/2021 01:00, Bjorn Andersson wrote:
> In order to perform link training on 4 lanes we need to reset the
> PHY_MODE_CTRL with only DP_MODE.
We're only the two lanes for USB on sm8250 and at the moment only USB
works - not dp on 8250.
Perhaps you've discovered why the DP times out on 8250..
> In my efforts on sc8180x I skipped the disable/enable in switch_set() (I
> believe because I didn't have the init_count check...) and then in
> qcom_qmp_phy_configure_dp_mode() I issue a reset when we're heading to 4
> lanes. Perhaps we can do the disable/enable and achieve the same thing,
> but as written here you won't get 4 lanes...
>
> I will do some more testing.
Do you have a commit I can cherry pick ? Might be worth testing out with
tcpm + dp on the sm8250 if its working for you on sc8180x
WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: vkoul@kernel.org, kishon@ti.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, jonathan@marek.ca,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Wesley Cheng <wcheng@codeaurora.org>
Subject: Re: [PATCH 2/2] phy: qcom-qmp: Register as a typec switch for orientation detection
Date: Wed, 7 Jul 2021 01:35:43 +0100 [thread overview]
Message-ID: <9f213505-c118-b6fd-676b-1bafd83d8380@linaro.org> (raw)
In-Reply-To: <YOTuh2hYp7IC+4rt@yoga>
On 07/07/2021 01:00, Bjorn Andersson wrote:
> In order to perform link training on 4 lanes we need to reset the
> PHY_MODE_CTRL with only DP_MODE.
We're only the two lanes for USB on sm8250 and at the moment only USB
works - not dp on 8250.
Perhaps you've discovered why the DP times out on 8250..
> In my efforts on sc8180x I skipped the disable/enable in switch_set() (I
> believe because I didn't have the init_count check...) and then in
> qcom_qmp_phy_configure_dp_mode() I issue a reset when we're heading to 4
> lanes. Perhaps we can do the disable/enable and achieve the same thing,
> but as written here you won't get 4 lanes...
>
> I will do some more testing.
Do you have a commit I can cherry pick ? Might be worth testing out with
tcpm + dp on the sm8250 if its working for you on sc8180x
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-07-07 0:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 23:07 [PATCH 0/2] pm8150b qmp phy type-c orientation fixes Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-06 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-06 23:26 ` Dmitry Baryshkov
2021-07-06 23:26 ` Dmitry Baryshkov
2021-07-06 23:29 ` Bryan O'Donoghue
2021-07-06 23:29 ` Bryan O'Donoghue
2021-07-07 0:04 ` Bjorn Andersson
2021-07-07 0:04 ` Bjorn Andersson
2021-07-07 0:10 ` Bryan O'Donoghue
2021-07-07 0:10 ` Bryan O'Donoghue
2021-07-06 23:07 ` [PATCH 2/2] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-07 0:00 ` Bjorn Andersson
2021-07-07 0:00 ` Bjorn Andersson
2021-07-07 0:35 ` Bryan O'Donoghue [this message]
2021-07-07 0:35 ` Bryan O'Donoghue
2021-07-07 0:50 ` Bjorn Andersson
2021-07-07 0:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f213505-c118-b6fd-676b-1bafd83d8380@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.