From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: vkoul@kernel.org, kishon@ti.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, jonathan@marek.ca,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
Date: Tue, 6 Jul 2021 19:04:01 -0500 [thread overview]
Message-ID: <YOTvcWnHFkbMHg6K@yoga> (raw)
In-Reply-To: <20210706230702.299047-2-bryan.odonoghue@linaro.org>
On Tue 06 Jul 18:07 CDT 2021, Bryan O'Donoghue wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
> fix issues with TypeC support.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
> Cc: robh+dt@kernel.org
> Cc: devicetree@vger.kernel.org
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c0de12aaba6..270d7ff59ec1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
> <&gcc GCC_USB3_PHY_SEC_BCR>;
> reset-names = "phy", "common";
>
> - usb_2_ssphy: lane@88eb200 {
> + usb_2_ssphy: lanes@88eb200 {
The uni-phy binding says that this should be named "^phy@[0-9a-f]+$"
So while Dmitry is right about the logic in the driver, it would be nice
if you would spin this patch to make us pass the dt-binding check -
which can be sent independently from the driver patch.
Regards,
Bjorn
> reg = <0 0x088eb200 0 0x200>,
> <0 0x088eb400 0 0x200>,
> <0 0x088eb800 0 0x800>;
> --
> 2.30.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: vkoul@kernel.org, kishon@ti.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, jonathan@marek.ca,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node
Date: Tue, 6 Jul 2021 19:04:01 -0500 [thread overview]
Message-ID: <YOTvcWnHFkbMHg6K@yoga> (raw)
In-Reply-To: <20210706230702.299047-2-bryan.odonoghue@linaro.org>
On Tue 06 Jul 18:07 CDT 2021, Bryan O'Donoghue wrote:
> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Use 'lanes' as SuperSpeed lanes device node instead of just 'lane' to
> fix issues with TypeC support.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: be0624b99042 ("arm64: dts: qcom: sm8250: Add USB and PHY device nodes")
> Cc: robh+dt@kernel.org
> Cc: devicetree@vger.kernel.org
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c0de12aaba6..270d7ff59ec1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2123,7 +2123,7 @@ usb_2_qmpphy: phy@88eb000 {
> <&gcc GCC_USB3_PHY_SEC_BCR>;
> reset-names = "phy", "common";
>
> - usb_2_ssphy: lane@88eb200 {
> + usb_2_ssphy: lanes@88eb200 {
The uni-phy binding says that this should be named "^phy@[0-9a-f]+$"
So while Dmitry is right about the logic in the driver, it would be nice
if you would spin this patch to make us pass the dt-binding check -
which can be sent independently from the driver patch.
Regards,
Bjorn
> reg = <0 0x088eb200 0 0x200>,
> <0 0x088eb400 0 0x200>,
> <0 0x088eb800 0 0x800>;
> --
> 2.30.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-07-07 0:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 23:07 [PATCH 0/2] pm8150b qmp phy type-c orientation fixes Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-06 23:07 ` [PATCH 1/2] arm64: dts: qcom: sm8250: fix usb2 qmp phy node Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-06 23:26 ` Dmitry Baryshkov
2021-07-06 23:26 ` Dmitry Baryshkov
2021-07-06 23:29 ` Bryan O'Donoghue
2021-07-06 23:29 ` Bryan O'Donoghue
2021-07-07 0:04 ` Bjorn Andersson [this message]
2021-07-07 0:04 ` Bjorn Andersson
2021-07-07 0:10 ` Bryan O'Donoghue
2021-07-07 0:10 ` Bryan O'Donoghue
2021-07-06 23:07 ` [PATCH 2/2] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2021-07-06 23:07 ` Bryan O'Donoghue
2021-07-07 0:00 ` Bjorn Andersson
2021-07-07 0:00 ` Bjorn Andersson
2021-07-07 0:35 ` Bryan O'Donoghue
2021-07-07 0:35 ` Bryan O'Donoghue
2021-07-07 0:50 ` Bjorn Andersson
2021-07-07 0:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOTvcWnHFkbMHg6K@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.