All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kochetkov <al.kochet@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Caesar Wang <wxt@rock-chips.com>,
	Huang Tao <huangtao@rock-chips.com>
Subject: Re: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC
Date: Mon, 30 Jan 2017 14:20:13 +0300	[thread overview]
Message-ID: <A5940770-B960-4409-8DA4-BE39EF9A6325@gmail.com> (raw)
In-Reply-To: <20170130110428.GC2206@mai>


> 30 янв. 2017 г., в 14:04, Daniel Lezcano <daniel.lezcano@linaro.org> написал(а):
> 
> t is up to the RTC to wake up the system from suspend and there is no
> idle state stopping the local timers on these SoCs. So, the rockchip timers
> won't be ever used on the rk3188, right ?

No rockchip timers where used on rk3188 before.

Actually, I don’t know how to test backup timer functionality. rk3228 backup timer is from alive
subsystem. It is unclear from TRM what this mean, I assume that somehow related to CLK
during suspend. So I pick the timer from alive subsystem on rk3188 also.
DT timer configuration where tested: interrupts and IO works.

> This patch should go after the rockchip timer patches


Ok, let me know, when I should send v6. Or may be you change the order of the patches
during merge.

And thank you for fixing commit message for previous patch.
Feel free to tell me than I write something really unclear or incorrect.

Alexander.

WARNING: multiple messages have this Message-ID (diff)
From: al.kochet@gmail.com (Alexander Kochetkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC
Date: Mon, 30 Jan 2017 14:20:13 +0300	[thread overview]
Message-ID: <A5940770-B960-4409-8DA4-BE39EF9A6325@gmail.com> (raw)
In-Reply-To: <20170130110428.GC2206@mai>


> 30 ???. 2017 ?., ? 14:04, Daniel Lezcano <daniel.lezcano@linaro.org> ???????(?):
> 
> t is up to the RTC to wake up the system from suspend and there is no
> idle state stopping the local timers on these SoCs. So, the rockchip timers
> won't be ever used on the rk3188, right ?

No rockchip timers where used on rk3188 before.

Actually, I don?t know how to test backup timer functionality. rk3228 backup timer is from alive
subsystem. It is unclear from TRM what this mean, I assume that somehow related to CLK
during suspend. So I pick the timer from alive subsystem on rk3188 also.
DT timer configuration where tested: interrupts and IO works.

> This patch should go after the rockchip timer patches


Ok, let me know, when I should send v6. Or may be you change the order of the patches
during merge.

And thank you for fixing commit message for previous patch.
Feel free to tell me than I write something really unclear or incorrect.

Alexander.

  reply	other threads:[~2017-01-30 11:20 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 12:16 [PATCH v5 0/8] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2017-01-24 12:16 ` Alexander Kochetkov
2017-01-24 12:16 ` Alexander Kochetkov
2017-01-24 12:16 ` [PATCH v5 1/8] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16 ` [PATCH v5 2/8] ARM: dts: rockchip: update compatible property for rk322x timer Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16 ` [PATCH v5 3/8] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-30 11:04   ` Daniel Lezcano
2017-01-30 11:04     ` Daniel Lezcano
2017-01-30 11:04     ` Daniel Lezcano
2017-01-30 11:20     ` Alexander Kochetkov [this message]
2017-01-30 11:20       ` Alexander Kochetkov
2017-01-30 12:04       ` Daniel Lezcano
2017-01-30 12:04         ` Daniel Lezcano
2017-01-30 13:13         ` Alexander Kochetkov
2017-01-30 13:13           ` Alexander Kochetkov
2017-01-30 13:13           ` Alexander Kochetkov
2017-01-30 13:35           ` Daniel Lezcano
2017-01-30 13:35             ` Daniel Lezcano
2017-01-30 13:35             ` Daniel Lezcano
2017-01-24 12:16 ` [PATCH v5 4/8] ARM: dts: rockchip: disable arm-global-timer for rk3188 Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-30 10:21   ` Daniel Lezcano
2017-01-30 10:21     ` Daniel Lezcano
2017-01-24 12:16 ` [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 15:02   ` Heiko Stübner
2017-01-24 15:02     ` Heiko Stübner
2017-01-24 15:02     ` Heiko Stübner
2017-01-24 15:16     ` Alexander Kochetkov
2017-01-24 15:16       ` Alexander Kochetkov
2017-01-24 15:16       ` Alexander Kochetkov
2017-01-29 20:30       ` Heiko Stuebner
2017-01-29 20:30         ` Heiko Stuebner
2017-01-29 20:30         ` Heiko Stuebner
2017-01-30 13:12   ` Daniel Lezcano
2017-01-30 13:12     ` Daniel Lezcano
2017-01-30 13:12     ` Daniel Lezcano
2017-01-30 13:55     ` Alexander Kochetkov
2017-01-30 13:55       ` Alexander Kochetkov
2017-01-30 13:55       ` Alexander Kochetkov
2017-01-30 14:20       ` Daniel Lezcano
2017-01-30 14:20         ` Daniel Lezcano
2017-01-30 14:20         ` Daniel Lezcano
2017-01-24 12:16 ` [PATCH v5 6/8] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16 ` [PATCH v5 7/8] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16 ` [PATCH v5 8/8] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-24 12:16   ` Alexander Kochetkov
2017-01-30 13:54   ` Daniel Lezcano
2017-01-30 13:54     ` Daniel Lezcano
2017-01-30 13:54     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A5940770-B960-4409-8DA4-BE39EF9A6325@gmail.com \
    --to=al.kochet@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.