From: Linus Walleij <linus.walleij@stericsson.com>
To: Kevin Wells <kevin.wells@nxp.com>
Cc: Kevin Wells <wellsk40@gmail.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"rabin.vincent@stericsson.com" <rabin.vincent@stericsson.com>,
"srinidhi.kasagar@stericsson.com"
<srinidhi.kasagar@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tj@kernel.org" <tj@kernel.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"Lukasz.Baj@tieto.com" <Lukasz.Baj@tieto.com>
Subject: Re: resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode
Date: Tue, 14 Sep 2010 16:45:57 +0200 [thread overview]
Message-ID: <AANLkTim4a7eha6Z3pjrZ0kg9VNRcuH52Qs2h4XydsXi4@mail.gmail.com> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F80AD49D5230@eu1rdcrdc1wx030.exi.nxp.com>
2010/9/13 Kevin Wells <kevin.wells@nxp.com>:
> SSP_CR0_MASK_SPH (SPHA) should use bit 7, not bit 6.
> Should be:
> SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 7);
>
>> +
>> SSP_WRITE_BITS(chip->cr0, chip_info->clk_freq.scr, SSP_CR0_MASK_SCR,
>> 8);
>> /* Loopback is available on all versions except PL023 */
That's it!
With this correction it starts working, so
Acked-by/Tested-by/Reviewed-by: Linus Walleij <linus.walleij@stericsson.com>
Please submit the whole patch series with corrections and my tag
so Grant can pick it up, and thanks for doing this because I think
it is a great improvement to the driver!
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@stericsson.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode
Date: Tue, 14 Sep 2010 16:45:57 +0200 [thread overview]
Message-ID: <AANLkTim4a7eha6Z3pjrZ0kg9VNRcuH52Qs2h4XydsXi4@mail.gmail.com> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F80AD49D5230@eu1rdcrdc1wx030.exi.nxp.com>
2010/9/13 Kevin Wells <kevin.wells@nxp.com>:
> SSP_CR0_MASK_SPH (SPHA) should use bit 7, not bit 6.
> Should be:
> ? ? ? SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 7);
>
>> +
>> ? ? ? ?SSP_WRITE_BITS(chip->cr0, chip_info->clk_freq.scr, SSP_CR0_MASK_SCR,
>> 8);
>> ? ? ? ?/* Loopback is available on all versions except PL023 */
That's it!
With this correction it starts working, so
Acked-by/Tested-by/Reviewed-by: Linus Walleij <linus.walleij@stericsson.com>
Please submit the whole patch series with corrections and my tag
so Grant can pick it up, and thanks for doing this because I think
it is a great improvement to the driver!
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-09-14 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 22:57 resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode Kevin Wells
2010-09-10 22:57 ` Kevin Wells
2010-09-13 16:51 ` Kevin Wells
2010-09-13 16:51 ` Kevin Wells
2010-09-13 16:51 ` Kevin Wells
2010-09-14 14:45 ` Linus Walleij [this message]
2010-09-14 14:45 ` Linus Walleij
2010-09-14 14:45 ` Linus Walleij
2010-09-16 19:16 ` Kevin Wells
2010-09-16 19:16 ` Kevin Wells
2010-09-16 19:16 ` Kevin Wells
2010-09-10 22:57 Kevin Wells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim4a7eha6Z3pjrZ0kg9VNRcuH52Qs2h4XydsXi4@mail.gmail.com \
--to=linus.walleij@stericsson.com \
--cc=Lukasz.Baj@tieto.com \
--cc=grant.likely@secretlab.ca \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rabin.vincent@stericsson.com \
--cc=sameo@linux.intel.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wellsk40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.