From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant pci_enable_pcie_error_reporting()
Date: Wed, 25 Jan 2023 09:09:11 +0000 [thread overview]
Message-ID: <BYAPR11MB33670FA9442A0D4659824849FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230118234612.272916-8-helgaas@kernel.org>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjorn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
> pci_enable_pcie_error_reporting()
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver. Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this doesn't control interrupt generation by the Root Port; that is
> controlled by the AER Root Error Command register, which is managed by the
> AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
WARNING: multiple messages have this Message-ID (diff)
From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant pci_enable_pcie_error_reporting()
Date: Wed, 25 Jan 2023 09:09:11 +0000 [thread overview]
Message-ID: <BYAPR11MB33670FA9442A0D4659824849FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230118234612.272916-8-helgaas@kernel.org>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjorn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 7/9] igb: Remove redundant
> pci_enable_pcie_error_reporting()
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver. Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this doesn't control interrupt generation by the Root Port; that is
> controlled by the AER Root Error Command register, which is managed by the
> AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-25 9:09 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 23:46 [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas
2023-01-18 23:46 ` [PATCH 1/9] " Bjorn Helgaas
2023-01-19 3:49 ` Sathyanarayanan Kuppuswamy
2023-01-24 7:22 ` Stefan Roese
2023-01-18 23:46 ` [PATCH 2/9] e1000e: Remove redundant pci_enable_pcie_error_reporting() Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen
2023-01-19 18:40 ` Bjorn Helgaas
2023-01-19 18:40 ` Bjorn Helgaas
2023-01-19 21:31 ` Tony Nguyen
2023-01-19 21:31 ` Tony Nguyen
2023-01-20 5:35 ` Jakub Kicinski
2023-01-20 5:35 ` Jakub Kicinski
2023-01-20 3:17 ` Jakub Kicinski
2023-01-20 3:17 ` [Intel-wired-lan] " Jakub Kicinski
2023-01-20 13:14 ` Bjorn Helgaas
2023-01-20 13:14 ` Bjorn Helgaas
2023-01-18 23:46 ` [PATCH 3/9] fm10k: " Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen
2023-01-18 23:46 ` [PATCH 4/9] i40e: " Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` Tony Nguyen
2023-01-25 10:34 ` [Intel-wired-lan] " G, GurucharanX
2023-01-25 10:34 ` G, GurucharanX
2023-01-18 23:46 ` [PATCH 5/9] iavf: " Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` Tony Nguyen
2023-01-25 10:22 ` [Intel-wired-lan] " Szlosek, Marek
2023-01-18 23:46 ` [PATCH 6/9] ice: " Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` Tony Nguyen
2023-01-25 9:08 ` [Intel-wired-lan] " G, GurucharanX
2023-01-25 9:08 ` G, GurucharanX
2023-01-18 23:46 ` [PATCH 7/9] igb: " Bjorn Helgaas
2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen
2023-01-25 9:09 ` G, GurucharanX [this message]
2023-01-25 9:09 ` G, GurucharanX
2023-01-18 23:46 ` [Intel-wired-lan] [PATCH 8/9] igc: " Bjorn Helgaas
2023-01-18 23:46 ` Bjorn Helgaas
2023-01-19 18:28 ` Tony Nguyen
2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen
2023-01-24 11:33 ` naamax.meir
2023-01-24 11:33 ` naamax.meir
2023-01-18 23:46 ` [Intel-wired-lan] [PATCH 9/9] ixgbe: " Bjorn Helgaas
2023-01-18 23:46 ` Bjorn Helgaas
2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen
2023-01-19 18:28 ` Tony Nguyen
2023-01-25 9:09 ` [Intel-wired-lan] " G, GurucharanX
2023-01-25 9:09 ` G, GurucharanX
2023-01-19 3:55 ` [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable Sathyanarayanan Kuppuswamy
2023-01-19 4:26 ` Bjorn Helgaas
2023-01-26 23:15 ` Bjorn Helgaas
2023-01-26 23:15 ` [Intel-wired-lan] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB33670FA9442A0D4659824849FCCE9@BYAPR11MB3367.namprd11.prod.outlook.com \
--to=gurucharanx.g@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.