From: Tony Nguyen <anthony.l.nguyen@intel.com> To: Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org> Cc: Bjorn Helgaas <bhelgaas@google.com>, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Jesse Brandeburg <jesse.brandeburg@intel.com> Subject: Re: [Intel-wired-lan] [PATCH 5/9] iavf: Remove redundant pci_enable_pcie_error_reporting() Date: Thu, 19 Jan 2023 10:28:42 -0800 [thread overview] Message-ID: <c7eb0b28-4b55-f1f5-7338-dfc96015db89@intel.com> (raw) In-Reply-To: <20230118234612.272916-6-helgaas@kernel.org> On 1/18/2023 3:46 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this doesn't control interrupt generation by the Root Port; that > is controlled by the AER Root Error Command register, which is managed by > the AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index c4e451ef7942..2835af20ec19 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -4876,8 +4876,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > goto err_pci_reg; > } > > - pci_enable_pcie_error_reporting(pdev); > - > pci_set_master(pdev); > > netdev = alloc_etherdev_mq(sizeof(struct iavf_adapter), > @@ -4956,7 +4954,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > err_ioremap: > free_netdev(netdev); > err_alloc_etherdev: > - pci_disable_pcie_error_reporting(pdev); > pci_release_regions(pdev); > err_pci_reg: > err_dma: > @@ -5172,8 +5169,6 @@ static void iavf_remove(struct pci_dev *pdev) > > free_netdev(netdev); > > - pci_disable_pcie_error_reporting(pdev); > - > pci_disable_device(pdev); > } > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Tony Nguyen <anthony.l.nguyen@intel.com> To: Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org> Subject: Re: [PATCH 5/9] iavf: Remove redundant pci_enable_pcie_error_reporting() Date: Thu, 19 Jan 2023 10:28:42 -0800 [thread overview] Message-ID: <c7eb0b28-4b55-f1f5-7338-dfc96015db89@intel.com> (raw) In-Reply-To: <20230118234612.272916-6-helgaas@kernel.org> On 1/18/2023 3:46 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this doesn't control interrupt generation by the Root Port; that > is controlled by the AER Root Error Command register, which is managed by > the AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > --- > drivers/net/ethernet/intel/iavf/iavf_main.c | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c > index c4e451ef7942..2835af20ec19 100644 > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > @@ -4876,8 +4876,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > goto err_pci_reg; > } > > - pci_enable_pcie_error_reporting(pdev); > - > pci_set_master(pdev); > > netdev = alloc_etherdev_mq(sizeof(struct iavf_adapter), > @@ -4956,7 +4954,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > err_ioremap: > free_netdev(netdev); > err_alloc_etherdev: > - pci_disable_pcie_error_reporting(pdev); > pci_release_regions(pdev); > err_pci_reg: > err_dma: > @@ -5172,8 +5169,6 @@ static void iavf_remove(struct pci_dev *pdev) > > free_netdev(netdev); > > - pci_disable_pcie_error_reporting(pdev); > - > pci_disable_device(pdev); > } >
next prev parent reply other threads:[~2023-01-19 18:29 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-18 23:46 [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable Bjorn Helgaas 2023-01-18 23:46 ` [PATCH 1/9] " Bjorn Helgaas 2023-01-19 3:49 ` Sathyanarayanan Kuppuswamy 2023-01-24 7:22 ` Stefan Roese 2023-01-18 23:46 ` [PATCH 2/9] e1000e: Remove redundant pci_enable_pcie_error_reporting() Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen 2023-01-19 18:40 ` Bjorn Helgaas 2023-01-19 18:40 ` Bjorn Helgaas 2023-01-19 21:31 ` Tony Nguyen 2023-01-19 21:31 ` Tony Nguyen 2023-01-20 5:35 ` Jakub Kicinski 2023-01-20 5:35 ` Jakub Kicinski 2023-01-20 3:17 ` Jakub Kicinski 2023-01-20 3:17 ` [Intel-wired-lan] " Jakub Kicinski 2023-01-20 13:14 ` Bjorn Helgaas 2023-01-20 13:14 ` Bjorn Helgaas 2023-01-18 23:46 ` [PATCH 3/9] fm10k: " Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen 2023-01-18 23:46 ` [PATCH 4/9] i40e: " Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` Tony Nguyen 2023-01-25 10:34 ` [Intel-wired-lan] " G, GurucharanX 2023-01-25 10:34 ` G, GurucharanX 2023-01-18 23:46 ` [PATCH 5/9] iavf: " Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen [this message] 2023-01-19 18:28 ` Tony Nguyen 2023-01-25 10:22 ` [Intel-wired-lan] " Szlosek, Marek 2023-01-18 23:46 ` [PATCH 6/9] ice: " Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` Tony Nguyen 2023-01-25 9:08 ` [Intel-wired-lan] " G, GurucharanX 2023-01-25 9:08 ` G, GurucharanX 2023-01-18 23:46 ` [PATCH 7/9] igb: " Bjorn Helgaas 2023-01-18 23:46 ` [Intel-wired-lan] " Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen 2023-01-25 9:09 ` G, GurucharanX 2023-01-25 9:09 ` G, GurucharanX 2023-01-18 23:46 ` [Intel-wired-lan] [PATCH 8/9] igc: " Bjorn Helgaas 2023-01-18 23:46 ` Bjorn Helgaas 2023-01-19 18:28 ` Tony Nguyen 2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen 2023-01-24 11:33 ` naamax.meir 2023-01-24 11:33 ` naamax.meir 2023-01-18 23:46 ` [Intel-wired-lan] [PATCH 9/9] ixgbe: " Bjorn Helgaas 2023-01-18 23:46 ` Bjorn Helgaas 2023-01-19 18:28 ` [Intel-wired-lan] " Tony Nguyen 2023-01-19 18:28 ` Tony Nguyen 2023-01-25 9:09 ` [Intel-wired-lan] " G, GurucharanX 2023-01-25 9:09 ` G, GurucharanX 2023-01-19 3:55 ` [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable Sathyanarayanan Kuppuswamy 2023-01-19 4:26 ` Bjorn Helgaas 2023-01-26 23:15 ` Bjorn Helgaas 2023-01-26 23:15 ` [Intel-wired-lan] " Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c7eb0b28-4b55-f1f5-7338-dfc96015db89@intel.com \ --to=anthony.l.nguyen@intel.com \ --cc=bhelgaas@google.com \ --cc=helgaas@kernel.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jesse.brandeburg@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.