From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Marc Zyngier <maz@kernel.org>
Cc: James Morris <jmorris@namei.org>, Sasha Levin <sashal@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
kexec mailing list <kexec@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
James Morse <james.morse@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
linux-mm <linux-mm@kvack.org>,
Mark Rutland <mark.rutland@arm.com>,
steve.capper@arm.com, rfontana@redhat.com,
Thomas Gleixner <tglx@linutronix.de>,
Selin Dag <selindag@gmail.com>
Subject: Re: [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors
Date: Mon, 25 Jan 2021 14:07:39 -0500 [thread overview]
Message-ID: <CA+CK2bB=kLV7gamcpdBr0SJ1mR-JwosL8FH=AiFMUmvGc_FE6g@mail.gmail.com> (raw)
In-Reply-To: <e5f1ee17f8e4ac3a5f5077d85318e0ed@kernel.org>
> > +.macro el1_sync_64
> > + br x4 /* Jump to new world from el2 */
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
>
> The common idiom to write this is to align the beginning of the
> macro, and not to bother about what follows:
>
> .macro whatever
> .align 7
> br x4
> .endm
>
> Specially given that 0 is an undefined instruction, and I really hate to
> see
> those in the actual text. On the contrary, .align generates NOPs.
Fixed that.
>
> > +
> > +.macro invalid_vector label
> > +\label:
> > + b \label
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
> > +
> > +/* el2 vectors - switch el2 here while we restore the memory image. */
> > + .align 11
> > +ENTRY(kexec_el2_vectors)
>
> Please see commit 617a2f392c92 ("arm64: kvm: Annotate assembly using
> modern
> annoations"), and follow the same pattern.
Fixed that as well.
Thank you,
Pasha
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
steve.capper@arm.com,
kexec mailing list <kexec@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Selin Dag <selindag@gmail.com>, James Morris <jmorris@namei.org>,
linux-mm <linux-mm@kvack.org>, James Morse <james.morse@arm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
rfontana@redhat.com, Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors
Date: Mon, 25 Jan 2021 14:07:39 -0500 [thread overview]
Message-ID: <CA+CK2bB=kLV7gamcpdBr0SJ1mR-JwosL8FH=AiFMUmvGc_FE6g@mail.gmail.com> (raw)
In-Reply-To: <e5f1ee17f8e4ac3a5f5077d85318e0ed@kernel.org>
> > +.macro el1_sync_64
> > + br x4 /* Jump to new world from el2 */
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
>
> The common idiom to write this is to align the beginning of the
> macro, and not to bother about what follows:
>
> .macro whatever
> .align 7
> br x4
> .endm
>
> Specially given that 0 is an undefined instruction, and I really hate to
> see
> those in the actual text. On the contrary, .align generates NOPs.
Fixed that.
>
> > +
> > +.macro invalid_vector label
> > +\label:
> > + b \label
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
> > +
> > +/* el2 vectors - switch el2 here while we restore the memory image. */
> > + .align 11
> > +ENTRY(kexec_el2_vectors)
>
> Please see commit 617a2f392c92 ("arm64: kvm: Annotate assembly using
> modern
> annoations"), and follow the same pattern.
Fixed that as well.
Thank you,
Pasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@soleen.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
steve.capper@arm.com,
kexec mailing list <kexec@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Selin Dag <selindag@gmail.com>, James Morris <jmorris@namei.org>,
linux-mm <linux-mm@kvack.org>, James Morse <james.morse@arm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
rfontana@redhat.com, Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors
Date: Mon, 25 Jan 2021 14:07:39 -0500 [thread overview]
Message-ID: <CA+CK2bB=kLV7gamcpdBr0SJ1mR-JwosL8FH=AiFMUmvGc_FE6g@mail.gmail.com> (raw)
In-Reply-To: <e5f1ee17f8e4ac3a5f5077d85318e0ed@kernel.org>
> > +.macro el1_sync_64
> > + br x4 /* Jump to new world from el2 */
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
>
> The common idiom to write this is to align the beginning of the
> macro, and not to bother about what follows:
>
> .macro whatever
> .align 7
> br x4
> .endm
>
> Specially given that 0 is an undefined instruction, and I really hate to
> see
> those in the actual text. On the contrary, .align generates NOPs.
Fixed that.
>
> > +
> > +.macro invalid_vector label
> > +\label:
> > + b \label
> > + .fill 31, 4, 0 /* Set other 31 instr to zeroes */
> > +.endm
> > +
> > +/* el2 vectors - switch el2 here while we restore the memory image. */
> > + .align 11
> > +ENTRY(kexec_el2_vectors)
>
> Please see commit 617a2f392c92 ("arm64: kvm: Annotate assembly using
> modern
> annoations"), and follow the same pattern.
Fixed that as well.
Thank you,
Pasha
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-01-25 19:39 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 3:24 [PATCH v9 00/18] arm64: MMU enabled kexec relocation Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 01/18] arm64: kexec: make dtb_mem always enabled Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:00 ` James Morse
2020-04-29 17:00 ` James Morse
2020-04-29 17:00 ` James Morse
2021-01-23 0:17 ` Pavel Tatashin
2021-01-23 0:17 ` Pavel Tatashin
2021-01-23 0:17 ` Pavel Tatashin
2021-01-23 0:17 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 02/18] arm64: hibernate: move page handling function to new trans_pgd.c Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:00 ` James Morse
2020-04-29 17:00 ` James Morse
2020-04-29 17:00 ` James Morse
2021-01-23 0:18 ` Pavel Tatashin
2021-01-23 0:18 ` Pavel Tatashin
2021-01-23 0:18 ` Pavel Tatashin
2021-01-23 0:18 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 03/18] arm64: trans_pgd: make trans_pgd_map_page generic Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-22 21:52 ` Pavel Tatashin
2021-01-22 21:52 ` Pavel Tatashin
2021-01-22 21:52 ` Pavel Tatashin
2021-01-22 21:52 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 04/18] arm64: trans_pgd: pass allocator trans_pgd_create_copy Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-23 0:20 ` Pavel Tatashin
2021-01-23 0:20 ` Pavel Tatashin
2021-01-23 0:20 ` Pavel Tatashin
2021-01-23 0:20 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 05/18] arm64: trans_pgd: pass NULL instead of init_mm to *_populate functions Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-23 0:22 ` Pavel Tatashin
2021-01-23 0:22 ` Pavel Tatashin
2021-01-23 0:22 ` Pavel Tatashin
2021-01-23 0:22 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 06/18] arm64: mm: Always update TCR_EL1 from __cpu_set_tcr_t0sz() Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 07/18] arm64: trans_pgd: hibernate: idmap the single page that holds the copy page routines Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-23 0:35 ` Pavel Tatashin
2021-01-23 0:35 ` Pavel Tatashin
2021-01-23 0:35 ` Pavel Tatashin
2021-01-23 0:35 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 08/18] arm64: kexec: move relocation function setup Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-23 1:01 ` Pavel Tatashin
2021-01-23 1:01 ` Pavel Tatashin
2021-01-23 1:01 ` Pavel Tatashin
2021-01-23 1:01 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-03-26 3:24 ` [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2020-04-29 17:01 ` James Morse
2021-01-23 1:14 ` Pavel Tatashin
2021-01-23 1:14 ` Pavel Tatashin
2021-01-23 1:14 ` Pavel Tatashin
2021-01-23 1:14 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 11/18] arm64: kexec: arm64_relocate_new_kernel clean-ups Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 12/18] arm64: kexec: arm64_relocate_new_kernel don't use x0 as temp Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 13/18] arm64: kexec: add expandable argument to relocation function Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2021-01-23 2:49 ` Pavel Tatashin
2021-01-23 2:49 ` Pavel Tatashin
2021-01-23 2:49 ` Pavel Tatashin
2021-01-23 2:49 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 14/18] arm64: kexec: offset for " Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 15/18] arm64: kexec: kexec EL2 vectors Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-04-29 17:35 ` Marc Zyngier
2020-04-29 17:35 ` Marc Zyngier
2020-04-29 17:35 ` Marc Zyngier
2021-01-25 19:07 ` Pavel Tatashin [this message]
2021-01-25 19:07 ` Pavel Tatashin
2021-01-25 19:07 ` Pavel Tatashin
2021-01-25 19:07 ` Pavel Tatashin
2020-05-07 16:21 ` James Morse
2020-05-07 16:21 ` James Morse
2020-05-07 16:21 ` James Morse
2020-03-26 3:24 ` [PATCH v9 16/18] arm64: kexec: configure trans_pgd page table for kexec Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-05-07 16:22 ` James Morse
2020-03-26 3:24 ` [PATCH v9 17/18] arm64: kexec: enable MMU during kexec relocation Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
2020-03-26 3:24 ` [PATCH v9 18/18] arm64: kexec: remove head from relocation argument Pavel Tatashin
2020-03-26 3:24 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+CK2bB=kLV7gamcpdBr0SJ1mR-JwosL8FH=AiFMUmvGc_FE6g@mail.gmail.com' \
--to=pasha.tatashin@soleen.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=rfontana@redhat.com \
--cc=sashal@kernel.org \
--cc=selindag@gmail.com \
--cc=steve.capper@arm.com \
--cc=tglx@linutronix.de \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.