From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Schspa Shi <schspa@gmail.com>,
kernel-team@android.com, Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH 09/19] KVM: arm64: vgic-v3: Make the userspace accessors use sysreg API
Date: Tue, 12 Jul 2022 22:21:25 -0700 [thread overview]
Message-ID: <CAAeT=Fz-qGbTQ2PTG6xuS-uo_ANnuxQQt47fy_wP3sdsM10Fgw@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-10-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> The vgic-v3 sysreg accessors have been ignored as the rest of the
> sysreg internal API was avolving, and are stuck with the .access
Nit: s/avolving/evolving/ ?
> method (which is normally reserved to the guest's own access)
> for the userspace accesses (which should use the .set/.get_user()
> methods).
>
> Catch up with the program and repaint all the accessors so that
> they fit into the normal userspace model, and plug the result into
> the helpers that have been introduced earlier.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/vgic-sys-reg-v3.c | 453 ++++++++++++++++++-------------
> 1 file changed, 257 insertions(+), 196 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic-sys-reg-v3.c b/arch/arm64/kvm/vgic-sys-reg-v3.c
> index 8c56e285fde9..2ca172cdc5c4 100644
> --- a/arch/arm64/kvm/vgic-sys-reg-v3.c
> +++ b/arch/arm64/kvm/vgic-sys-reg-v3.c
> @@ -10,254 +10,331 @@
> #include "vgic/vgic.h"
> #include "sys_regs.h"
>
> -static bool access_gic_ctlr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> u32 host_pri_bits, host_id_bits, host_seis, host_a3v, seis, a3v;
> struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> +
> + /*
> + * Disallow restoring VM state if not supported by this
> + * hardware.
> + */
> + host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> + ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> + if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_pri_bits = host_pri_bits;
> +
> + host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> + ICC_CTLR_EL1_ID_BITS_SHIFT;
> + if (host_id_bits > vgic_v3_cpu->num_id_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_id_bits = host_id_bits;
> +
> + host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> + seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + if (host_seis != seis)
> + return -EINVAL;
> +
> + host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> + a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> + if (host_a3v != a3v)
> + return -EINVAL;
> +
> + /*
> + * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> + * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> + */
> + vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> + vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *valp)
> +{
> + struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> + struct vgic_vmcr vmcr;
> u64 val;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - val = p->regval;
> -
> - /*
> - * Disallow restoring VM state if not supported by this
> - * hardware.
> - */
> - host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> - ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> - if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> - return false;
> -
> - vgic_v3_cpu->num_pri_bits = host_pri_bits;
> -
> - host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> - ICC_CTLR_EL1_ID_BITS_SHIFT;
> - if (host_id_bits > vgic_v3_cpu->num_id_bits)
> - return false;
> -
> - vgic_v3_cpu->num_id_bits = host_id_bits;
> -
> - host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> - seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - if (host_seis != seis)
> - return false;
> -
> - host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> - a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> - if (host_a3v != a3v)
> - return false;
> -
> - /*
> - * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> - * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> - */
> - vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> - vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - val = 0;
> - val |= (vgic_v3_cpu->num_pri_bits - 1) <<
> - ICC_CTLR_EL1_PRI_BITS_SHIFT;
> - val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> - ICC_CTLR_EL1_A3V_SHIFT;
> - /*
> - * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> - * Extract it directly using ICC_CTLR_EL1 reg definitions.
> - */
> - val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> - val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> -
> - p->regval = val;
> - }
> + val = 0;
> + val |= (vgic_v3_cpu->num_pri_bits - 1) << ICC_CTLR_EL1_PRI_BITS_SHIFT;
> + val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> + ICC_CTLR_EL1_A3V_SHIFT;
> + /*
> + * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> + * Extract it directly using ICC_CTLR_EL1 reg definitions.
> + */
> + val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> + val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> +
> + *valp = val;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_pmr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.pmr = (p->regval & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
> - }
> + vmcr.pmr = (val & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.bpr = (p->regval & ICC_BPR0_EL1_MASK) >>
> - ICC_BPR0_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) &
> - ICC_BPR0_EL1_MASK;
> - }
> + *val = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> - if (!p->is_write)
> - p->regval = 0;
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.bpr = (val & ICC_BPR0_EL1_MASK) >> ICC_BPR0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (!vmcr.cbpr) {
> - if (p->is_write) {
> - vmcr.abpr = (p->regval & ICC_BPR1_EL1_MASK) >>
> - ICC_BPR1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) &
> - ICC_BPR1_EL1_MASK;
> - }
> - } else {
> - if (!p->is_write)
> - p->regval = min((vmcr.bpr + 1), 7U);
> - }
> + *val = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) & ICC_BPR0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen0 = (p->regval & ICC_IGRPEN0_EL1_MASK) >>
> - ICC_IGRPEN0_EL1_SHIFT;
> + if (!vmcr.cbpr) {
> + vmcr.abpr = (val & ICC_BPR1_EL1_MASK) >> ICC_BPR1_EL1_SHIFT;
> vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) &
> - ICC_IGRPEN0_EL1_MASK;
> }
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen1 = (p->regval & ICC_IGRPEN1_EL1_MASK) >>
> - ICC_IGRPEN1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) &
> - ICC_IGRPEN1_EL1_MASK;
> - }
> + if (!vmcr.cbpr)
> + *val = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) & ICC_BPR1_EL1_MASK;
> + else
> + *val = min((vmcr.bpr + 1), 7U);
> +
> +
> + return 0;
> +}
> +
> +static int set_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen0 = (val & ICC_IGRPEN0_EL1_MASK) >> ICC_IGRPEN0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) & ICC_IGRPEN0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static void vgic_v3_access_apr_reg(struct kvm_vcpu *vcpu,
> - struct sys_reg_params *p, u8 apr, u8 idx)
> +static int set_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen1 = (val & ICC_IGRPEN1_EL1_MASK) >> ICC_IGRPEN1_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) & ICC_IGRPEN1_EL1_MASK;
> +
> + return 0;
> +}
> +
> +static void set_apr_reg(struct kvm_vcpu *vcpu, u64 val, u8 apr, u8 idx)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
> - uint32_t *ap_reg;
>
> if (apr)
> - ap_reg = &vgicv3->vgic_ap1r[idx];
> + vgicv3->vgic_ap1r[idx] = val;
> else
> - ap_reg = &vgicv3->vgic_ap0r[idx];
> + vgicv3->vgic_ap0r[idx] = val;
> +}
> +
> +static u64 get_apr_reg(struct kvm_vcpu *vcpu, u8 apr, u8 idx)
> +{
> + struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> - if (p->is_write)
> - *ap_reg = p->regval;
> + if (apr)
> + return vgicv3->vgic_ap1r[idx];
> else
> - p->regval = *ap_reg;
> + return vgicv3->vgic_ap0r[idx];
> +}
> +
> +static int set_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 0, idx);
> + return 0;
> }
>
> -static bool access_gic_aprn(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r, u8 apr)
> +static int get_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> u8 idx = r->Op2 & 3;
>
> if (idx > vgic_v3_max_apr_idx(vcpu))
> - goto err;
> + return -EINVAL;
>
> - vgic_v3_access_apr_reg(vcpu, p, apr, idx);
> - return true;
> -err:
> - if (!p->is_write)
> - p->regval = 0;
> + *val = get_apr_reg(vcpu, 0, idx);
>
> - return false;
> + return 0;
> }
>
> -static bool access_gic_ap0r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 1, idx);
> + return 0;
> +}
>
> +static int get_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> - return access_gic_aprn(vcpu, p, r, 0);
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + *val = get_apr_reg(vcpu, 1, idx);
> +
> + return 0;
> }
>
> -static bool access_gic_ap1r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> - return access_gic_aprn(vcpu, p, r, 1);
> + /* Validate SRE bit */
> + if (!(val & ICC_SRE_EL1_SRE))
> + return -EINVAL;
> +
> + return 0;
> }
>
> -static bool access_gic_sre(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> /* Validate SRE bit */
I don't think this comment is needed here because this
function doesn't validate the bit (I believe the comment
was just for the write case).
Otherwise,
Reviewed-by: Reiji Watanabe <reijiw@google.com>
Thank you,
Reiji
WARNING: multiple messages have this Message-ID (diff)
From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, Schspa Shi <schspa@gmail.com>,
Oliver Upton <oliver.upton@linux.dev>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 09/19] KVM: arm64: vgic-v3: Make the userspace accessors use sysreg API
Date: Tue, 12 Jul 2022 22:21:25 -0700 [thread overview]
Message-ID: <CAAeT=Fz-qGbTQ2PTG6xuS-uo_ANnuxQQt47fy_wP3sdsM10Fgw@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-10-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> The vgic-v3 sysreg accessors have been ignored as the rest of the
> sysreg internal API was avolving, and are stuck with the .access
Nit: s/avolving/evolving/ ?
> method (which is normally reserved to the guest's own access)
> for the userspace accesses (which should use the .set/.get_user()
> methods).
>
> Catch up with the program and repaint all the accessors so that
> they fit into the normal userspace model, and plug the result into
> the helpers that have been introduced earlier.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/vgic-sys-reg-v3.c | 453 ++++++++++++++++++-------------
> 1 file changed, 257 insertions(+), 196 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic-sys-reg-v3.c b/arch/arm64/kvm/vgic-sys-reg-v3.c
> index 8c56e285fde9..2ca172cdc5c4 100644
> --- a/arch/arm64/kvm/vgic-sys-reg-v3.c
> +++ b/arch/arm64/kvm/vgic-sys-reg-v3.c
> @@ -10,254 +10,331 @@
> #include "vgic/vgic.h"
> #include "sys_regs.h"
>
> -static bool access_gic_ctlr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> u32 host_pri_bits, host_id_bits, host_seis, host_a3v, seis, a3v;
> struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> +
> + /*
> + * Disallow restoring VM state if not supported by this
> + * hardware.
> + */
> + host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> + ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> + if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_pri_bits = host_pri_bits;
> +
> + host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> + ICC_CTLR_EL1_ID_BITS_SHIFT;
> + if (host_id_bits > vgic_v3_cpu->num_id_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_id_bits = host_id_bits;
> +
> + host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> + seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + if (host_seis != seis)
> + return -EINVAL;
> +
> + host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> + a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> + if (host_a3v != a3v)
> + return -EINVAL;
> +
> + /*
> + * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> + * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> + */
> + vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> + vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *valp)
> +{
> + struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> + struct vgic_vmcr vmcr;
> u64 val;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - val = p->regval;
> -
> - /*
> - * Disallow restoring VM state if not supported by this
> - * hardware.
> - */
> - host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> - ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> - if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> - return false;
> -
> - vgic_v3_cpu->num_pri_bits = host_pri_bits;
> -
> - host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> - ICC_CTLR_EL1_ID_BITS_SHIFT;
> - if (host_id_bits > vgic_v3_cpu->num_id_bits)
> - return false;
> -
> - vgic_v3_cpu->num_id_bits = host_id_bits;
> -
> - host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> - seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - if (host_seis != seis)
> - return false;
> -
> - host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> - a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> - if (host_a3v != a3v)
> - return false;
> -
> - /*
> - * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> - * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> - */
> - vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> - vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - val = 0;
> - val |= (vgic_v3_cpu->num_pri_bits - 1) <<
> - ICC_CTLR_EL1_PRI_BITS_SHIFT;
> - val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> - ICC_CTLR_EL1_A3V_SHIFT;
> - /*
> - * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> - * Extract it directly using ICC_CTLR_EL1 reg definitions.
> - */
> - val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> - val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> -
> - p->regval = val;
> - }
> + val = 0;
> + val |= (vgic_v3_cpu->num_pri_bits - 1) << ICC_CTLR_EL1_PRI_BITS_SHIFT;
> + val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> + ICC_CTLR_EL1_A3V_SHIFT;
> + /*
> + * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> + * Extract it directly using ICC_CTLR_EL1 reg definitions.
> + */
> + val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> + val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> +
> + *valp = val;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_pmr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.pmr = (p->regval & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
> - }
> + vmcr.pmr = (val & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.bpr = (p->regval & ICC_BPR0_EL1_MASK) >>
> - ICC_BPR0_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) &
> - ICC_BPR0_EL1_MASK;
> - }
> + *val = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> - if (!p->is_write)
> - p->regval = 0;
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.bpr = (val & ICC_BPR0_EL1_MASK) >> ICC_BPR0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (!vmcr.cbpr) {
> - if (p->is_write) {
> - vmcr.abpr = (p->regval & ICC_BPR1_EL1_MASK) >>
> - ICC_BPR1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) &
> - ICC_BPR1_EL1_MASK;
> - }
> - } else {
> - if (!p->is_write)
> - p->regval = min((vmcr.bpr + 1), 7U);
> - }
> + *val = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) & ICC_BPR0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen0 = (p->regval & ICC_IGRPEN0_EL1_MASK) >>
> - ICC_IGRPEN0_EL1_SHIFT;
> + if (!vmcr.cbpr) {
> + vmcr.abpr = (val & ICC_BPR1_EL1_MASK) >> ICC_BPR1_EL1_SHIFT;
> vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) &
> - ICC_IGRPEN0_EL1_MASK;
> }
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen1 = (p->regval & ICC_IGRPEN1_EL1_MASK) >>
> - ICC_IGRPEN1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) &
> - ICC_IGRPEN1_EL1_MASK;
> - }
> + if (!vmcr.cbpr)
> + *val = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) & ICC_BPR1_EL1_MASK;
> + else
> + *val = min((vmcr.bpr + 1), 7U);
> +
> +
> + return 0;
> +}
> +
> +static int set_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen0 = (val & ICC_IGRPEN0_EL1_MASK) >> ICC_IGRPEN0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) & ICC_IGRPEN0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static void vgic_v3_access_apr_reg(struct kvm_vcpu *vcpu,
> - struct sys_reg_params *p, u8 apr, u8 idx)
> +static int set_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen1 = (val & ICC_IGRPEN1_EL1_MASK) >> ICC_IGRPEN1_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) & ICC_IGRPEN1_EL1_MASK;
> +
> + return 0;
> +}
> +
> +static void set_apr_reg(struct kvm_vcpu *vcpu, u64 val, u8 apr, u8 idx)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
> - uint32_t *ap_reg;
>
> if (apr)
> - ap_reg = &vgicv3->vgic_ap1r[idx];
> + vgicv3->vgic_ap1r[idx] = val;
> else
> - ap_reg = &vgicv3->vgic_ap0r[idx];
> + vgicv3->vgic_ap0r[idx] = val;
> +}
> +
> +static u64 get_apr_reg(struct kvm_vcpu *vcpu, u8 apr, u8 idx)
> +{
> + struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> - if (p->is_write)
> - *ap_reg = p->regval;
> + if (apr)
> + return vgicv3->vgic_ap1r[idx];
> else
> - p->regval = *ap_reg;
> + return vgicv3->vgic_ap0r[idx];
> +}
> +
> +static int set_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 0, idx);
> + return 0;
> }
>
> -static bool access_gic_aprn(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r, u8 apr)
> +static int get_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> u8 idx = r->Op2 & 3;
>
> if (idx > vgic_v3_max_apr_idx(vcpu))
> - goto err;
> + return -EINVAL;
>
> - vgic_v3_access_apr_reg(vcpu, p, apr, idx);
> - return true;
> -err:
> - if (!p->is_write)
> - p->regval = 0;
> + *val = get_apr_reg(vcpu, 0, idx);
>
> - return false;
> + return 0;
> }
>
> -static bool access_gic_ap0r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 1, idx);
> + return 0;
> +}
>
> +static int get_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> - return access_gic_aprn(vcpu, p, r, 0);
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + *val = get_apr_reg(vcpu, 1, idx);
> +
> + return 0;
> }
>
> -static bool access_gic_ap1r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> - return access_gic_aprn(vcpu, p, r, 1);
> + /* Validate SRE bit */
> + if (!(val & ICC_SRE_EL1_SRE))
> + return -EINVAL;
> +
> + return 0;
> }
>
> -static bool access_gic_sre(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> /* Validate SRE bit */
I don't think this comment is needed here because this
function doesn't validate the bit (I believe the comment
was just for the write case).
Otherwise,
Reviewed-by: Reiji Watanabe <reijiw@google.com>
Thank you,
Reiji
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Schspa Shi <schspa@gmail.com>,
kernel-team@android.com, Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH 09/19] KVM: arm64: vgic-v3: Make the userspace accessors use sysreg API
Date: Tue, 12 Jul 2022 22:21:25 -0700 [thread overview]
Message-ID: <CAAeT=Fz-qGbTQ2PTG6xuS-uo_ANnuxQQt47fy_wP3sdsM10Fgw@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-10-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> The vgic-v3 sysreg accessors have been ignored as the rest of the
> sysreg internal API was avolving, and are stuck with the .access
Nit: s/avolving/evolving/ ?
> method (which is normally reserved to the guest's own access)
> for the userspace accesses (which should use the .set/.get_user()
> methods).
>
> Catch up with the program and repaint all the accessors so that
> they fit into the normal userspace model, and plug the result into
> the helpers that have been introduced earlier.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/vgic-sys-reg-v3.c | 453 ++++++++++++++++++-------------
> 1 file changed, 257 insertions(+), 196 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic-sys-reg-v3.c b/arch/arm64/kvm/vgic-sys-reg-v3.c
> index 8c56e285fde9..2ca172cdc5c4 100644
> --- a/arch/arm64/kvm/vgic-sys-reg-v3.c
> +++ b/arch/arm64/kvm/vgic-sys-reg-v3.c
> @@ -10,254 +10,331 @@
> #include "vgic/vgic.h"
> #include "sys_regs.h"
>
> -static bool access_gic_ctlr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> u32 host_pri_bits, host_id_bits, host_seis, host_a3v, seis, a3v;
> struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> +
> + /*
> + * Disallow restoring VM state if not supported by this
> + * hardware.
> + */
> + host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> + ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> + if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_pri_bits = host_pri_bits;
> +
> + host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> + ICC_CTLR_EL1_ID_BITS_SHIFT;
> + if (host_id_bits > vgic_v3_cpu->num_id_bits)
> + return -EINVAL;
> +
> + vgic_v3_cpu->num_id_bits = host_id_bits;
> +
> + host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> + seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + if (host_seis != seis)
> + return -EINVAL;
> +
> + host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> + a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> + if (host_a3v != a3v)
> + return -EINVAL;
> +
> + /*
> + * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> + * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> + */
> + vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> + vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_ctlr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *valp)
> +{
> + struct vgic_cpu *vgic_v3_cpu = &vcpu->arch.vgic_cpu;
> + struct vgic_vmcr vmcr;
> u64 val;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - val = p->regval;
> -
> - /*
> - * Disallow restoring VM state if not supported by this
> - * hardware.
> - */
> - host_pri_bits = ((val & ICC_CTLR_EL1_PRI_BITS_MASK) >>
> - ICC_CTLR_EL1_PRI_BITS_SHIFT) + 1;
> - if (host_pri_bits > vgic_v3_cpu->num_pri_bits)
> - return false;
> -
> - vgic_v3_cpu->num_pri_bits = host_pri_bits;
> -
> - host_id_bits = (val & ICC_CTLR_EL1_ID_BITS_MASK) >>
> - ICC_CTLR_EL1_ID_BITS_SHIFT;
> - if (host_id_bits > vgic_v3_cpu->num_id_bits)
> - return false;
> -
> - vgic_v3_cpu->num_id_bits = host_id_bits;
> -
> - host_seis = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT);
> - seis = (val & ICC_CTLR_EL1_SEIS_MASK) >>
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - if (host_seis != seis)
> - return false;
> -
> - host_a3v = ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT);
> - a3v = (val & ICC_CTLR_EL1_A3V_MASK) >> ICC_CTLR_EL1_A3V_SHIFT;
> - if (host_a3v != a3v)
> - return false;
> -
> - /*
> - * Here set VMCR.CTLR in ICC_CTLR_EL1 layout.
> - * The vgic_set_vmcr() will convert to ICH_VMCR layout.
> - */
> - vmcr.cbpr = (val & ICC_CTLR_EL1_CBPR_MASK) >> ICC_CTLR_EL1_CBPR_SHIFT;
> - vmcr.eoim = (val & ICC_CTLR_EL1_EOImode_MASK) >> ICC_CTLR_EL1_EOImode_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - val = 0;
> - val |= (vgic_v3_cpu->num_pri_bits - 1) <<
> - ICC_CTLR_EL1_PRI_BITS_SHIFT;
> - val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> - ICC_CTLR_EL1_SEIS_SHIFT;
> - val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> - ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> - ICC_CTLR_EL1_A3V_SHIFT;
> - /*
> - * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> - * Extract it directly using ICC_CTLR_EL1 reg definitions.
> - */
> - val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> - val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> -
> - p->regval = val;
> - }
> + val = 0;
> + val |= (vgic_v3_cpu->num_pri_bits - 1) << ICC_CTLR_EL1_PRI_BITS_SHIFT;
> + val |= vgic_v3_cpu->num_id_bits << ICC_CTLR_EL1_ID_BITS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_SEIS_MASK) >> ICH_VTR_SEIS_SHIFT) <<
> + ICC_CTLR_EL1_SEIS_SHIFT;
> + val |= ((kvm_vgic_global_state.ich_vtr_el2 &
> + ICH_VTR_A3V_MASK) >> ICH_VTR_A3V_SHIFT) <<
> + ICC_CTLR_EL1_A3V_SHIFT;
> + /*
> + * The VMCR.CTLR value is in ICC_CTLR_EL1 layout.
> + * Extract it directly using ICC_CTLR_EL1 reg definitions.
> + */
> + val |= (vmcr.cbpr << ICC_CTLR_EL1_CBPR_SHIFT) & ICC_CTLR_EL1_CBPR_MASK;
> + val |= (vmcr.eoim << ICC_CTLR_EL1_EOImode_SHIFT) & ICC_CTLR_EL1_EOImode_MASK;
> +
> + *valp = val;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_pmr(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.pmr = (p->regval & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
> - }
> + vmcr.pmr = (val & ICC_PMR_EL1_MASK) >> ICC_PMR_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_pmr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.bpr = (p->regval & ICC_BPR0_EL1_MASK) >>
> - ICC_BPR0_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) &
> - ICC_BPR0_EL1_MASK;
> - }
> + *val = (vmcr.pmr << ICC_PMR_EL1_SHIFT) & ICC_PMR_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_bpr1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> - if (!p->is_write)
> - p->regval = 0;
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.bpr = (val & ICC_BPR0_EL1_MASK) >> ICC_BPR0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_bpr0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (!vmcr.cbpr) {
> - if (p->is_write) {
> - vmcr.abpr = (p->regval & ICC_BPR1_EL1_MASK) >>
> - ICC_BPR1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) &
> - ICC_BPR1_EL1_MASK;
> - }
> - } else {
> - if (!p->is_write)
> - p->regval = min((vmcr.bpr + 1), 7U);
> - }
> + *val = (vmcr.bpr << ICC_BPR0_EL1_SHIFT) & ICC_BPR0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen0(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen0 = (p->regval & ICC_IGRPEN0_EL1_MASK) >>
> - ICC_IGRPEN0_EL1_SHIFT;
> + if (!vmcr.cbpr) {
> + vmcr.abpr = (val & ICC_BPR1_EL1_MASK) >> ICC_BPR1_EL1_SHIFT;
> vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) &
> - ICC_IGRPEN0_EL1_MASK;
> }
>
> - return true;
> + return 0;
> }
>
> -static bool access_gic_grpen1(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_bpr1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_vmcr vmcr;
>
> vgic_get_vmcr(vcpu, &vmcr);
> - if (p->is_write) {
> - vmcr.grpen1 = (p->regval & ICC_IGRPEN1_EL1_MASK) >>
> - ICC_IGRPEN1_EL1_SHIFT;
> - vgic_set_vmcr(vcpu, &vmcr);
> - } else {
> - p->regval = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) &
> - ICC_IGRPEN1_EL1_MASK;
> - }
> + if (!vmcr.cbpr)
> + *val = (vmcr.abpr << ICC_BPR1_EL1_SHIFT) & ICC_BPR1_EL1_MASK;
> + else
> + *val = min((vmcr.bpr + 1), 7U);
> +
> +
> + return 0;
> +}
> +
> +static int set_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen0 = (val & ICC_IGRPEN0_EL1_MASK) >> ICC_IGRPEN0_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen0(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen0 << ICC_IGRPEN0_EL1_SHIFT) & ICC_IGRPEN0_EL1_MASK;
>
> - return true;
> + return 0;
> }
>
> -static void vgic_v3_access_apr_reg(struct kvm_vcpu *vcpu,
> - struct sys_reg_params *p, u8 apr, u8 idx)
> +static int set_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + vmcr.grpen1 = (val & ICC_IGRPEN1_EL1_MASK) >> ICC_IGRPEN1_EL1_SHIFT;
> + vgic_set_vmcr(vcpu, &vmcr);
> +
> + return 0;
> +}
> +
> +static int get_gic_grpen1(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> +{
> + struct vgic_vmcr vmcr;
> +
> + vgic_get_vmcr(vcpu, &vmcr);
> + *val = (vmcr.grpen1 << ICC_IGRPEN1_EL1_SHIFT) & ICC_IGRPEN1_EL1_MASK;
> +
> + return 0;
> +}
> +
> +static void set_apr_reg(struct kvm_vcpu *vcpu, u64 val, u8 apr, u8 idx)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
> - uint32_t *ap_reg;
>
> if (apr)
> - ap_reg = &vgicv3->vgic_ap1r[idx];
> + vgicv3->vgic_ap1r[idx] = val;
> else
> - ap_reg = &vgicv3->vgic_ap0r[idx];
> + vgicv3->vgic_ap0r[idx] = val;
> +}
> +
> +static u64 get_apr_reg(struct kvm_vcpu *vcpu, u8 apr, u8 idx)
> +{
> + struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> - if (p->is_write)
> - *ap_reg = p->regval;
> + if (apr)
> + return vgicv3->vgic_ap1r[idx];
> else
> - p->regval = *ap_reg;
> + return vgicv3->vgic_ap0r[idx];
> +}
> +
> +static int set_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 0, idx);
> + return 0;
> }
>
> -static bool access_gic_aprn(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r, u8 apr)
> +static int get_gic_ap0r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> u8 idx = r->Op2 & 3;
>
> if (idx > vgic_v3_max_apr_idx(vcpu))
> - goto err;
> + return -EINVAL;
>
> - vgic_v3_access_apr_reg(vcpu, p, apr, idx);
> - return true;
> -err:
> - if (!p->is_write)
> - p->regval = 0;
> + *val = get_apr_reg(vcpu, 0, idx);
>
> - return false;
> + return 0;
> }
>
> -static bool access_gic_ap0r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> +
> +{
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + set_apr_reg(vcpu, val, 1, idx);
> + return 0;
> +}
>
> +static int get_gic_ap1r(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> - return access_gic_aprn(vcpu, p, r, 0);
> + u8 idx = r->Op2 & 3;
> +
> + if (idx > vgic_v3_max_apr_idx(vcpu))
> + return -EINVAL;
> +
> + *val = get_apr_reg(vcpu, 1, idx);
> +
> + return 0;
> }
>
> -static bool access_gic_ap1r(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int set_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 val)
> {
> - return access_gic_aprn(vcpu, p, r, 1);
> + /* Validate SRE bit */
> + if (!(val & ICC_SRE_EL1_SRE))
> + return -EINVAL;
> +
> + return 0;
> }
>
> -static bool access_gic_sre(struct kvm_vcpu *vcpu, struct sys_reg_params *p,
> - const struct sys_reg_desc *r)
> +static int get_gic_sre(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
> + u64 *val)
> {
> struct vgic_v3_cpu_if *vgicv3 = &vcpu->arch.vgic_cpu.vgic_v3;
>
> /* Validate SRE bit */
I don't think this comment is needed here because this
function doesn't validate the bit (I believe the comment
was just for the write case).
Otherwise,
Reviewed-by: Reiji Watanabe <reijiw@google.com>
Thank you,
Reiji
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-13 5:21 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:42 [PATCH 00/19] KVM: arm64: vgic-v3 userspace access consolidation (and other goodies) Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 01/19] KVM: arm64: Add get_reg_by_id() as a sys_reg_desc retrieving helper Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 02/19] KVM: arm64: Reorder handling of invariant sysregs from userspace Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-07 4:24 ` Reiji Watanabe
2022-07-07 4:24 ` Reiji Watanabe
2022-07-07 4:24 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 03/19] KVM: arm64: Introduce generic get_user/set_user helpers for system registers Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:20 ` Oliver Upton
2022-07-08 19:20 ` Oliver Upton
2022-07-08 19:20 ` Oliver Upton
2022-07-09 6:59 ` Reiji Watanabe
2022-07-09 6:59 ` Reiji Watanabe
2022-07-09 6:59 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 6:13 ` Reiji Watanabe
2022-07-08 6:13 ` Reiji Watanabe
2022-07-08 6:13 ` Reiji Watanabe
2022-07-08 8:05 ` Marc Zyngier
2022-07-08 8:05 ` Marc Zyngier
2022-07-08 8:05 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 05/19] KVM: arm64: Consolidate sysreg userspace accesses Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:33 ` Oliver Upton
2022-07-08 19:33 ` Oliver Upton
2022-07-08 19:33 ` Oliver Upton
2022-07-09 6:55 ` Reiji Watanabe
2022-07-09 6:55 ` Reiji Watanabe
2022-07-09 6:55 ` Reiji Watanabe
2022-07-12 7:25 ` Marc Zyngier
2022-07-12 7:25 ` Marc Zyngier
2022-07-12 7:25 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 06/19] KVM: arm64: Get rid of reg_from/to_user() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:35 ` Oliver Upton
2022-07-08 19:35 ` Oliver Upton
2022-07-08 19:35 ` Oliver Upton
2022-07-12 4:34 ` Reiji Watanabe
2022-07-12 4:34 ` Reiji Watanabe
2022-07-12 4:34 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 07/19] KVM: arm64: vgic-v3: Simplify vgic_v3_has_cpu_sysregs_attr() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:38 ` Oliver Upton
2022-07-08 19:38 ` Oliver Upton
2022-07-08 19:38 ` Oliver Upton
2022-07-12 5:22 ` Reiji Watanabe
2022-07-12 5:22 ` Reiji Watanabe
2022-07-12 5:22 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 08/19] KVM: arm64: vgic-v3: Push user access into vgic_v3_cpu_sysregs_uaccess() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:52 ` Marc Zyngier
2022-07-12 6:52 ` Marc Zyngier
2022-07-12 6:52 ` Marc Zyngier
2022-07-13 3:26 ` Reiji Watanabe
2022-07-13 3:26 ` Reiji Watanabe
2022-07-13 3:26 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 09/19] KVM: arm64: vgic-v3: Make the userspace accessors use sysreg API Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 5:21 ` Reiji Watanabe [this message]
2022-07-13 5:21 ` Reiji Watanabe
2022-07-13 5:21 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 10/19] KVM: arm64: vgic-v3: Convert userspace accessors over to FIELD_GET/FIELD_PREP Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 5:51 ` Reiji Watanabe
2022-07-13 5:51 ` Reiji Watanabe
2022-07-13 5:51 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 11/19] KVM: arm64: vgic-v3: Use u32 to manage the line level from userspace Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 6:45 ` Reiji Watanabe
2022-07-13 6:45 ` Reiji Watanabe
2022-07-13 6:45 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 12/19] KVM: arm64: vgic-v3: Consolidate userspace access for MMIO registers Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-14 4:11 ` Reiji Watanabe
2022-07-14 4:11 ` Reiji Watanabe
2022-07-14 4:11 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 13/19] KVM: arm64: vgic-v2: " Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 7:09 ` Marc Zyngier
2022-07-14 7:09 ` Marc Zyngier
2022-07-14 7:09 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 14/19] KVM: arm64: vgic: Use {get,put}_user() instead of copy_{from.to}_user Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 14/19] KVM: arm64: vgic: Use {get, put}_user() " Marc Zyngier
2022-07-14 5:09 ` Reiji Watanabe
2022-07-14 5:09 ` Reiji Watanabe
2022-07-14 5:09 ` Reiji Watanabe
2022-07-06 16:43 ` [PATCH 15/19] KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 7:01 ` Marc Zyngier
2022-07-14 7:01 ` Marc Zyngier
2022-07-14 7:01 ` Marc Zyngier
2022-07-15 6:44 ` Reiji Watanabe
2022-07-15 6:44 ` Reiji Watanabe
2022-07-15 6:44 ` Reiji Watanabe
2022-07-06 16:43 ` [PATCH 16/19] KVM: arm64: vgic: Consolidate userspace access for " Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 17/19] KVM: arm64: Get rid of find_reg_by_id() Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 18/19] KVM: arm64: Descope kvm_arm_sys_reg_{get,set}_reg() Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 19/19] KVM: arm64: Get rid or outdated comments Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeT=Fz-qGbTQ2PTG6xuS-uo_ANnuxQQt47fy_wP3sdsM10Fgw@mail.gmail.com' \
--to=reijiw@google.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=schspa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.