From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Schspa Shi <schspa@gmail.com>,
kernel-team@android.com, Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors
Date: Thu, 7 Jul 2022 23:13:36 -0700 [thread overview]
Message-ID: <CAAeT=Fz9+1=EV6fwqVMSncOj_9y7eRuuv1+P92MXbP1GOJeZaA@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-5-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> Make sure the check occurs on every paths where we can pick
> a sysreg from userspace, including the GICv3 paths.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/sys_regs.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 0fbdb21a3600..89e7eddea937 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -2656,6 +2656,10 @@ const struct sys_reg_desc *get_reg_by_id(u64 id,
> {
> struct sys_reg_params params;
>
> + /* 64 bit is the only way */
> + if (KVM_REG_SIZE(id) != sizeof(__u64))
> + return NULL;
This doesn't seem to be necessary since the equivalent check
is done by index_to_params().
Thank you,
Reiji
> +
> if (!index_to_params(id, ¶ms))
> return NULL;
>
> @@ -2871,9 +2875,6 @@ int kvm_arm_sys_reg_get_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_get(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = get_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> @@ -2906,9 +2907,6 @@ int kvm_arm_sys_reg_set_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_set(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = set_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> --
> 2.34.1
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, Schspa Shi <schspa@gmail.com>,
Oliver Upton <oliver.upton@linux.dev>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors
Date: Thu, 7 Jul 2022 23:13:36 -0700 [thread overview]
Message-ID: <CAAeT=Fz9+1=EV6fwqVMSncOj_9y7eRuuv1+P92MXbP1GOJeZaA@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-5-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> Make sure the check occurs on every paths where we can pick
> a sysreg from userspace, including the GICv3 paths.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/sys_regs.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 0fbdb21a3600..89e7eddea937 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -2656,6 +2656,10 @@ const struct sys_reg_desc *get_reg_by_id(u64 id,
> {
> struct sys_reg_params params;
>
> + /* 64 bit is the only way */
> + if (KVM_REG_SIZE(id) != sizeof(__u64))
> + return NULL;
This doesn't seem to be necessary since the equivalent check
is done by index_to_params().
Thank you,
Reiji
> +
> if (!index_to_params(id, ¶ms))
> return NULL;
>
> @@ -2871,9 +2875,6 @@ int kvm_arm_sys_reg_get_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_get(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = get_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> @@ -2906,9 +2907,6 @@ int kvm_arm_sys_reg_set_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_set(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = set_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> --
> 2.34.1
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Reiji Watanabe <reijiw@google.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Schspa Shi <schspa@gmail.com>,
kernel-team@android.com, Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors
Date: Thu, 7 Jul 2022 23:13:36 -0700 [thread overview]
Message-ID: <CAAeT=Fz9+1=EV6fwqVMSncOj_9y7eRuuv1+P92MXbP1GOJeZaA@mail.gmail.com> (raw)
In-Reply-To: <20220706164304.1582687-5-maz@kernel.org>
Hi Marc,
On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier <maz@kernel.org> wrote:
>
> Make sure the check occurs on every paths where we can pick
> a sysreg from userspace, including the GICv3 paths.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> arch/arm64/kvm/sys_regs.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 0fbdb21a3600..89e7eddea937 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -2656,6 +2656,10 @@ const struct sys_reg_desc *get_reg_by_id(u64 id,
> {
> struct sys_reg_params params;
>
> + /* 64 bit is the only way */
> + if (KVM_REG_SIZE(id) != sizeof(__u64))
> + return NULL;
This doesn't seem to be necessary since the equivalent check
is done by index_to_params().
Thank you,
Reiji
> +
> if (!index_to_params(id, ¶ms))
> return NULL;
>
> @@ -2871,9 +2875,6 @@ int kvm_arm_sys_reg_get_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_get(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = get_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> @@ -2906,9 +2907,6 @@ int kvm_arm_sys_reg_set_reg(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg
> if ((reg->id & KVM_REG_ARM_COPROC_MASK) == KVM_REG_ARM_DEMUX)
> return demux_c15_set(reg->id, uaddr);
>
> - if (KVM_REG_SIZE(reg->id) != sizeof(__u64))
> - return -ENOENT;
> -
> err = set_invariant_sys_reg(reg->id, uaddr);
> if (err != -ENOENT)
> return err;
> --
> 2.34.1
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-08 6:13 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 16:42 [PATCH 00/19] KVM: arm64: vgic-v3 userspace access consolidation (and other goodies) Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 01/19] KVM: arm64: Add get_reg_by_id() as a sys_reg_desc retrieving helper Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 4:05 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-07 5:16 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 02/19] KVM: arm64: Reorder handling of invariant sysregs from userspace Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-07 4:24 ` Reiji Watanabe
2022-07-07 4:24 ` Reiji Watanabe
2022-07-07 4:24 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 03/19] KVM: arm64: Introduce generic get_user/set_user helpers for system registers Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:20 ` Oliver Upton
2022-07-08 19:20 ` Oliver Upton
2022-07-08 19:20 ` Oliver Upton
2022-07-09 6:59 ` Reiji Watanabe
2022-07-09 6:59 ` Reiji Watanabe
2022-07-09 6:59 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 6:13 ` Reiji Watanabe [this message]
2022-07-08 6:13 ` Reiji Watanabe
2022-07-08 6:13 ` Reiji Watanabe
2022-07-08 8:05 ` Marc Zyngier
2022-07-08 8:05 ` Marc Zyngier
2022-07-08 8:05 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 05/19] KVM: arm64: Consolidate sysreg userspace accesses Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:33 ` Oliver Upton
2022-07-08 19:33 ` Oliver Upton
2022-07-08 19:33 ` Oliver Upton
2022-07-09 6:55 ` Reiji Watanabe
2022-07-09 6:55 ` Reiji Watanabe
2022-07-09 6:55 ` Reiji Watanabe
2022-07-12 7:25 ` Marc Zyngier
2022-07-12 7:25 ` Marc Zyngier
2022-07-12 7:25 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 06/19] KVM: arm64: Get rid of reg_from/to_user() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:35 ` Oliver Upton
2022-07-08 19:35 ` Oliver Upton
2022-07-08 19:35 ` Oliver Upton
2022-07-12 4:34 ` Reiji Watanabe
2022-07-12 4:34 ` Reiji Watanabe
2022-07-12 4:34 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 07/19] KVM: arm64: vgic-v3: Simplify vgic_v3_has_cpu_sysregs_attr() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-08 19:38 ` Oliver Upton
2022-07-08 19:38 ` Oliver Upton
2022-07-08 19:38 ` Oliver Upton
2022-07-12 5:22 ` Reiji Watanabe
2022-07-12 5:22 ` Reiji Watanabe
2022-07-12 5:22 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 08/19] KVM: arm64: vgic-v3: Push user access into vgic_v3_cpu_sysregs_uaccess() Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:11 ` Reiji Watanabe
2022-07-12 6:52 ` Marc Zyngier
2022-07-12 6:52 ` Marc Zyngier
2022-07-12 6:52 ` Marc Zyngier
2022-07-13 3:26 ` Reiji Watanabe
2022-07-13 3:26 ` Reiji Watanabe
2022-07-13 3:26 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 09/19] KVM: arm64: vgic-v3: Make the userspace accessors use sysreg API Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 5:21 ` Reiji Watanabe
2022-07-13 5:21 ` Reiji Watanabe
2022-07-13 5:21 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 10/19] KVM: arm64: vgic-v3: Convert userspace accessors over to FIELD_GET/FIELD_PREP Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 5:51 ` Reiji Watanabe
2022-07-13 5:51 ` Reiji Watanabe
2022-07-13 5:51 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 11/19] KVM: arm64: vgic-v3: Use u32 to manage the line level from userspace Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-13 6:45 ` Reiji Watanabe
2022-07-13 6:45 ` Reiji Watanabe
2022-07-13 6:45 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 12/19] KVM: arm64: vgic-v3: Consolidate userspace access for MMIO registers Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-14 4:11 ` Reiji Watanabe
2022-07-14 4:11 ` Reiji Watanabe
2022-07-14 4:11 ` Reiji Watanabe
2022-07-06 16:42 ` [PATCH 13/19] KVM: arm64: vgic-v2: " Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 4:43 ` Reiji Watanabe
2022-07-14 7:09 ` Marc Zyngier
2022-07-14 7:09 ` Marc Zyngier
2022-07-14 7:09 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 14/19] KVM: arm64: vgic: Use {get,put}_user() instead of copy_{from.to}_user Marc Zyngier
2022-07-06 16:42 ` Marc Zyngier
2022-07-06 16:42 ` [PATCH 14/19] KVM: arm64: vgic: Use {get, put}_user() " Marc Zyngier
2022-07-14 5:09 ` Reiji Watanabe
2022-07-14 5:09 ` Reiji Watanabe
2022-07-14 5:09 ` Reiji Watanabe
2022-07-06 16:43 ` [PATCH 15/19] KVM: arm64: vgic-v2: Add helper for legacy dist/cpuif base address setting Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 6:37 ` Reiji Watanabe
2022-07-14 7:01 ` Marc Zyngier
2022-07-14 7:01 ` Marc Zyngier
2022-07-14 7:01 ` Marc Zyngier
2022-07-15 6:44 ` Reiji Watanabe
2022-07-15 6:44 ` Reiji Watanabe
2022-07-15 6:44 ` Reiji Watanabe
2022-07-06 16:43 ` [PATCH 16/19] KVM: arm64: vgic: Consolidate userspace access for " Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 17/19] KVM: arm64: Get rid of find_reg_by_id() Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 18/19] KVM: arm64: Descope kvm_arm_sys_reg_{get,set}_reg() Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` [PATCH 19/19] KVM: arm64: Get rid or outdated comments Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
2022-07-06 16:43 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeT=Fz9+1=EV6fwqVMSncOj_9y7eRuuv1+P92MXbP1GOJeZaA@mail.gmail.com' \
--to=reijiw@google.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=schspa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.