From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka <vbabka@suse.cz> Cc: kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org, Linux Memory Management List <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com> Subject: Re: [linux-next:master 7012/7430] include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_183' declared with attribute error: unexpected size in kmalloc_index() Date: Sat, 12 Jun 2021 09:19:05 +0900 [thread overview] Message-ID: <CAB=+i9SbDgMJSo91Wt4ZfkgWW3+8R49_7Uhn5FCbBXt-SX+osg@mail.gmail.com> (raw) In-Reply-To: <ab90e117-6457-bf01-fdce-9682e972ed27@suse.cz> [-- Attachment #1: Type: text/plain, Size: 1640 bytes --] On Sat, Jun 12, 2021, 8:59 AM Vlastimil Babka <vbabka@suse.cz> wrote: > On 6/11/21 1:56 PM, Hyeonggon Yoo wrote: > > On Fri, Jun 11, 2021, 7:27 PM Vlastimil Babka <vbabka@suse.cz > > <mailto:vbabka@suse.cz>> wrote: > > I meant the the condition to use BUILD_BUG_ON instead of BUG_ON > would include > > !IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES) > > > > > > You mean this? (This will make kmalloc_index return -1 without BUG()) > > > > if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION >= 110000) && > > size_is_constant) > > BUILD_BUG_ON_MSG(!IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES), > "unexpected > > size in kmalloc_index()"); > > else > > BUG(); > > No, > > > Or This? > > > > if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION >= 110000) && > > size_is_constant && !IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES)) > > BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()"); > > else > > BUG(); > > > > Maybe this version seems better > > Yeah, meant that. > Ah, okay! > > But little bit worried :( > > The code is getting too complicated... > > How do you think? > > Yeah, I expected that problems like this could occur as we're poking at > some > rare corner cases of compiler implementations here. But if that leads to > fixes > in compilers, good for everyone I'd say. So I would try this, even if it becomes complicated. > Okay, I see the code is okay, but one thing to suggest: The problem already existed in kmalloc_node before the patch And we found it by adding BUILD_BUG_ON in kmalloc_index. So I suggest adding the condition in kmalloc_node. How about this? > [-- Attachment #2: Type: text/html, Size: 3014 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 7012/7430] include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_183' declared with attribute error: unexpected size in kmalloc_index() Date: Sat, 12 Jun 2021 09:19:05 +0900 [thread overview] Message-ID: <CAB=+i9SbDgMJSo91Wt4ZfkgWW3+8R49_7Uhn5FCbBXt-SX+osg@mail.gmail.com> (raw) In-Reply-To: <ab90e117-6457-bf01-fdce-9682e972ed27@suse.cz> [-- Attachment #1: Type: text/plain, Size: 1698 bytes --] On Sat, Jun 12, 2021, 8:59 AM Vlastimil Babka <vbabka@suse.cz> wrote: > On 6/11/21 1:56 PM, Hyeonggon Yoo wrote: > > On Fri, Jun 11, 2021, 7:27 PM Vlastimil Babka <vbabka@suse.cz > > <mailto:vbabka@suse.cz>> wrote: > > I meant the the condition to use BUILD_BUG_ON instead of BUG_ON > would include > > !IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES) > > > > > > You mean this? (This will make kmalloc_index return -1 without BUG()) > > > > if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION >= 110000) && > > size_is_constant) > > BUILD_BUG_ON_MSG(!IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES), > "unexpected > > size in kmalloc_index()"); > > else > > BUG(); > > No, > > > Or This? > > > > if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION >= 110000) && > > size_is_constant && !IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES)) > > BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()"); > > else > > BUG(); > > > > Maybe this version seems better > > Yeah, meant that. > Ah, okay! > > But little bit worried :( > > The code is getting too complicated... > > How do you think? > > Yeah, I expected that problems like this could occur as we're poking at > some > rare corner cases of compiler implementations here. But if that leads to > fixes > in compilers, good for everyone I'd say. So I would try this, even if it becomes complicated. > Okay, I see the code is okay, but one thing to suggest: The problem already existed in kmalloc_node before the patch And we found it by adding BUILD_BUG_ON in kmalloc_index. So I suggest adding the condition in kmalloc_node. How about this? > [-- Attachment #2: attachment.htm --] [-- Type: text/html, Size: 2976 bytes --]
next prev parent reply other threads:[~2021-06-12 0:19 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-05 6:10 [linux-next:master 7012/7430] include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_183' declared with attribute error: unexpected size in kmalloc_index() kernel test robot 2021-06-05 6:10 ` kernel test robot 2021-06-06 11:08 ` Hyeonggon Yoo 2021-06-06 11:08 ` Hyeonggon Yoo 2021-06-07 11:40 ` Vlastimil Babka 2021-06-07 11:40 ` Vlastimil Babka 2021-06-07 12:25 ` Hyeonggon Yoo 2021-06-07 12:25 ` Hyeonggon Yoo 2021-06-07 15:27 ` Vlastimil Babka 2021-06-07 15:27 ` Vlastimil Babka 2021-06-07 15:49 ` Hyeonggon Yoo 2021-06-07 15:49 ` Hyeonggon Yoo 2021-06-08 7:57 ` Vlastimil Babka 2021-06-08 7:57 ` Vlastimil Babka 2021-06-08 17:05 ` Hyeonggon Yoo 2021-06-08 17:05 ` Hyeonggon Yoo 2021-06-08 17:27 ` Vlastimil Babka 2021-06-08 17:27 ` Vlastimil Babka 2021-06-08 18:45 ` Hyeonggon Yoo 2021-06-08 18:45 ` Hyeonggon Yoo 2021-06-08 18:50 ` Hyeonggon Yoo 2021-06-08 18:50 ` Hyeonggon Yoo 2021-06-10 5:17 ` Some logical errors on my words, but I still wonder Hyeonggon Yoo 2021-06-10 5:17 ` Hyeonggon Yoo 2021-06-10 11:43 ` [linux-next:master 7012/7430] include/linux/compiler_types.h:328:38: error: call to '__compiletime_assert_183' declared with attribute error: unexpected size in kmalloc_index() Vlastimil Babka 2021-06-10 11:43 ` Vlastimil Babka 2021-06-11 8:58 ` Hyeonggon Yoo 2021-06-11 10:27 ` Vlastimil Babka 2021-06-11 11:56 ` Hyeonggon Yoo 2021-06-11 23:59 ` Vlastimil Babka 2021-06-11 23:59 ` Vlastimil Babka 2021-06-12 0:19 ` Hyeonggon Yoo [this message] 2021-06-12 0:19 ` Hyeonggon Yoo 2021-06-14 9:26 ` [PATCH FIX -next] " Vlastimil Babka 2021-06-14 9:26 ` Vlastimil Babka 2021-06-11 16:56 ` Nathan Chancellor 2021-06-11 16:56 ` Nathan Chancellor 2021-06-12 0:31 ` Hyeonggon Yoo 2021-06-12 0:31 ` Hyeonggon Yoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAB=+i9SbDgMJSo91Wt4ZfkgWW3+8R49_7Uhn5FCbBXt-SX+osg@mail.gmail.com' \ --to=42.hyeyoo@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.