From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/i915: creating Haswell rc6 function
Date: Tue, 26 Mar 2013 13:32:51 -0300 [thread overview]
Message-ID: <CABVU7+v8A0oik+ExBP_g4sRtAwRteO8pJo=VBZxeWECrf0T36Q@mail.gmail.com> (raw)
In-Reply-To: <CAKMK7uFNK4ZTgY87fsJPnLBTtEKdAsTQLBcaibDXJ+QQz2G_Rw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1367 bytes --]
ah... got your point...
I just split later because Ben wanted the frequency patch as the first one
so I decided to let split at last patch to be really optional...
so, you suggestion is to revert the order of this two latest patches or the
3?
I guess frequency one was already queued right?
On Tue, Mar 26, 2013 at 1:30 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Mar 26, 2013 at 5:25 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com>
> wrote:
> > I just checked the code and this patch looks right for me.
> > it doesn't add any if block... just remove them.
> > What am I missing?
>
> You've added it right in the previous patch ;-)
>
> Which means if someone tries to understand the history of a given
> piece of code with git blame, they now have to jump through these 2
> patches which change nothing and are right following each another. But
> in the usual recursive git blame mode you don't see that (or at least
> I don't check for that by default), so you end up reading both patches
> to make sure you still see where the code is moving around.
>
> So if you want to split (and I agree that it starts to make sense),
> pls split first, then apply hsw changes to the hsw rps code only.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
[-- Attachment #1.2: Type: text/html, Size: 2224 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-03-26 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 20:55 [PATCH 0/4] HSW PM - RC6 fixes, clean up and split Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 1/4] drm/i915: HSW PM Frequency bits fix Rodrigo Vivi
2013-03-25 22:15 ` Ben Widawsky
2013-03-26 8:04 ` Daniel Vetter
2013-03-25 20:55 ` [PATCH 2/4] drm/i915: HSW PM Cleaning - Removing unecessary register/bits set Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 3/4] drm/i915: HSW PM - removing pcode read/write Rodrigo Vivi
2013-03-26 8:02 ` Daniel Vetter
2013-03-26 16:30 ` Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 4/4] drm/i915: creating Haswell rc6 function Rodrigo Vivi
2013-03-26 8:05 ` Daniel Vetter
2013-03-26 13:54 ` Rodrigo Vivi
2013-03-26 16:25 ` Rodrigo Vivi
2013-03-26 16:30 ` Daniel Vetter
2013-03-26 16:32 ` Rodrigo Vivi [this message]
2013-03-26 19:00 ` Daniel Vetter
2013-03-26 19:32 ` Rodrigo Vivi
2013-03-26 19:37 ` Rodrigo Vivi
2013-03-26 19:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABVU7+v8A0oik+ExBP_g4sRtAwRteO8pJo=VBZxeWECrf0T36Q@mail.gmail.com' \
--to=rodrigo.vivi@gmail.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.