From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/i915: creating Haswell rc6 function
Date: Tue, 26 Mar 2013 20:49:02 +0100 [thread overview]
Message-ID: <CAKMK7uEWM5BHvS7QHGtdzHtW0OZKO+E8sj6mxUUyqaWEfyz=WQ@mail.gmail.com> (raw)
In-Reply-To: <CABVU7+uVp0CpMYb1KzCKTKZ3Rokh_6p6_w5c_UWmNKex5EZu3g@mail.gmail.com>
On Tue, Mar 26, 2013 at 8:37 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> I forgot to say that I tested patch by patch today on my HSW ULT and just
> noticed real improvement with the patch you already queued.
>
> Where improvements are: at least 0.2W and also less oscillation and more %
> on RC and package C states.
Cool!
> Although I'd like to see the rest of the series applied to have the code as
> clean, organized and matching documentation as possible.
Yeah, sounds like a good plan (at least for hsw).
> On Tue, Mar 26, 2013 at 4:32 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com>
> wrote:
>>
>> I'm in favor of this revert. Although I don't have any argument in values,
>> I always guessed that many of rc6 bugs we have on snb came from the gap
>> between the threashold values used and documented for snb.
The reason I'm still wary is that this helped (according to multiple
people) to more reliably enter rc6. It might be that we've simply
mixed up other rc6 issues and hangs here (or that it's just as flaky
as it seems), but for snb/ivb we need to be careful.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-03-26 19:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 20:55 [PATCH 0/4] HSW PM - RC6 fixes, clean up and split Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 1/4] drm/i915: HSW PM Frequency bits fix Rodrigo Vivi
2013-03-25 22:15 ` Ben Widawsky
2013-03-26 8:04 ` Daniel Vetter
2013-03-25 20:55 ` [PATCH 2/4] drm/i915: HSW PM Cleaning - Removing unecessary register/bits set Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 3/4] drm/i915: HSW PM - removing pcode read/write Rodrigo Vivi
2013-03-26 8:02 ` Daniel Vetter
2013-03-26 16:30 ` Rodrigo Vivi
2013-03-25 20:55 ` [PATCH 4/4] drm/i915: creating Haswell rc6 function Rodrigo Vivi
2013-03-26 8:05 ` Daniel Vetter
2013-03-26 13:54 ` Rodrigo Vivi
2013-03-26 16:25 ` Rodrigo Vivi
2013-03-26 16:30 ` Daniel Vetter
2013-03-26 16:32 ` Rodrigo Vivi
2013-03-26 19:00 ` Daniel Vetter
2013-03-26 19:32 ` Rodrigo Vivi
2013-03-26 19:37 ` Rodrigo Vivi
2013-03-26 19:49 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uEWM5BHvS7QHGtdzHtW0OZKO+E8sj6mxUUyqaWEfyz=WQ@mail.gmail.com' \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.