Re: [PATCH 4/4] drm/i915: creating Haswell rc6 function

From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/i915: creating Haswell rc6 function
Date: Tue, 26 Mar 2013 17:30:12 +0100	[thread overview]
Message-ID: <CAKMK7uFNK4ZTgY87fsJPnLBTtEKdAsTQLBcaibDXJ+QQz2G_Rw@mail.gmail.com> (raw)
In-Reply-To: <CABVU7+sV5cJTX_6z-tpR1LKSyjE-wCtigi2rkMjC5p4sfOjoow@mail.gmail.com>

On Tue, Mar 26, 2013 at 5:25 PM, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> I just checked the code and this patch looks right for me.
> it doesn't add any if block... just remove them.
> What am I missing?

You've added it right in the previous patch ;-)

Which means if someone tries to understand the history of a given
piece of code with git blame, they now have to jump through these 2
patches which change nothing and are right following each another. But
in the usual recursive git blame mode you don't see that (or at least
I don't check for that by default), so you end up reading both patches
to make sure you still see where the code is moving around.

So if you want to split (and I agree that it starts to make sense),
pls split first, then apply hsw changes to the hsw rps code only.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch