From: Jassi Brar <jassisinghbrar@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Heiko Stübner" <heiko@sntech.de>,
frank.wang@rock-chips.com, khilman@baylibre.com,
linux-amlogic@lists.infradead.org,
"Caesar Wang" <wxt@rock-chips.com>
Subject: Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit
Date: Mon, 4 Jul 2016 20:55:50 +0530 [thread overview]
Message-ID: <CABb+yY0Wnqz9sHq5cq-HM0PnaoQEGZD4h3OFTrxNXFY-v5g_4w@mail.gmail.com> (raw)
In-Reply-To: <CABb+yY3mD3chLtM02a5NvOO_HF2JAeu-SELkxzTxkkf5i+Bftg@mail.gmail.com>
On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> My main question is : do you really want to transform this simple driver into
>> a dirty multi-bus generic mailbox driver ?
>> The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu driver.
>>
>> I'll personally push to have two separate drivers here.
>>
> It is a shame if we need to copy a driver only due to changed register
> offsets. Let me give it a shot and see how worse off we would be.
>
OK, so I trimmed the differences further but it still doesn't look any
better. The best approach seems to be have a separate driver but with
consideration that its a 3rd party IP and hence likely to be used by
other platforms. That is, call it something meson-neutral. I will make
a few comments on the patch post.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit
Date: Mon, 4 Jul 2016 20:55:50 +0530 [thread overview]
Message-ID: <CABb+yY0Wnqz9sHq5cq-HM0PnaoQEGZD4h3OFTrxNXFY-v5g_4w@mail.gmail.com> (raw)
In-Reply-To: <CABb+yY3mD3chLtM02a5NvOO_HF2JAeu-SELkxzTxkkf5i+Bftg@mail.gmail.com>
On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> My main question is : do you really want to transform this simple driver into
>> a dirty multi-bus generic mailbox driver ?
>> The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu driver.
>>
>> I'll personally push to have two separate drivers here.
>>
> It is a shame if we need to copy a driver only due to changed register
> offsets. Let me give it a shot and see how worse off we would be.
>
OK, so I trimmed the differences further but it still doesn't look any
better. The best approach seems to be have a separate driver but with
consideration that its a 3rd party IP and hence likely to be used by
other platforms. That is, call it something meson-neutral. I will make
a few comments on the patch post.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit
Date: Mon, 4 Jul 2016 20:55:50 +0530 [thread overview]
Message-ID: <CABb+yY0Wnqz9sHq5cq-HM0PnaoQEGZD4h3OFTrxNXFY-v5g_4w@mail.gmail.com> (raw)
In-Reply-To: <CABb+yY3mD3chLtM02a5NvOO_HF2JAeu-SELkxzTxkkf5i+Bftg@mail.gmail.com>
On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> My main question is : do you really want to transform this simple driver into
>> a dirty multi-bus generic mailbox driver ?
>> The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu driver.
>>
>> I'll personally push to have two separate drivers here.
>>
> It is a shame if we need to copy a driver only due to changed register
> offsets. Let me give it a shot and see how worse off we would be.
>
OK, so I trimmed the differences further but it still doesn't look any
better. The best approach seems to be have a separate driver but with
consideration that its a 3rd party IP and hence likely to be used by
other platforms. That is, call it something meson-neutral. I will make
a few comments on the patch post.
Thanks
next prev parent reply other threads:[~2016-07-04 15:25 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 10:02 [RFC PATCH v2 0/9] scpi: Add SCPI registry to handle legacy protocol Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-22 4:31 ` Jassi Brar
2016-06-22 4:31 ` Jassi Brar
2016-06-22 4:31 ` Jassi Brar
2016-06-23 12:50 ` Neil Armstrong
2016-06-23 12:50 ` Neil Armstrong
2016-06-23 12:50 ` Neil Armstrong
2016-06-23 15:46 ` Neil Armstrong
2016-06-23 15:46 ` Neil Armstrong
2016-06-23 15:46 ` Neil Armstrong
2016-06-25 17:50 ` Jassi Brar
2016-06-25 17:50 ` Jassi Brar
2016-06-25 17:50 ` Jassi Brar
2016-06-28 14:00 ` Neil Armstrong
2016-06-28 14:00 ` Neil Armstrong
2016-06-28 14:00 ` Neil Armstrong
2016-06-28 15:06 ` Jassi Brar
2016-06-28 15:06 ` Jassi Brar
2016-06-28 15:06 ` Jassi Brar
2016-07-04 15:25 ` Jassi Brar [this message]
2016-07-04 15:25 ` Jassi Brar
2016-07-04 15:25 ` Jassi Brar
2016-07-04 15:38 ` Jassi Brar
2016-07-04 15:38 ` Jassi Brar
2016-07-04 15:38 ` Jassi Brar
2016-07-06 13:17 ` Neil Armstrong
2016-07-06 13:17 ` Neil Armstrong
2016-07-06 13:17 ` Neil Armstrong
2016-07-07 4:27 ` Jassi Brar
2016-07-07 4:27 ` Jassi Brar
2016-07-07 4:27 ` Jassi Brar
2016-06-21 10:02 ` [RFC PATCH v2 2/9] dt-bindings: mailbox: Add Amlogic Meson MHU Bindings Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 3/9] ARM64: dts: meson-gxbb: Add Meson MHU Node Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 4/9] firmware: Add a SCPI registry to handle multiple implementations Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 5/9] firmware: scpi: Switch arm_scpi to use new registry Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 6/9] firmware: Add legacy SCPI protocol driver Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-30 10:53 ` Sudeep Holla
2016-06-30 10:53 ` Sudeep Holla
2016-06-30 10:53 ` Sudeep Holla
2016-07-19 9:17 ` Neil Armstrong
2016-07-19 9:17 ` Neil Armstrong
2016-07-19 9:17 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 7/9] dt-bindings: arm: Update arm,scpi bindings with Meson GXBB SCPI Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 7/9] dt-bindings: arm: Update arm, scpi " Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 8/9] ARM64: dts: meson-gxbb: Add SRAM node Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` [RFC PATCH v2 9/9] ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-21 10:02 ` Neil Armstrong
2016-06-22 2:54 ` [RFC PATCH v2 0/9] scpi: Add SCPI registry to handle legacy protocol Frank Wang
2016-06-22 2:54 ` Frank Wang
2016-06-22 2:54 ` Frank Wang
2016-06-23 12:45 ` Neil Armstrong
2016-06-23 12:45 ` Neil Armstrong
2016-06-23 12:45 ` Neil Armstrong
2016-06-24 2:31 ` Frank Wang
2016-06-24 2:31 ` Frank Wang
2016-06-24 2:31 ` Frank Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY0Wnqz9sHq5cq-HM0PnaoQEGZD4h3OFTrxNXFY-v5g_4w@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=frank.wang@rock-chips.com \
--cc=heiko@sntech.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sudeep.holla@arm.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.