From: Matthew Garrett <mjg59@google.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
selinux@tycho.nsa.gov, Casey Schaufler <casey@schaufler-ca.com>,
LSM List <linux-security-module@vger.kernel.org>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Subject: Re: [PATCH V3 2/2] IMA: Support using new creds in appraisal policy
Date: Fri, 15 Dec 2017 14:35:56 -0800 [thread overview]
Message-ID: <CACdnJuvwFOeOfVqYux+nw8n7qM=VLRFk6cK4HhQe13WCoHwvtA@mail.gmail.com> (raw)
In-Reply-To: <CACdnJuu4cA0rAeejNd5hzgZZt+nAYF4-_v55Roib_oHexo2r8w@mail.gmail.com>
On Fri, Dec 15, 2017 at 2:24 PM, Matthew Garrett <mjg59@google.com> wrote:
> Hm, sorry, missed this mail.
>
> On Tue, Nov 28, 2017 at 2:33 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
>> On Tue, 2017-11-28 at 13:37 -0800, Matthew Garrett wrote:
>>> security_task_getsecid(current) will give the same results as
>>> security_cred_getsecid(current_creds())
>>
>> Unwinding security_task_getsecid(current) looks like it is using
>> real_cred, while current_cred() is using cred.
>
> Good question, and there's a current_real_cred() macro, so I should
> just use that instead.
Hm. Actually, I'm not sure. For most checks we were using cred, and
only using real_cred for the secid lookup. This feels somewhat
inconsistent.
WARNING: multiple messages have this Message-ID (diff)
From: mjg59@google.com (Matthew Garrett)
To: linux-security-module@vger.kernel.org
Subject: [PATCH V3 2/2] IMA: Support using new creds in appraisal policy
Date: Fri, 15 Dec 2017 14:35:56 -0800 [thread overview]
Message-ID: <CACdnJuvwFOeOfVqYux+nw8n7qM=VLRFk6cK4HhQe13WCoHwvtA@mail.gmail.com> (raw)
In-Reply-To: <CACdnJuu4cA0rAeejNd5hzgZZt+nAYF4-_v55Roib_oHexo2r8w@mail.gmail.com>
On Fri, Dec 15, 2017 at 2:24 PM, Matthew Garrett <mjg59@google.com> wrote:
> Hm, sorry, missed this mail.
>
> On Tue, Nov 28, 2017 at 2:33 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
>> On Tue, 2017-11-28 at 13:37 -0800, Matthew Garrett wrote:
>>> security_task_getsecid(current) will give the same results as
>>> security_cred_getsecid(current_creds())
>>
>> Unwinding security_task_getsecid(current) looks like it is using
>> real_cred, while current_cred() is using cred.
>
> Good question, and there's a current_real_cred() macro, so I should
> just use that instead.
Hm. Actually, I'm not sure. For most checks we were using cred, and
only using real_cred for the secid lookup. This feels somewhat
inconsistent.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-15 22:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:40 [PATCH V3 1/2] security: Add a cred_getsecid hook Matthew Garrett
2017-10-26 8:40 ` Matthew Garrett
2017-10-26 8:40 ` [PATCH V3 2/2] IMA: Support using new creds in appraisal policy Matthew Garrett
2017-10-26 8:40 ` Matthew Garrett
2017-10-26 9:11 ` James Morris
2017-10-26 9:11 ` James Morris
2017-11-28 20:48 ` Mimi Zohar
2017-11-28 20:48 ` Mimi Zohar
2017-11-28 20:48 ` Mimi Zohar
2017-11-28 21:22 ` Matthew Garrett
2017-11-28 21:22 ` Matthew Garrett
2017-11-28 21:35 ` Mimi Zohar
2017-11-28 21:35 ` Mimi Zohar
2017-11-28 21:35 ` Mimi Zohar
2017-11-28 21:37 ` Matthew Garrett
2017-11-28 21:37 ` Matthew Garrett
2017-11-28 22:33 ` Mimi Zohar
2017-11-28 22:33 ` Mimi Zohar
2017-12-15 22:24 ` Matthew Garrett
2017-12-15 22:24 ` Matthew Garrett
2017-12-15 22:35 ` Matthew Garrett [this message]
2017-12-15 22:35 ` Matthew Garrett
2017-12-18 15:39 ` Mimi Zohar
2017-12-18 15:39 ` Mimi Zohar
2017-12-18 15:39 ` Mimi Zohar
2017-10-26 9:04 ` [PATCH V3 1/2] security: Add a cred_getsecid hook James Morris
2017-10-26 9:04 ` James Morris
2017-10-26 13:21 ` Casey Schaufler
2017-10-26 13:21 ` Casey Schaufler
2017-10-30 10:54 ` Matthew Garrett
2017-10-30 10:54 ` Matthew Garrett
2017-10-26 14:20 ` Stephen Smalley
2017-10-26 14:20 ` Stephen Smalley
2017-10-26 14:20 ` Stephen Smalley
2017-10-30 10:57 ` Matthew Garrett
2017-10-30 10:57 ` Matthew Garrett
2017-10-30 17:03 ` Stephen Smalley
2017-10-30 17:03 ` Stephen Smalley
2017-10-30 17:03 ` Stephen Smalley
2017-11-14 19:42 ` Matthew Garrett
2017-11-14 19:42 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACdnJuvwFOeOfVqYux+nw8n7qM=VLRFk6cK4HhQe13WCoHwvtA@mail.gmail.com' \
--to=mjg59@google.com \
--cc=casey@schaufler-ca.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.