From: Daniel Drake <drake@endlessm.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com>,
Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection
Date: Thu, 9 May 2019 14:08:38 +0800 [thread overview]
Message-ID: <CAD8Lp46tCfi3ZCmmXZv3-ZDbon+6P8qC4GPR9Bt3uFFr=Sn4Cw@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfMXAyUpWTrEHnv1NcQcHch+RHehWYTjk6KMTbXbtppPg@mail.gmail.com>
> > -#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS */
> > -#define ASUS_WMI_METHODID_DSTS2 0x53545344 /* Device STatuS #2*/
>
> > +#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS (DCTS) */
>
> It's not clear from the description what 'C' stands for.
> Is there any specification which describes the difference and actual
> abbreviations?
The (recent) spec I have here doesn't mention 0x53544344 (DCTS).
However the spec changelog does mention that EEEPC stuff was removed
from the spec a while ago.
The spec does mention 0x53545344 (DSTS), labelled as "Get device status".
For clarity I think the constants could be renamed as
ASUS_WMI_METHODID_DCTS and ASUS_WMI_METHODID_DSTS.
Daniel
next prev parent reply other threads:[~2019-05-09 6:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:57 [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Yurii Pavlovskyi
2019-04-19 9:57 ` Yurii Pavlovskyi
2019-04-19 10:00 ` [PATCH v3 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup Yurii Pavlovskyi
2019-04-19 10:00 ` Yurii Pavlovskyi
2019-05-08 13:25 ` Andy Shevchenko
2019-04-19 10:03 ` [PATCH v3 02/11] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load Yurii Pavlovskyi
2019-04-19 10:03 ` Yurii Pavlovskyi
2019-04-19 10:05 ` [PATCH v3 03/11] platform/x86: asus-wmi: Increase the input buffer size of WMI methods Yurii Pavlovskyi
2019-04-19 10:05 ` Yurii Pavlovskyi
2019-05-08 13:30 ` Andy Shevchenko
2019-04-19 10:08 ` [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection Yurii Pavlovskyi
2019-04-19 10:08 ` Yurii Pavlovskyi
2019-05-08 13:36 ` Andy Shevchenko
2019-05-09 6:08 ` Daniel Drake [this message]
2019-05-09 17:29 ` Yurii Pavlovskyi
2019-05-09 17:57 ` Andy Shevchenko
2019-04-19 10:10 ` [PATCH v3 05/11] platform/x86: asus-wmi: Support WMI event queue Yurii Pavlovskyi
2019-04-19 10:10 ` Yurii Pavlovskyi
2019-05-08 13:47 ` Andy Shevchenko
2019-05-09 17:36 ` Yurii Pavlovskyi
2019-04-19 10:11 ` [PATCH v3 06/11] platform/x86: asus-nb-wmi: Add microphone mute key code Yurii Pavlovskyi
2019-04-19 10:11 ` Yurii Pavlovskyi
2019-04-19 10:12 ` [PATCH v3 07/11] platform/x86: asus-wmi: Organize code into sections Yurii Pavlovskyi
2019-04-19 10:12 ` Yurii Pavlovskyi
2019-05-08 13:46 ` Andy Shevchenko
2019-04-19 10:12 ` [PATCH v3 08/11] platform/x86: asus-wmi: Enhance detection of thermal data Yurii Pavlovskyi
2019-04-19 10:12 ` Yurii Pavlovskyi
2019-04-24 18:25 ` Pawnikar, Sumeet R
2019-04-24 18:25 ` Pawnikar, Sumeet R
2019-04-25 18:51 ` Yurii Pavlovskyi
2019-04-25 18:51 ` Yurii Pavlovskyi
2019-05-08 13:58 ` Andy Shevchenko
2019-05-09 17:49 ` Yurii Pavlovskyi
2019-05-09 17:54 ` Andy Shevchenko
2019-04-19 10:14 ` [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight Yurii Pavlovskyi
2019-04-19 10:14 ` Yurii Pavlovskyi
2019-05-08 14:02 ` Andy Shevchenko
2019-05-08 17:12 ` Pavel Machek
2019-05-09 19:04 ` Yurii Pavlovskyi
2019-05-09 20:45 ` Dan Murphy
2019-05-09 20:45 ` Dan Murphy
2019-05-09 21:06 ` Andy Shevchenko
2019-05-09 21:44 ` Dan Murphy
2019-05-09 21:44 ` Dan Murphy
2019-05-09 22:15 ` Pavel Machek
2019-05-09 22:34 ` Pavel Machek
2019-04-19 10:15 ` [PATCH v3 10/11] platform/x86: asus-wmi: Switch fan boost mode Yurii Pavlovskyi
2019-04-19 10:15 ` Yurii Pavlovskyi
2019-04-19 10:16 ` [PATCH v3 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unloading Yurii Pavlovskyi
2019-04-19 10:16 ` Yurii Pavlovskyi
2019-05-08 13:26 ` [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD8Lp46tCfi3ZCmmXZv3-ZDbon+6P8qC4GPR9Bt3uFFr=Sn4Cw@mail.gmail.com' \
--to=drake@endlessm.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yurii.pavlovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.