From: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com> To: unlisted-recipients:; (no To-header on input) Cc: Corentin Chary <corentin.chary@gmail.com>, Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>, Daniel Drake <drake@endlessm.com>, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/11] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load Date: Fri, 19 Apr 2019 12:03:43 +0200 [thread overview] Message-ID: <83ca4d6b-523a-5c89-1f0e-7103e5c5923b@gmail.com> (raw) In-Reply-To: <7acd57fe-604a-a96a-4ca2-a25bc88d6405@gmail.com> The error code and return value are mixed up. The intensity is always set to 0 on load as kbd_led_read returns either 0 or negative value. To reproduce set backlight to maximum, reload driver and try to increase it using keyboard hotkey, the intensity will drop as a result. Correct the implementation. Signed-off-by: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com> --- drivers/platform/x86/asus-wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index d865eb95054c..731ffd382426 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -590,8 +590,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus) goto error; } - led_val = kbd_led_read(asus, NULL, NULL); - if (led_val >= 0) { + if (!kbd_led_read(asus, &led_val, NULL)) { asus->kbd_led_wk = led_val; asus->kbd_led.name = "asus::kbd_backlight"; asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com> Cc: Corentin Chary <corentin.chary@gmail.com>, Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>, Daniel Drake <drake@endlessm.com>, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/11] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load Date: Fri, 19 Apr 2019 12:03:43 +0200 [thread overview] Message-ID: <83ca4d6b-523a-5c89-1f0e-7103e5c5923b@gmail.com> (raw) In-Reply-To: <7acd57fe-604a-a96a-4ca2-a25bc88d6405@gmail.com> The error code and return value are mixed up. The intensity is always set to 0 on load as kbd_led_read returns either 0 or negative value. To reproduce set backlight to maximum, reload driver and try to increase it using keyboard hotkey, the intensity will drop as a result. Correct the implementation. Signed-off-by: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com> --- drivers/platform/x86/asus-wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index d865eb95054c..731ffd382426 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -590,8 +590,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus) goto error; } - led_val = kbd_led_read(asus, NULL, NULL); - if (led_val >= 0) { + if (!kbd_led_read(asus, &led_val, NULL)) { asus->kbd_led_wk = led_val; asus->kbd_led.name = "asus::kbd_backlight"; asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED; -- 2.17.1
next prev parent reply other threads:[~2019-04-19 19:03 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-19 9:57 [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Yurii Pavlovskyi 2019-04-19 9:57 ` Yurii Pavlovskyi 2019-04-19 10:00 ` [PATCH v3 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup Yurii Pavlovskyi 2019-04-19 10:00 ` Yurii Pavlovskyi 2019-05-08 13:25 ` Andy Shevchenko 2019-04-19 10:03 ` Yurii Pavlovskyi [this message] 2019-04-19 10:03 ` [PATCH v3 02/11] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load Yurii Pavlovskyi 2019-04-19 10:05 ` [PATCH v3 03/11] platform/x86: asus-wmi: Increase the input buffer size of WMI methods Yurii Pavlovskyi 2019-04-19 10:05 ` Yurii Pavlovskyi 2019-05-08 13:30 ` Andy Shevchenko 2019-04-19 10:08 ` [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection Yurii Pavlovskyi 2019-04-19 10:08 ` Yurii Pavlovskyi 2019-05-08 13:36 ` Andy Shevchenko 2019-05-09 6:08 ` Daniel Drake 2019-05-09 17:29 ` Yurii Pavlovskyi 2019-05-09 17:57 ` Andy Shevchenko 2019-04-19 10:10 ` [PATCH v3 05/11] platform/x86: asus-wmi: Support WMI event queue Yurii Pavlovskyi 2019-04-19 10:10 ` Yurii Pavlovskyi 2019-05-08 13:47 ` Andy Shevchenko 2019-05-09 17:36 ` Yurii Pavlovskyi 2019-04-19 10:11 ` [PATCH v3 06/11] platform/x86: asus-nb-wmi: Add microphone mute key code Yurii Pavlovskyi 2019-04-19 10:11 ` Yurii Pavlovskyi 2019-04-19 10:12 ` [PATCH v3 07/11] platform/x86: asus-wmi: Organize code into sections Yurii Pavlovskyi 2019-04-19 10:12 ` Yurii Pavlovskyi 2019-05-08 13:46 ` Andy Shevchenko 2019-04-19 10:12 ` [PATCH v3 08/11] platform/x86: asus-wmi: Enhance detection of thermal data Yurii Pavlovskyi 2019-04-19 10:12 ` Yurii Pavlovskyi 2019-04-24 18:25 ` Pawnikar, Sumeet R 2019-04-24 18:25 ` Pawnikar, Sumeet R 2019-04-25 18:51 ` Yurii Pavlovskyi 2019-04-25 18:51 ` Yurii Pavlovskyi 2019-05-08 13:58 ` Andy Shevchenko 2019-05-09 17:49 ` Yurii Pavlovskyi 2019-05-09 17:54 ` Andy Shevchenko 2019-04-19 10:14 ` [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight Yurii Pavlovskyi 2019-04-19 10:14 ` Yurii Pavlovskyi 2019-05-08 14:02 ` Andy Shevchenko 2019-05-08 17:12 ` Pavel Machek 2019-05-09 19:04 ` Yurii Pavlovskyi 2019-05-09 20:45 ` Dan Murphy 2019-05-09 20:45 ` Dan Murphy 2019-05-09 21:06 ` Andy Shevchenko 2019-05-09 21:44 ` Dan Murphy 2019-05-09 21:44 ` Dan Murphy 2019-05-09 22:15 ` Pavel Machek 2019-05-09 22:34 ` Pavel Machek 2019-04-19 10:15 ` [PATCH v3 10/11] platform/x86: asus-wmi: Switch fan boost mode Yurii Pavlovskyi 2019-04-19 10:15 ` Yurii Pavlovskyi 2019-04-19 10:16 ` [PATCH v3 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unloading Yurii Pavlovskyi 2019-04-19 10:16 ` Yurii Pavlovskyi 2019-05-08 13:26 ` [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=83ca4d6b-523a-5c89-1f0e-7103e5c5923b@gmail.com \ --to=yurii.pavlovskyi@gmail.com \ --cc=acpi4asus-user@lists.sourceforge.net \ --cc=andy@infradead.org \ --cc=corentin.chary@gmail.com \ --cc=drake@endlessm.com \ --cc=dvhart@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.