From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Yurii Pavlovskyi <yurii.pavlovskyi@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Daniel Drake <drake@endlessm.com>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 08/11] platform/x86: asus-wmi: Enhance detection of thermal data
Date: Thu, 9 May 2019 20:54:36 +0300 [thread overview]
Message-ID: <CAHp75VcgjF7uQAbdA74vivBaVvdto+1PXRX2_QZA=Gwu0BsAdA@mail.gmail.com> (raw)
In-Reply-To: <0d7f6a9e-d508-65ba-9646-39f1d1a42a13@gmail.com>
On Thu, May 9, 2019 at 8:49 PM Yurii Pavlovskyi
<yurii.pavlovskyi@gmail.com> wrote:
> On 08.05.19 15:58, Andy Shevchenko wrote:
> Yes, looking at this patch now I'd guess the refactoring there is really
> misguided as it adds a lot more code than it removes, will drop it
> completely and just add a new condition to the current check instead in
> next version:
> - /* If value is zero, something is clearly wrong */
> - if (!value)
> + if (!value || value == 1)
Perhaps here makes sense to explicitly show value == 0.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-05-09 17:54 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:57 [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Yurii Pavlovskyi
2019-04-19 9:57 ` Yurii Pavlovskyi
2019-04-19 10:00 ` [PATCH v3 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup Yurii Pavlovskyi
2019-04-19 10:00 ` Yurii Pavlovskyi
2019-05-08 13:25 ` Andy Shevchenko
2019-04-19 10:03 ` [PATCH v3 02/11] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load Yurii Pavlovskyi
2019-04-19 10:03 ` Yurii Pavlovskyi
2019-04-19 10:05 ` [PATCH v3 03/11] platform/x86: asus-wmi: Increase the input buffer size of WMI methods Yurii Pavlovskyi
2019-04-19 10:05 ` Yurii Pavlovskyi
2019-05-08 13:30 ` Andy Shevchenko
2019-04-19 10:08 ` [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection Yurii Pavlovskyi
2019-04-19 10:08 ` Yurii Pavlovskyi
2019-05-08 13:36 ` Andy Shevchenko
2019-05-09 6:08 ` Daniel Drake
2019-05-09 17:29 ` Yurii Pavlovskyi
2019-05-09 17:57 ` Andy Shevchenko
2019-04-19 10:10 ` [PATCH v3 05/11] platform/x86: asus-wmi: Support WMI event queue Yurii Pavlovskyi
2019-04-19 10:10 ` Yurii Pavlovskyi
2019-05-08 13:47 ` Andy Shevchenko
2019-05-09 17:36 ` Yurii Pavlovskyi
2019-04-19 10:11 ` [PATCH v3 06/11] platform/x86: asus-nb-wmi: Add microphone mute key code Yurii Pavlovskyi
2019-04-19 10:11 ` Yurii Pavlovskyi
2019-04-19 10:12 ` [PATCH v3 07/11] platform/x86: asus-wmi: Organize code into sections Yurii Pavlovskyi
2019-04-19 10:12 ` Yurii Pavlovskyi
2019-05-08 13:46 ` Andy Shevchenko
2019-04-19 10:12 ` [PATCH v3 08/11] platform/x86: asus-wmi: Enhance detection of thermal data Yurii Pavlovskyi
2019-04-19 10:12 ` Yurii Pavlovskyi
2019-04-24 18:25 ` Pawnikar, Sumeet R
2019-04-24 18:25 ` Pawnikar, Sumeet R
2019-04-25 18:51 ` Yurii Pavlovskyi
2019-04-25 18:51 ` Yurii Pavlovskyi
2019-05-08 13:58 ` Andy Shevchenko
2019-05-09 17:49 ` Yurii Pavlovskyi
2019-05-09 17:54 ` Andy Shevchenko [this message]
2019-04-19 10:14 ` [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight Yurii Pavlovskyi
2019-04-19 10:14 ` Yurii Pavlovskyi
2019-05-08 14:02 ` Andy Shevchenko
2019-05-08 17:12 ` Pavel Machek
2019-05-09 19:04 ` Yurii Pavlovskyi
2019-05-09 20:45 ` Dan Murphy
2019-05-09 20:45 ` Dan Murphy
2019-05-09 21:06 ` Andy Shevchenko
2019-05-09 21:44 ` Dan Murphy
2019-05-09 21:44 ` Dan Murphy
2019-05-09 22:15 ` Pavel Machek
2019-05-09 22:34 ` Pavel Machek
2019-04-19 10:15 ` [PATCH v3 10/11] platform/x86: asus-wmi: Switch fan boost mode Yurii Pavlovskyi
2019-04-19 10:15 ` Yurii Pavlovskyi
2019-04-19 10:16 ` [PATCH v3 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unloading Yurii Pavlovskyi
2019-04-19 10:16 ` Yurii Pavlovskyi
2019-05-08 13:26 ` [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcgjF7uQAbdA74vivBaVvdto+1PXRX2_QZA=Gwu0BsAdA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=drake@endlessm.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yurii.pavlovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.