From: Keiichi Watanabe <keiichiw@chromium.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Dmitry Sepp" <dmitry.sepp@opensynergy.com>,
"Tomasz Figa" <tfiga@chromium.org>,
virtio-dev@lists.oasis-open.org,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Alex Lau" <alexlau@chromium.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dylan Reid" <dgreid@chromium.org>,
"Enrico Granata" <egranata@google.com>,
"Frediano Ziglio" <fziglio@redhat.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Pawel Osciak" <posciak@chromium.org>,
spice-devel@lists.freedesktop.org,
"David Stevens" <stevensd@chromium.org>,
uril@redhat.com
Subject: Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification
Date: Wed, 8 Jan 2020 22:50:59 +0900 [thread overview]
Message-ID: <CAD90VcYcXniT-HV09LJoMkm8JWZ1c9et829wBdHUx9xwx3ya=Q@mail.gmail.com> (raw)
In-Reply-To: <20191219130158.7rzdkyemupreudko@sirius.home.kraxel.org>
Hi Gerd,
Thank you so much for the review. I'm sorry for not replying earlier.
On Thu, Dec 19, 2019 at 10:02 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Hi,
>
> > > Not clearly defined in the spec: When is the decoder supposed to send
> > > the response for a queue request? When it finished decoding (i.e. frame
> > > is ready for playback), or when it doesn't need the buffer any more for
> > > decoding (i.e. buffer can be re-queued or pages can be released)?
The answer is "when it doesn't need the buffer any more for decoding".
The device can access buffer contents from when a queue request is
sent until the device responds it. So, the device must not responds a
queue request before finishing all process that requires the buffer
content.
Actually, the first one "When it finished decoding (i.e. frame is
ready for playback)" doesn't make much sense, as it's not necessary to
have a one-to-one correspondence between an input bitstream buffer and
a decoded frame.
It's okay to decode one input buffer contains bitstream data for two
frames. Also, a user can pass bitstream for one frame as two input
buffers.
I'll document it in the spec.
Best regards,
Keiichi
> > In my eyes the both statements mean almost the same and both are valid.
>
> Well, no. When the device decoded a P-Frame it can notify the device,
> saying "here is your decoded frame". But the device might still need
> the buffer with the decoded frame to properly decode the following B/I
> Frames which reference the P-Frame.
>
> cheers,
> Gerd
>
WARNING: multiple messages have this Message-ID (diff)
From: Keiichi Watanabe <keiichiw@chromium.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Dmitry Sepp" <dmitry.sepp@opensynergy.com>,
"Tomasz Figa" <tfiga@chromium.org>,
virtio-dev@lists.oasis-open.org,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Alex Lau" <alexlau@chromium.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dylan Reid" <dgreid@chromium.org>,
"Enrico Granata" <egranata@google.com>,
"Frediano Ziglio" <fziglio@redhat.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Pawel Osciak" <posciak@chromium.org>,
spice-devel@lists.freedesktop.org,
"David Stevens" <stevensd@chromium.org>,
uril@redhat.com
Subject: Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification
Date: Wed, 8 Jan 2020 22:50:59 +0900 [thread overview]
Message-ID: <CAD90VcYcXniT-HV09LJoMkm8JWZ1c9et829wBdHUx9xwx3ya=Q@mail.gmail.com> (raw)
In-Reply-To: <20191219130158.7rzdkyemupreudko@sirius.home.kraxel.org>
Hi Gerd,
Thank you so much for the review. I'm sorry for not replying earlier.
On Thu, Dec 19, 2019 at 10:02 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Hi,
>
> > > Not clearly defined in the spec: When is the decoder supposed to send
> > > the response for a queue request? When it finished decoding (i.e. frame
> > > is ready for playback), or when it doesn't need the buffer any more for
> > > decoding (i.e. buffer can be re-queued or pages can be released)?
The answer is "when it doesn't need the buffer any more for decoding".
The device can access buffer contents from when a queue request is
sent until the device responds it. So, the device must not responds a
queue request before finishing all process that requires the buffer
content.
Actually, the first one "When it finished decoding (i.e. frame is
ready for playback)" doesn't make much sense, as it's not necessary to
have a one-to-one correspondence between an input bitstream buffer and
a decoded frame.
It's okay to decode one input buffer contains bitstream data for two
frames. Also, a user can pass bitstream for one frame as two input
buffers.
I'll document it in the spec.
Best regards,
Keiichi
> > In my eyes the both statements mean almost the same and both are valid.
>
> Well, no. When the device decoded a P-Frame it can notify the device,
> saying "here is your decoded frame". But the device might still need
> the buffer with the decoded frame to properly decode the following B/I
> Frames which reference the P-Frame.
>
> cheers,
> Gerd
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2020-01-08 13:51 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:02 [PATCH v2 0/1] VirtIO video device specification Keiichi Watanabe
2019-12-18 13:02 ` [virtio-dev] " Keiichi Watanabe
2019-12-18 13:02 ` [PATCH v2 1/1] virtio-video: Add virtio " Keiichi Watanabe
2019-12-18 13:02 ` [virtio-dev] " Keiichi Watanabe
2019-12-18 13:40 ` Gerd Hoffmann
2019-12-18 13:40 ` [virtio-dev] " Gerd Hoffmann
2019-12-18 14:08 ` Tomasz Figa
2019-12-18 14:08 ` Tomasz Figa
2019-12-19 7:46 ` Gerd Hoffmann
2019-12-19 7:46 ` Gerd Hoffmann
2019-12-19 9:48 ` Dmitry Sepp
2019-12-19 9:48 ` Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 10:54 ` Dmitry Sepp
2019-12-19 10:54 ` Dmitry Sepp
2019-12-19 12:05 ` Tomasz Figa
2019-12-19 12:05 ` Tomasz Figa
2019-12-19 13:12 ` Gerd Hoffmann
2019-12-19 13:12 ` Gerd Hoffmann
2020-01-08 13:52 ` Keiichi Watanabe
2020-01-08 13:52 ` Keiichi Watanabe
2020-01-09 13:40 ` Gerd Hoffmann
2020-01-09 13:40 ` Gerd Hoffmann
2020-01-09 14:20 ` Tomasz Figa
2020-01-09 14:20 ` Tomasz Figa
2020-01-14 7:18 ` Keiichi Watanabe
2020-01-14 7:18 ` Keiichi Watanabe
2020-01-14 10:35 ` Dmitry Sepp
2020-01-14 10:35 ` Dmitry Sepp
2020-01-15 7:49 ` Keiichi Watanabe
2020-01-15 7:49 ` Keiichi Watanabe
2020-01-15 11:12 ` Tomasz Figa
2020-01-15 11:12 ` Tomasz Figa
2019-12-19 13:01 ` Gerd Hoffmann
2019-12-19 13:01 ` Gerd Hoffmann
2020-01-08 13:50 ` Keiichi Watanabe [this message]
2020-01-08 13:50 ` Keiichi Watanabe
2019-12-19 9:26 ` Dmitry Sepp
2019-12-19 9:26 ` [virtio-dev] " Dmitry Sepp
2019-12-19 9:59 ` Tomasz Figa
2019-12-19 9:59 ` [virtio-dev] " Tomasz Figa
2019-12-19 12:54 ` Gerd Hoffmann
2019-12-19 12:54 ` [virtio-dev] " Gerd Hoffmann
2019-12-18 17:29 ` Frediano Ziglio
2019-12-20 14:05 ` Keiichi Watanabe
2019-12-20 14:05 ` [virtio-dev] " Keiichi Watanabe
2019-12-20 15:33 ` Dmitry Sepp
2019-12-20 15:33 ` [virtio-dev] " Dmitry Sepp
2019-12-19 13:28 ` Dmitry Sepp
2019-12-19 13:28 ` [virtio-dev] " Dmitry Sepp
2019-12-20 15:26 ` Keiichi Watanabe
2019-12-20 15:26 ` [virtio-dev] " Keiichi Watanabe
2019-12-20 15:46 ` Dmitry Sepp
2019-12-21 6:46 ` Tomasz Figa
2019-12-21 6:46 ` [virtio-dev] " Tomasz Figa
2019-12-30 12:16 ` Dmitry Sepp
2019-12-30 12:16 ` Dmitry Sepp
2020-01-06 6:31 ` Tomasz Figa
2020-01-06 6:31 ` Tomasz Figa
2020-01-06 8:33 ` Gerd Hoffmann
2020-01-06 8:33 ` Gerd Hoffmann
2020-01-06 9:29 ` Dmitry Sepp
2020-01-06 9:29 ` Dmitry Sepp
2020-01-03 15:47 ` Dmitry Sepp
2020-01-03 15:47 ` [virtio-dev] " Dmitry Sepp
2020-01-06 8:47 ` Gerd Hoffmann
2020-01-06 8:47 ` [virtio-dev] " Gerd Hoffmann
2020-01-06 10:21 ` Keiichi Watanabe
2020-01-06 10:21 ` [virtio-dev] " Keiichi Watanabe
2020-01-06 14:59 ` Dmitry Sepp
2020-01-06 14:59 ` [virtio-dev] " Dmitry Sepp
2020-01-07 13:24 ` Keiichi Watanabe
2020-01-07 13:24 ` [virtio-dev] " Keiichi Watanabe
2020-01-07 16:50 ` Dmitry Sepp
2020-01-07 16:50 ` [virtio-dev] " Dmitry Sepp
2020-01-08 6:59 ` Keiichi Watanabe
2020-01-08 6:59 ` [virtio-dev] " Keiichi Watanabe
2020-01-08 10:00 ` Dmitry Sepp
2020-01-08 10:00 ` [virtio-dev] " Dmitry Sepp
2020-01-08 12:14 ` Keiichi Watanabe
2020-01-08 12:14 ` [virtio-dev] " Keiichi Watanabe
2020-01-08 12:46 ` Tomasz Figa
2020-01-08 12:46 ` [virtio-dev] " Tomasz Figa
2020-01-08 13:05 ` Keiichi Watanabe
2020-01-08 13:05 ` [virtio-dev] " Keiichi Watanabe
2020-01-08 13:11 ` Dmitry Sepp
2020-01-08 13:11 ` [virtio-dev] " Dmitry Sepp
2020-01-08 13:23 ` Keiichi Watanabe
2020-01-08 13:23 ` Keiichi Watanabe
2020-01-08 12:23 ` Keiichi Watanabe
2020-01-08 12:23 ` [virtio-dev] " Keiichi Watanabe
2019-12-20 15:58 ` [PATCH v2 0/1] VirtIO " Dmitry Sepp
2019-12-20 15:58 ` [virtio-dev] " Dmitry Sepp
2019-12-21 4:36 ` Keiichi Watanabe
2019-12-21 4:36 ` [virtio-dev] " Keiichi Watanabe
2019-12-21 6:18 ` Tomasz Figa
2019-12-21 6:18 ` [virtio-dev] " Tomasz Figa
2019-12-21 6:19 ` Tomasz Figa
2019-12-21 6:19 ` [virtio-dev] " Tomasz Figa
2020-01-03 13:05 ` Dmitry Sepp
2020-01-03 13:05 ` [virtio-dev] " Dmitry Sepp
2020-01-06 10:30 ` Keiichi Watanabe
2020-01-06 10:30 ` [virtio-dev] " Keiichi Watanabe
2020-01-06 11:28 ` Dmitry Sepp
2020-01-06 11:28 ` [virtio-dev] " Dmitry Sepp
2020-01-07 10:25 ` Keiichi Watanabe
2020-01-07 10:25 ` [virtio-dev] " Keiichi Watanabe
2020-01-09 14:56 ` Dmitry Sepp
2020-01-09 14:56 ` [virtio-dev] " Dmitry Sepp
2020-01-10 10:16 ` Dmitry Sepp
2020-01-10 10:16 ` Dmitry Sepp
2020-01-10 13:53 ` Keiichi Watanabe
2020-01-10 13:53 ` Keiichi Watanabe
2020-01-10 15:11 ` Dmitry Sepp
2020-01-10 15:11 ` Dmitry Sepp
2020-01-11 16:06 ` Tomasz Figa
2020-01-11 16:06 ` Tomasz Figa
2020-01-13 9:50 ` Dmitry Sepp
2020-01-13 9:50 ` Dmitry Sepp
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-13 9:56 ` Gerd Hoffmann
2020-01-13 9:56 ` Gerd Hoffmann
2020-01-13 10:41 ` Dmitry Sepp
2020-01-13 11:05 ` Gerd Hoffmann
2020-01-13 11:05 ` Gerd Hoffmann
2020-01-13 11:59 ` Tomasz Figa
2020-01-13 11:59 ` Tomasz Figa
2020-01-13 13:26 ` Gerd Hoffmann
2020-01-13 13:26 ` Gerd Hoffmann
2020-01-15 11:00 ` Tomasz Figa
2020-01-15 11:00 ` Tomasz Figa
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-15 11:23 ` Keiichi Watanabe
2020-01-15 11:26 ` Gerd Hoffmann
2020-01-15 11:26 ` Gerd Hoffmann
2020-01-20 7:20 ` Keiichi Watanabe
2020-01-20 7:20 ` Keiichi Watanabe
2020-01-20 10:47 ` Gerd Hoffmann
2020-01-20 10:47 ` Gerd Hoffmann
2020-01-21 2:47 ` Keiichi Watanabe
2020-01-21 2:47 ` Keiichi Watanabe
2020-01-21 6:44 ` Gerd Hoffmann
2020-01-21 6:44 ` Gerd Hoffmann
2020-01-21 8:56 ` Keiichi Watanabe
2020-01-21 8:56 ` Keiichi Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD90VcYcXniT-HV09LJoMkm8JWZ1c9et829wBdHUx9xwx3ya=Q@mail.gmail.com' \
--to=keiichiw@chromium.org \
--cc=acourbot@chromium.org \
--cc=alexlau@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dgreid@chromium.org \
--cc=dmitry.sepp@opensynergy.com \
--cc=egranata@google.com \
--cc=fziglio@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=kraxel@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=posciak@chromium.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=stevensd@chromium.org \
--cc=tfiga@chromium.org \
--cc=uril@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.