From: Fu Wei <fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
Lorenzo Pieralisi
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>,
Hanjun Guo <hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Linaro ACPI Mailman List
<linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
ACPI Devel Maling List
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, "Abdulhamid,
Harb" <harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Christopher Covington
<cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Timur Tabi <timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
G Gregory
<graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Al Stone <al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Jon Masters <jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg.
Date: Mon, 20 Mar 2017 15:36:36 +0800 [thread overview]
Message-ID: <CADyBb7vZ4G+q1y6w6OVQ7i-ZiTtcdx_w2BOSWqy=2jWhAV6Hmw@mail.gmail.com> (raw)
In-Reply-To: <20170317180513.GB15909@leverpostej>
Hi Mark,
On 18 March 2017 at 02:05, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Tue, Feb 07, 2017 at 02:50:03AM +0800, fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:
>> +static u32 arch_timer_get_sysreg_freq(void)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of sysreg.
>> + */
>> + return arch_timer_get_cntfrq();
>> +}
>
> We already have arch_timer_get_cntfrq(), so I don't see the point in
> this wrapper.
>
>> +static u32 arch_timer_get_mmio_freq(void __iomem *cntbase)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of timer frame registers.
>> + * Note: please verify cntbase in caller.
>> + */
>> + return readl_relaxed(cntbase + CNTFRQ);
>> +}
>
> Wrapping the MMIO read makes sense if we're going to do this in more
> than one place, so I'm happy with this wrapper.
>
> If you can s/arch_timer_get_mmio_freq/arch_timer_get_cntfrq/, and drop
sorry, May I guess that is
"s/arch_timer_get_mmio_freq/arch_timer_get_mmio_cntfrq/"
or
"s/arch_timer_get_mmio_freq/arch_timer_mem_get_cntfrq/"
which one do you prefer? :-)
> the comments, then this looks fine to me.
>
> Thanks,
> Mark.
--
Best regards,
Fu Wei
Software Engineer
Red Hat
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Fu Wei <fu.wei@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
rruigrok@codeaurora.org, "Abdulhamid,
Harb" <harba@codeaurora.org>,
Christopher Covington <cov@codeaurora.org>,
Timur Tabi <timur@codeaurora.org>,
G Gregory <graeme.gregory@linaro.org>,
Al Stone <al.stone@linaro.org>, Jon Masters <jcm@redhat.com>,
Wei Huang <wei@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Leo Duran <leo.duran@amd.com>, Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, Tomasz Nowicki <tn@semihalf.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg.
Date: Mon, 20 Mar 2017 15:36:36 +0800 [thread overview]
Message-ID: <CADyBb7vZ4G+q1y6w6OVQ7i-ZiTtcdx_w2BOSWqy=2jWhAV6Hmw@mail.gmail.com> (raw)
In-Reply-To: <20170317180513.GB15909@leverpostej>
Hi Mark,
On 18 March 2017 at 02:05, Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Feb 07, 2017 at 02:50:03AM +0800, fu.wei@linaro.org wrote:
>> +static u32 arch_timer_get_sysreg_freq(void)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of sysreg.
>> + */
>> + return arch_timer_get_cntfrq();
>> +}
>
> We already have arch_timer_get_cntfrq(), so I don't see the point in
> this wrapper.
>
>> +static u32 arch_timer_get_mmio_freq(void __iomem *cntbase)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of timer frame registers.
>> + * Note: please verify cntbase in caller.
>> + */
>> + return readl_relaxed(cntbase + CNTFRQ);
>> +}
>
> Wrapping the MMIO read makes sense if we're going to do this in more
> than one place, so I'm happy with this wrapper.
>
> If you can s/arch_timer_get_mmio_freq/arch_timer_get_cntfrq/, and drop
sorry, May I guess that is
"s/arch_timer_get_mmio_freq/arch_timer_get_mmio_cntfrq/"
or
"s/arch_timer_get_mmio_freq/arch_timer_mem_get_cntfrq/"
which one do you prefer? :-)
> the comments, then this looks fine to me.
>
> Thanks,
> Mark.
--
Best regards,
Fu Wei
Software Engineer
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: fu.wei@linaro.org (Fu Wei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg.
Date: Mon, 20 Mar 2017 15:36:36 +0800 [thread overview]
Message-ID: <CADyBb7vZ4G+q1y6w6OVQ7i-ZiTtcdx_w2BOSWqy=2jWhAV6Hmw@mail.gmail.com> (raw)
In-Reply-To: <20170317180513.GB15909@leverpostej>
Hi Mark,
On 18 March 2017 at 02:05, Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Feb 07, 2017 at 02:50:03AM +0800, fu.wei at linaro.org wrote:
>> +static u32 arch_timer_get_sysreg_freq(void)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of sysreg.
>> + */
>> + return arch_timer_get_cntfrq();
>> +}
>
> We already have arch_timer_get_cntfrq(), so I don't see the point in
> this wrapper.
>
>> +static u32 arch_timer_get_mmio_freq(void __iomem *cntbase)
>> +{
>> + /*
>> + * Try to get the frequency from the CNTFRQ of timer frame registers.
>> + * Note: please verify cntbase in caller.
>> + */
>> + return readl_relaxed(cntbase + CNTFRQ);
>> +}
>
> Wrapping the MMIO read makes sense if we're going to do this in more
> than one place, so I'm happy with this wrapper.
>
> If you can s/arch_timer_get_mmio_freq/arch_timer_get_cntfrq/, and drop
sorry, May I guess that is
"s/arch_timer_get_mmio_freq/arch_timer_get_mmio_cntfrq/"
or
"s/arch_timer_get_mmio_freq/arch_timer_mem_get_cntfrq/"
which one do you prefer? :-)
> the comments, then this looks fine to me.
>
> Thanks,
> Mark.
--
Best regards,
Fu Wei
Software Engineer
Red Hat
next prev parent reply other threads:[~2017-03-20 7:36 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 18:50 [PATCH v21 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 01/13] clocksource: arm_arch_timer: introduce two functions to get the frequency from mmio and sysreg fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-03-17 18:05 ` Mark Rutland
2017-03-17 18:05 ` Mark Rutland
2017-03-17 18:05 ` Mark Rutland
2017-03-20 7:36 ` Fu Wei [this message]
2017-03-20 7:36 ` Fu Wei
2017-03-20 7:36 ` Fu Wei
2017-03-20 9:43 ` Fu Wei
2017-03-20 9:43 ` Fu Wei
2017-03-20 9:43 ` Fu Wei
2017-03-20 10:41 ` Mark Rutland
2017-03-20 10:41 ` Mark Rutland
2017-03-20 10:41 ` Mark Rutland
2017-03-20 11:09 ` Fu Wei
2017-03-20 11:09 ` Fu Wei
2017-03-20 11:09 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-03-17 18:07 ` Mark Rutland
2017-03-17 18:07 ` Mark Rutland
2017-03-17 18:07 ` Mark Rutland
2017-03-20 6:59 ` Fu Wei
2017-03-20 6:59 ` Fu Wei
2017-03-20 6:59 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 04/13] clocksource: arm_arch_timer: split arch_timer_rate for different types of timer fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-03-17 19:05 ` Mark Rutland
2017-03-17 19:05 ` Mark Rutland
2017-03-17 19:05 ` Mark Rutland
2017-03-20 13:35 ` Fu Wei
2017-03-20 13:35 ` Fu Wei
2017-03-20 13:35 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 05/13] clocksource: arm_arch_timer: refactor arch_timer_needs_probing fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 06/13] clocksource: arm_arch_timer: move arch_timer_needs_of_probing into DT init call fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 07/13] clocksource: arm_arch_timer: introduce some new structs to prepare for GTDT fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 08/13] clocksource: arm_arch_timer: refactor MMIO timer probing fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 09/13] acpi/arm64: Add GTDT table parse driver fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 10/13] clocksource: arm_arch_timer: simplify ACPI support code fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 11/13] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` fu.wei
2017-03-17 19:40 ` Mark Rutland
2017-03-17 19:40 ` Mark Rutland
2017-03-17 19:40 ` Mark Rutland
2017-03-20 13:38 ` Fu Wei
2017-03-20 13:38 ` Fu Wei
2017-03-20 13:38 ` Fu Wei
2017-02-06 18:50 ` [PATCH v21 12/13] clocksource: arm_arch_timer: add GTDT support for memory-mapped timer fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` [PATCH v21 13/13] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` fu.wei
2017-03-17 20:01 ` Mark Rutland
2017-03-17 20:01 ` Mark Rutland
2017-03-17 20:01 ` Mark Rutland
2017-03-17 20:01 ` Mark Rutland
2017-03-20 17:57 ` Fu Wei
2017-03-20 17:57 ` Fu Wei
2017-03-20 17:57 ` Fu Wei
2017-03-20 18:09 ` Mark Rutland
2017-03-20 18:09 ` Mark Rutland
2017-03-20 18:09 ` Mark Rutland
2017-03-20 18:50 ` [Linaro-acpi] " Lurndal, Scott
2017-03-20 18:50 ` Lurndal, Scott
2017-03-20 18:50 ` Lurndal, Scott
2017-03-21 3:48 ` Fu Wei
2017-03-21 3:48 ` Fu Wei
2017-03-21 3:48 ` Fu Wei
2017-03-21 12:48 ` Lurndal, Scott
2017-03-21 12:48 ` Lurndal, Scott
2017-03-21 12:48 ` Lurndal, Scott
2017-03-21 5:12 ` Fu Wei
2017-03-21 5:12 ` Fu Wei
2017-03-21 5:12 ` Fu Wei
[not found] ` <20170206185015.12296-1-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-02-06 18:50 ` [PATCH v21 02/13] clocksource: arm_arch_timer: separate out device-tree code from arch_timer_detect_rate fu.wei-QSEj5FYQhm4dnm+yROfE0A
2017-02-06 18:50 ` fu.wei at linaro.org
2017-02-06 18:50 ` fu.wei
2017-02-20 16:20 ` [PATCH v21 00/13] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Fu Wei
2017-02-20 16:20 ` Fu Wei
2017-02-20 16:20 ` Fu Wei
[not found] ` <CADyBb7t_zrLetPQQ8=k8oN6iMHhuMHO8O3XTZqGYvTT9p0evKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-09 22:47 ` Fu Wei
2017-03-09 22:47 ` Fu Wei
2017-03-09 22:47 ` Fu Wei
2017-03-17 20:03 ` Mark Rutland
2017-03-17 20:03 ` Mark Rutland
2017-03-17 20:03 ` Mark Rutland
2017-03-20 5:09 ` Fu Wei
2017-03-20 5:09 ` Fu Wei
2017-03-20 5:09 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADyBb7vZ4G+q1y6w6OVQ7i-ZiTtcdx_w2BOSWqy=2jWhAV6Hmw@mail.gmail.com' \
--to=fu.wei-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.