Re: [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED

From: Gene Chen <gene.chen.richtek@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
	cy_huang@richtek.com, Rob Herring <robh+dt@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Gene Chen <gene_chen@richtek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>, Dan Murphy <dmurphy@ti.com>,
	Wilma.Wu@mediatek.com, benjamin.chao@mediatek.com,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	shufan_lee@richtek.com
Subject: Re: [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED
Date: Thu, 19 Nov 2020 09:41:48 +0800	[thread overview]
Message-ID: <CAE+NS34JXTtoHtapxLAHF35Ybxe=m41Sg4PEfQSpxzA1Hg091g@mail.gmail.com> (raw)
In-Reply-To: <20201118212502.GA1839537@bogus>

Rob Herring <robh@kernel.org> 於 2020年11月19日 週四 上午5:25寫道：
>
> On Wed, 18 Nov 2020 18:47:41 +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings document for LED support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> >  .../devicetree/bindings/leds/leds-mt6360.yaml      | 164 +++++++++++++++++++++
> >  1 file changed, 164 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/leds/leds-mt6360.yaml:57:2: [warning] wrong indentation: expected 2 but found 1 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml: led-controller: led@3:color:0:0: 10 is greater than the maximum of 9
>         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml: led-controller: led@3:color:0:0: 10 is greater than the maximum of 9
>         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
>
>

ACK, I will add description to this patch by
“this patch depends on patch [PATCH v7 3/5] dt-bindings: leds: common:
Increase LED_COLOR_ID_* maximum size"

> See https://patchwork.ozlabs.org/patch/1402193
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>