From: Gene Chen <gene.chen.richtek@gmail.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
Date: Mon, 23 Nov 2020 11:00:09 +0800 [thread overview]
Message-ID: <CAE+NS363BpytNGZzfZHLa7KLKL8gjGj14oNvRi3oaH9KT79REg@mail.gmail.com> (raw)
In-Reply-To: <0700c32d-643b-fedb-06f0-21547b18205d@gmail.com>
Jacek Anaszewski <jacek.anaszewski@gmail.com> 於 2020年11月20日 週五 上午6:26寫道：
>
> On 11/19/20 10:57 PM, Pavel Machek wrote:
> > On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote:
> >> Hi Pavel, Gene,
> >>
> >> On 11/18/20 10:37 PM, Pavel Machek wrote:
> >>> Hi!
> >>>
> >>>> From: Gene Chen <gene_chen@richtek.com>
> >>>>
> >>>> Add LED_COLOR_ID_MOONLIGHT definitions
> >>>
> >>> Why is moonlight a color? Camera flashes are usually white, no?
> >>>
> >>> At least it needs a comment...
> >>
> >> That's my fault, In fact I should have asked about adding
> >> LED_FUNCTION_MOONLIGHT, it was evidently too late for me that evening...
> >
> > Aha, that makes more sense.
> >
> > But please let's call it "torch" if we do that, as that is already
> > used in kernel sources... and probably in the interface, too:
>
> I'd say that torch is something different that moonlight,
> but we would need more input from Gene to learn more about
> the nature of light emitted by ML LED on his device.
>
> Please note that torch is usually meant as the other mode of
> flash LED (sometimes it is called "movie mode"), which is already
> handled by brightness file of LED class flash device (i.e. its LED class
> subset), and which also maps to v4l2-flash TORCH mode.
>
It's used to front camera fill light.
More brightness than screen backlight, and more soft light than flash.
I think LED_ID_COLOR_WHITE is okay.
> > ./arch/arm/mach-pxa/ezx.c: .name = "a910::torch",
> >
> > Best regards,
> > Pavel
> >
>
> --
> Best regards,
> Jacek Anaszewski
WARNING: multiple messages have this Message-ID (diff)
From: Gene Chen <gene.chen.richtek@gmail.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
cy_huang@richtek.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
benjamin.chao@mediatek.com, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wilma.Wu@mediatek.com,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
shufan_lee@richtek.com
Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
Date: Mon, 23 Nov 2020 11:00:09 +0800 [thread overview]
Message-ID: <CAE+NS363BpytNGZzfZHLa7KLKL8gjGj14oNvRi3oaH9KT79REg@mail.gmail.com> (raw)
In-Reply-To: <0700c32d-643b-fedb-06f0-21547b18205d@gmail.com>
Jacek Anaszewski <jacek.anaszewski@gmail.com> 於 2020年11月20日 週五 上午6:26寫道：
>
> On 11/19/20 10:57 PM, Pavel Machek wrote:
> > On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote:
> >> Hi Pavel, Gene,
> >>
> >> On 11/18/20 10:37 PM, Pavel Machek wrote:
> >>> Hi!
> >>>
> >>>> From: Gene Chen <gene_chen@richtek.com>
> >>>>
> >>>> Add LED_COLOR_ID_MOONLIGHT definitions
> >>>
> >>> Why is moonlight a color? Camera flashes are usually white, no?
> >>>
> >>> At least it needs a comment...
> >>
> >> That's my fault, In fact I should have asked about adding
> >> LED_FUNCTION_MOONLIGHT, it was evidently too late for me that evening...
> >
> > Aha, that makes more sense.
> >
> > But please let's call it "torch" if we do that, as that is already
> > used in kernel sources... and probably in the interface, too:
>
> I'd say that torch is something different that moonlight,
> but we would need more input from Gene to learn more about
> the nature of light emitted by ML LED on his device.
>
> Please note that torch is usually meant as the other mode of
> flash LED (sometimes it is called "movie mode"), which is already
> handled by brightness file of LED class flash device (i.e. its LED class
> subset), and which also maps to v4l2-flash TORCH mode.
>
It's used to front camera fill light.
More brightness than screen backlight, and more soft light than flash.
I think LED_ID_COLOR_WHITE is okay.
> > ./arch/arm/mach-pxa/ezx.c: .name = "a910::torch",
> >
> > Best regards,
> > Pavel
> >
>
> --
> Best regards,
> Jacek Anaszewski
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Gene Chen <gene.chen.richtek@gmail.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
cy_huang@richtek.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
benjamin.chao@mediatek.com, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wilma.Wu@mediatek.com,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
shufan_lee@richtek.com
Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
Date: Mon, 23 Nov 2020 11:00:09 +0800 [thread overview]
Message-ID: <CAE+NS363BpytNGZzfZHLa7KLKL8gjGj14oNvRi3oaH9KT79REg@mail.gmail.com> (raw)
In-Reply-To: <0700c32d-643b-fedb-06f0-21547b18205d@gmail.com>
Jacek Anaszewski <jacek.anaszewski@gmail.com> 於 2020年11月20日 週五 上午6:26寫道：
>
> On 11/19/20 10:57 PM, Pavel Machek wrote:
> > On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote:
> >> Hi Pavel, Gene,
> >>
> >> On 11/18/20 10:37 PM, Pavel Machek wrote:
> >>> Hi!
> >>>
> >>>> From: Gene Chen <gene_chen@richtek.com>
> >>>>
> >>>> Add LED_COLOR_ID_MOONLIGHT definitions
> >>>
> >>> Why is moonlight a color? Camera flashes are usually white, no?
> >>>
> >>> At least it needs a comment...
> >>
> >> That's my fault, In fact I should have asked about adding
> >> LED_FUNCTION_MOONLIGHT, it was evidently too late for me that evening...
> >
> > Aha, that makes more sense.
> >
> > But please let's call it "torch" if we do that, as that is already
> > used in kernel sources... and probably in the interface, too:
>
> I'd say that torch is something different that moonlight,
> but we would need more input from Gene to learn more about
> the nature of light emitted by ML LED on his device.
>
> Please note that torch is usually meant as the other mode of
> flash LED (sometimes it is called "movie mode"), which is already
> handled by brightness file of LED class flash device (i.e. its LED class
> subset), and which also maps to v4l2-flash TORCH mode.
>
It's used to front camera fill light.
More brightness than screen backlight, and more soft light than flash.
I think LED_ID_COLOR_WHITE is okay.
> > ./arch/arm/mach-pxa/ezx.c: .name = "a910::torch",
> >
> > Best regards,
> > Pavel
> >
>
> --
> Best regards,
> Jacek Anaszewski
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-23 3:00 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:47 [PATCH v7 0/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 13:32 ` kernel test robot
2020-11-18 13:32 ` kernel test robot
2020-11-18 13:32 ` kernel test robot
2020-11-18 13:32 ` kernel test robot
2020-11-19 22:29 ` Jacek Anaszewski
2020-11-19 22:29 ` Jacek Anaszewski
2020-11-19 22:29 ` Jacek Anaszewski
2020-11-23 3:20 ` Gene Chen
2020-11-23 3:20 ` Gene Chen
2020-11-23 3:20 ` Gene Chen
2020-11-23 21:06 ` Jacek Anaszewski
2020-11-23 21:06 ` Jacek Anaszewski
2020-11-23 21:06 ` Jacek Anaszewski
2020-11-24 6:08 ` Gene Chen
2020-11-24 6:08 ` Gene Chen
2020-11-24 6:08 ` Gene Chen
2020-11-24 21:15 ` Jacek Anaszewski
2020-11-24 21:15 ` Jacek Anaszewski
2020-11-24 21:15 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 21:37 ` Pavel Machek
2020-11-18 21:37 ` Pavel Machek
2020-11-18 21:37 ` Pavel Machek
2020-11-19 2:20 ` Gene Chen
2020-11-19 2:20 ` Gene Chen
2020-11-19 2:20 ` Gene Chen
2020-11-19 7:44 ` Pavel Machek
2020-11-19 7:44 ` Pavel Machek
2020-11-19 7:44 ` Pavel Machek
2020-11-19 7:55 ` Gene Chen
2020-11-19 7:55 ` Gene Chen
2020-11-19 7:55 ` Gene Chen
2020-11-19 8:38 ` Pavel Machek
2020-11-19 8:38 ` Pavel Machek
2020-11-19 8:38 ` Pavel Machek
2020-11-19 21:03 ` Jacek Anaszewski
2020-11-19 21:03 ` Jacek Anaszewski
2020-11-19 21:03 ` Jacek Anaszewski
2020-11-19 21:57 ` Pavel Machek
2020-11-19 21:57 ` Pavel Machek
2020-11-19 21:57 ` Pavel Machek
2020-11-19 22:26 ` Jacek Anaszewski
2020-11-19 22:26 ` Jacek Anaszewski
2020-11-19 22:26 ` Jacek Anaszewski
2020-11-23 3:00 ` Gene Chen [this message]
2020-11-23 3:00 ` Gene Chen
2020-11-23 3:00 ` Gene Chen
2020-11-23 20:52 ` Jacek Anaszewski
2020-11-23 20:52 ` Jacek Anaszewski
2020-11-23 20:52 ` Jacek Anaszewski
2020-11-24 7:33 ` Gene Chen
2020-11-24 7:33 ` Gene Chen
2020-11-24 7:33 ` Gene Chen
2020-11-24 8:32 ` Gene Chen
2020-11-24 8:32 ` Gene Chen
2020-11-24 8:32 ` Gene Chen
2020-11-24 21:38 ` Jacek Anaszewski
2020-11-24 21:38 ` Jacek Anaszewski
2020-11-24 21:38 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 3/5] dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 21:25 ` Rob Herring
2020-11-18 21:25 ` Rob Herring
2020-11-18 21:25 ` Rob Herring
2020-11-19 1:41 ` Gene Chen
2020-11-19 1:41 ` Gene Chen
2020-11-19 1:41 ` Gene Chen
2020-11-18 10:47 ` [PATCH v7 5/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-18 10:47 ` Gene Chen
2020-11-19 22:55 ` Jacek Anaszewski
2020-11-19 22:55 ` Jacek Anaszewski
2020-11-19 22:55 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE+NS363BpytNGZzfZHLa7KLKL8gjGj14oNvRi3oaH9KT79REg@mail.gmail.com \
--to=gene.chen.richtek@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.