From: Greentime Hu <green.hu@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
Vincent Chen <deanbo422@gmail.com>,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org,
linux-m68k@lists.linux-m68k.org,
nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux <sparclinux@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 12:25:55 +0000 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Apr 25, 2018 at 09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type = FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt > - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt > - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Greentime Hu <green.hu@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
Vincent Chen <deanbo422@gmail.com>,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org,
linux-m68k@lists.linux-m68k.org,
nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux <sparclinux@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 20:25:55 +0800 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Apr 25, 2018 at 09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type == FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Greentime Hu <green.hu@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>,
Vincent Chen <deanbo422@gmail.com>,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org,
linux-m68k@vger.kernel.org, nios2-dev@lists.rocketboards.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux <sparclinux@vger.kernel.org>,
linux-xtensa@linux-xtensa.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 20:25:55 +0800 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Apr 25, 2018 at 09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type == FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: green.hu@gmail.com (Greentime Hu)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 20:25:55 +0800 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch at lst.de>:
> On Wed, Apr 25, 2018@09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch at lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type == FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: green.hu@gmail.com (Greentime Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 20:25:55 +0800 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Apr 25, 2018 at 09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type == FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Greentime Hu <green.hu@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 13/22] nds32: use generic dma_noncoherent_ops
Date: Wed, 25 Apr 2018 20:25:55 +0800 [thread overview]
Message-ID: <CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com> (raw)
In-Reply-To: <20180425064055.GA11460@lst.de>
2018-04-25 14:40 GMT+08:00 Christoph Hellwig <hch@lst.de>:
> On Wed, Apr 25, 2018 at 09:43:43AM +0800, Greentime Hu wrote:
>> Hi Crhistoph,
>>
>> The ftmac100 works if I revert this commit.
>
> Thanks. ftmac100 only use dma_map_page, which in the old nds32 code
> is just doing a plain page_address and never kmaps. Can you apply
> the patch below on the tree with the origin "nds32: use generic
> dma_noncoherent_ops" reverted? This always just uses page_address,
> although that, just like the original code is broken if you actually
> have highmem that needs to be mapped:
>
Hi, Christoph,
It still failed.
> ---
> From 1dc5d1cae4cd7b9ce03d0e2943364ed4cca938d7 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Mon, 16 Apr 2018 19:20:30 +0200
> Subject: nds32: use generic dma_noncoherent_ops
>
> Switch to the generic noncoherent direct mapping implementation.
>
> This makes sure the cache_sync routines is called in the unmap_sg
> case, to match the unmap_single and sync_{single,sg}_to_cpu cases.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/nds32/Kconfig | 3 +
> arch/nds32/include/asm/Kbuild | 1 +
> arch/nds32/include/asm/dma-mapping.h | 14 ---
> arch/nds32/kernel/dma.c | 182 +++++----------------------
> 4 files changed, 37 insertions(+), 163 deletions(-)
> delete mode 100644 arch/nds32/include/asm/dma-mapping.h
>
> diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
> index 249f38d3388f..67d0ac0a989c 100644
> --- a/arch/nds32/Kconfig
> +++ b/arch/nds32/Kconfig
> @@ -5,10 +5,13 @@
>
> config NDS32
> def_bool y
> + select ARCH_HAS_SYNC_DMA_FOR_CPU
> + select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_WANT_FRAME_POINTERS if FTRACE
> select CLKSRC_MMIO
> select CLONE_BACKWARDS
> select COMMON_CLK
> + select DMA_NONCOHERENT_OPS
> select GENERIC_ATOMIC64
> select GENERIC_CPU_DEVICES
> select GENERIC_CLOCKEVENTS
> diff --git a/arch/nds32/include/asm/Kbuild b/arch/nds32/include/asm/Kbuild
> index 06bdf8167f5a..b3e951f805f8 100644
> --- a/arch/nds32/include/asm/Kbuild
> +++ b/arch/nds32/include/asm/Kbuild
> @@ -13,6 +13,7 @@ generic-y += cputime.h
> generic-y += device.h
> generic-y += div64.h
> generic-y += dma.h
> +generic-y += dma-mapping.h
> generic-y += emergency-restart.h
> generic-y += errno.h
> generic-y += exec.h
> diff --git a/arch/nds32/include/asm/dma-mapping.h b/arch/nds32/include/asm/dma-mapping.h
> deleted file mode 100644
> index 2dd47d245c25..000000000000
> --- a/arch/nds32/include/asm/dma-mapping.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2005-2017 Andes Technology Corporation
> -
> -#ifndef ASMNDS32_DMA_MAPPING_H
> -#define ASMNDS32_DMA_MAPPING_H
> -
> -extern struct dma_map_ops nds32_dma_ops;
> -
> -static inline struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
> -{
> - return &nds32_dma_ops;
> -}
> -
> -#endif
> diff --git a/arch/nds32/kernel/dma.c b/arch/nds32/kernel/dma.c
> index d291800fc621..78311a1e6fd1 100644
> --- a/arch/nds32/kernel/dma.c
> +++ b/arch/nds32/kernel/dma.c
> @@ -3,17 +3,14 @@
>
> #include <linux/types.h>
> #include <linux/mm.h>
> -#include <linux/export.h>
> #include <linux/string.h>
> -#include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> +#include <linux/dma-noncoherent.h>
> #include <linux/io.h>
> #include <linux/cache.h>
> #include <linux/highmem.h>
> #include <linux/slab.h>
> #include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
> -#include <asm/dma-mapping.h>
> #include <asm/proc-fns.h>
>
> /*
> @@ -22,11 +19,6 @@
> static pte_t *consistent_pte;
> static DEFINE_RAW_SPINLOCK(consistent_lock);
>
> -enum master_type {
> - FOR_CPU = 0,
> - FOR_DEVICE = 1,
> -};
> -
> /*
> * VM region handling support.
> *
> @@ -124,10 +116,8 @@ static struct arch_vm_region *vm_region_find(struct arch_vm_region *head,
> return c;
> }
>
> -/* FIXME: attrs is not used. */
> -static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> - dma_addr_t * handle, gfp_t gfp,
> - unsigned long attrs)
> +void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *handle,
> + gfp_t gfp, unsigned long attrs)
> {
> struct page *page;
> struct arch_vm_region *c;
> @@ -232,8 +222,8 @@ static void *nds32_dma_alloc_coherent(struct device *dev, size_t size,
> return NULL;
> }
>
> -static void nds32_dma_free(struct device *dev, size_t size, void *cpu_addr,
> - dma_addr_t handle, unsigned long attrs)
> +void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
> + dma_addr_t handle, unsigned long attrs)
> {
> struct arch_vm_region *c;
> unsigned long flags, addr;
> @@ -333,145 +323,39 @@ static int __init consistent_init(void)
> }
>
> core_initcall(consistent_init);
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type);
> -static dma_addr_t nds32_dma_map_page(struct device *dev, struct page *page,
> - unsigned long offset, size_t size,
> - enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync((void *)(page_address(page) + offset), size, dir, FOR_DEVICE);
> - return page_to_phys(page) + offset;
> -}
>
> -static void nds32_dma_unmap_page(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
> - consistent_sync(phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -/*
> - * Make an area consistent for devices.
> - */
> -static void consistent_sync(void *vaddr, size_t size, int direction, int master_type)
> -{
> - unsigned long start = (unsigned long)vaddr;
> - unsigned long end = start + size;
> -
> - if (master_type == FOR_CPU) {
> - switch (direction) {
> - case DMA_TO_DEVICE:
> - break;
> - case DMA_FROM_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_inval_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> - } else {
> - /* FOR_DEVICE */
> - switch (direction) {
> - case DMA_FROM_DEVICE:
> - break;
> - case DMA_TO_DEVICE:
> - case DMA_BIDIRECTIONAL:
> - cpu_dma_wb_range(start, end);
> - break;
> - default:
> - BUG();
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_FROM_DEVICE:
> + break;
> + case DMA_TO_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_wb_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> }
>
> -static int nds32_dma_map_sg(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir,
> - unsigned long attrs)
> +void arch_sync_dma_for_cpu(struct device *dev, phys_addr_t paddr,
> + size_t size, enum dma_data_direction dir)
> {
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - void *virt;
> - unsigned long pfn;
> - struct page *page = sg_page(sg);
> -
> - sg->dma_address = sg_phys(sg);
> - pfn = page_to_pfn(page) + sg->offset / PAGE_SIZE;
> - page = pfn_to_page(pfn);
> - if (PageHighMem(page)) {
> - virt = kmap_atomic(page);
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - kunmap_atomic(virt);
> - } else {
> - if (sg->offset > PAGE_SIZE)
> - panic("sg->offset:%08x > PAGE_SIZE\n",
> - sg->offset);
> - virt = page_address(page) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> + void *addr = phys_to_virt(paddr);
> + unsigned long start = (unsigned long)addr;
> +
> + switch (dir) {
> + case DMA_TO_DEVICE:
> + break;
> + case DMA_FROM_DEVICE:
> + case DMA_BIDIRECTIONAL:
> + cpu_dma_inval_range(start, start + size);
> + break;
> + default:
> + BUG();
> }
> - return nents;
> }
> -
> -static void nds32_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> - int nhwentries, enum dma_data_direction dir,
> - unsigned long attrs)
> -{
> -}
> -
> -static void
> -nds32_dma_sync_single_for_cpu(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_CPU);
> -}
> -
> -static void
> -nds32_dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> - size_t size, enum dma_data_direction dir)
> -{
> - consistent_sync((void *)phys_to_virt(handle), size, dir, FOR_DEVICE);
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, int nents,
> - enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_CPU);
> - }
> -}
> -
> -static void
> -nds32_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> - int nents, enum dma_data_direction dir)
> -{
> - int i;
> -
> - for (i = 0; i < nents; i++, sg++) {
> - char *virt =
> - page_address((struct page *)sg->page_link) + sg->offset;
> - consistent_sync(virt, sg->length, dir, FOR_DEVICE);
> - }
> -}
> -
> -struct dma_map_ops nds32_dma_ops = {
> - .alloc = nds32_dma_alloc_coherent,
> - .free = nds32_dma_free,
> - .map_page = nds32_dma_map_page,
> - .unmap_page = nds32_dma_unmap_page,
> - .map_sg = nds32_dma_map_sg,
> - .unmap_sg = nds32_dma_unmap_sg,
> - .sync_single_for_device = nds32_dma_sync_single_for_device,
> - .sync_single_for_cpu = nds32_dma_sync_single_for_cpu,
> - .sync_sg_for_cpu = nds32_dma_sync_sg_for_cpu,
> - .sync_sg_for_device = nds32_dma_sync_sg_for_device,
> -};
> -
> -EXPORT_SYMBOL(nds32_dma_ops);
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-04-25 12:25 UTC|newest]
Thread overview: 310+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:02 Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] (no subject) Christoph Hellwig
2018-04-20 8:02 ` No subject Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` (unknown), Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` (unknown) Christoph Hellwig
2018-04-20 8:02 ` [PATCH 01/22] dma-debug: move initialization to common code Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 10:23 ` Robin Murphy
2018-04-20 10:23 ` [OpenRISC] " Robin Murphy
2018-04-20 10:23 ` Robin Murphy
2018-04-20 10:23 ` Robin Murphy
2018-04-20 10:23 ` Robin Murphy
2018-04-20 10:23 ` Robin Murphy
2018-04-24 7:35 ` Christoph Hellwig
2018-04-24 7:35 ` [OpenRISC] " Christoph Hellwig
2018-04-24 7:35 ` Christoph Hellwig
2018-04-24 7:35 ` Christoph Hellwig
2018-04-24 7:35 ` Christoph Hellwig
2018-04-24 7:35 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 02/22] dma-mapping: simplify Kconfig dependencies Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 03/22] dma-mapping: provide a generic dma-noncoherent implementation Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 04/22] alpha: use dma_direct_ops for jensen Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 05/22] alpha: simplify get_arch_dma_ops Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 06/22] arc: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-25 11:17 ` Alexey Brodkin
2018-04-26 6:45 ` hch
2018-04-26 6:45 ` [OpenRISC] " hch
2018-04-26 6:45 ` hch at lst.de
2018-04-26 6:45 ` hch
2018-04-26 6:45 ` hch
2018-04-26 6:45 ` hch
2018-04-26 6:45 ` hch
2018-04-26 6:45 ` hch
2018-04-26 8:25 ` hch
2018-04-26 8:25 ` [OpenRISC] " hch
2018-04-26 8:25 ` hch at lst.de
2018-04-26 8:25 ` hch
2018-04-26 8:25 ` hch
2018-04-26 8:25 ` hch
2018-04-26 8:25 ` hch
2018-04-26 8:25 ` hch
2018-04-20 8:02 ` [PATCH 07/22] arm-nommu: " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` [PATCH 08/22] c6x: " Christoph Hellwig
2018-04-20 8:02 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:02 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 09/22] hexagon: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 10/22] m68k: " Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 11/22] microblaze: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 12/22] microblaze: remove the consistent_sync and consistent_sync_page Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 13/22] nds32: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-23 6:49 ` Greentime Hu
2018-04-23 6:49 ` [OpenRISC] " Greentime Hu
2018-04-23 6:49 ` Greentime Hu
2018-04-23 6:49 ` Greentime Hu
2018-04-23 6:49 ` Greentime Hu
2018-04-23 6:49 ` Greentime Hu
2018-04-23 8:09 ` Michael Schmitz
2018-04-23 11:03 ` Greentime Hu
2018-04-24 19:16 ` Christoph Hellwig
2018-04-24 19:16 ` [OpenRISC] " Christoph Hellwig
2018-04-24 19:16 ` Christoph Hellwig
2018-04-24 19:16 ` Christoph Hellwig
2018-04-24 19:16 ` Christoph Hellwig
2018-04-24 19:16 ` Christoph Hellwig
2018-04-25 1:43 ` Greentime Hu
2018-04-25 1:43 ` [OpenRISC] " Greentime Hu
2018-04-25 1:43 ` Greentime Hu
2018-04-25 1:43 ` Greentime Hu
2018-04-25 1:43 ` Greentime Hu
2018-04-25 1:43 ` Greentime Hu
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` [OpenRISC] " Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 6:40 ` Christoph Hellwig
2018-04-25 12:25 ` Greentime Hu [this message]
2018-04-25 12:25 ` [OpenRISC] " Greentime Hu
2018-04-25 12:25 ` Greentime Hu
2018-04-25 12:25 ` Greentime Hu
2018-04-25 12:25 ` Greentime Hu
2018-04-25 12:25 ` Greentime Hu
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 6:42 ` [OpenRISC] " Christoph Hellwig
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 6:42 ` Christoph Hellwig
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:06 ` [OpenRISC] " Greentime Hu
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:06 ` Greentime Hu
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 8:24 ` [OpenRISC] " Christoph Hellwig
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 8:24 ` Christoph Hellwig
2018-04-26 9:39 ` Greentime Hu
2018-04-26 9:39 ` [OpenRISC] " Greentime Hu
2018-04-26 9:39 ` Greentime Hu
2018-04-26 9:39 ` Greentime Hu
2018-04-26 9:39 ` Greentime Hu
2018-04-26 9:39 ` Greentime Hu
2018-04-20 8:03 ` [PATCH 14/22] nios2: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 15/22] openrisc: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 16/22] sh: simplify get_arch_dma_ops Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 17/22] sh: introduce a sh_cacheop_vaddr helper Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 18/22] sh: use dma_direct_ops for the CONFIG_DMA_COHERENT case Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 19/22] sh: use generic dma_noncoherent_ops Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 20/22] xtensa: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 21/22] sparc: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [PATCH 22/22] parisc: " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` [OpenRISC] " Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-20 8:03 ` Christoph Hellwig
2018-04-21 17:43 ` Helge Deller
2018-04-21 17:43 ` [OpenRISC] " Helge Deller
2018-04-21 17:43 ` Helge Deller
2018-04-21 17:43 ` Helge Deller
2018-04-21 17:43 ` Helge Deller
2018-04-21 17:43 ` Helge Deller
2018-04-21 17:43 ` Helge Deller
2018-04-21 21:52 ` James Bottomley
2018-04-21 21:52 ` [OpenRISC] " James Bottomley
2018-04-21 21:52 ` James Bottomley
2018-04-21 21:52 ` James Bottomley
2018-04-21 21:52 ` James Bottomley
2018-04-21 21:52 ` James Bottomley
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 7:21 ` [OpenRISC] " Christoph Hellwig
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 7:21 ` Christoph Hellwig
2018-04-25 21:07 ` Helge Deller
2018-04-25 21:07 ` [OpenRISC] " Helge Deller
2018-04-25 21:07 ` Helge Deller
2018-04-25 21:07 ` Helge Deller
2018-04-25 21:07 ` Helge Deller
2018-04-25 21:07 ` Helge Deller
2018-04-25 21:07 ` Helge Deller
2018-04-21 21:42 ` James Bottomley
2018-04-21 21:42 ` [OpenRISC] " James Bottomley
2018-04-21 21:42 ` James Bottomley
2018-04-21 21:42 ` James Bottomley
2018-04-21 21:42 ` James Bottomley
2018-04-21 21:42 ` James Bottomley
2018-04-24 8:20 ` Christoph Hellwig
2018-04-24 8:20 ` [OpenRISC] " Christoph Hellwig
2018-04-24 8:20 ` Christoph Hellwig
2018-04-24 8:20 ` Christoph Hellwig
2018-04-24 8:20 ` Christoph Hellwig
2018-04-24 8:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEbi=3fcd8E=xi_hbef45LnPsBZhZv37yPO-xfZmU1gMaWnDvg@mail.gmail.com' \
--to=green.hu@gmail.com \
--cc=deanbo422@gmail.com \
--cc=hch@lst.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=monstr@monstr.eu \
--cc=nios2-dev@lists.rocketboards.org \
--cc=openrisc@lists.librecores.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.