From: Sumit Garg <sumit.garg@linaro.org> To: Jens Wiklander <jens.wiklander@linaro.org> Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, corbet@lwn.net, dhowells@redhat.com, jejb@linux.ibm.com, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Mimi Zohar <zohar@linux.ibm.com>, jmorris@namei.org, serge@hallyn.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, linux-doc@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, tee-dev@lists.linaro.org Subject: Re: [RFC 3/7] tee: add private login method for kernel clients Date: Tue, 09 Jul 2019 05:56:50 +0000 [thread overview] Message-ID: <CAFA6WYNzs=RErreWaa5BmF-P03Vf9nzQjvY_JpMckw87k9z12w@mail.gmail.com> (raw) In-Reply-To: <20190708153908.GA28253@jax> Thanks Jens for your comments. On Mon, 8 Jul 2019 at 21:09, Jens Wiklander <jens.wiklander@linaro.org> wrote: > > Hi Sumit, > > On Thu, Jun 13, 2019 at 04:00:29PM +0530, Sumit Garg wrote: > > There are use-cases where user-space shouldn't be allowed to communicate > > directly with a TEE device which is dedicated to provide a specific > > service for a kernel client. So add a private login method for kernel > > clients and disallow user-space to open-session using this login method. > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org> > > --- > > drivers/tee/tee_core.c | 6 ++++++ > > include/uapi/linux/tee.h | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > > index 0f16d9f..4581bd1 100644 > > --- a/drivers/tee/tee_core.c > > +++ b/drivers/tee/tee_core.c > > @@ -334,6 +334,12 @@ static int tee_ioctl_open_session(struct tee_context *ctx, > > goto out; > > } > > > > + if (arg.clnt_login = TEE_IOCTL_LOGIN_REE_KERNEL) { > TEE_IOCTL_LOGIN_REE_KERNEL is defined as 0x80000000 which is in the > range specified and implementation defined by the GP spec. I wonder if > we shouldn't filter the entire implementation defined range instead of > just this value. Agree. Will rather check for entire implementation defined range: 0x80000000 - 0xFFFFFFFF. > > > + pr_err("login method not allowed for user-space client\n"); > pr_debug(), if it's needed at all. > Ok will use pr_debug() instead. > > + rc = -EPERM; > > + goto out; > > + } > > + > > rc = ctx->teedev->desc->ops->open_session(ctx, &arg, params); > > if (rc) > > goto out; > > diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h > > index 4b9eb06..f33c69c 100644 > > --- a/include/uapi/linux/tee.h > > +++ b/include/uapi/linux/tee.h > > @@ -172,6 +172,8 @@ struct tee_ioctl_buf_data { > > #define TEE_IOCTL_LOGIN_APPLICATION 4 > > #define TEE_IOCTL_LOGIN_USER_APPLICATION 5 > > #define TEE_IOCTL_LOGIN_GROUP_APPLICATION 6 > > +/* Private login method for REE kernel clients */ > It's worth noting that this is filtered by the TEE framework, compared > to everything else which is treated opaquely. > IIUC, you are referring to login filter in optee_os. Change to prevent filter for this login method is part of this PR [1]. [1] https://github.com/OP-TEE/optee_os/pull/3082 -Sumit > > +#define TEE_IOCTL_LOGIN_REE_KERNEL 0x80000000 > > > > /** > > * struct tee_ioctl_param - parameter > > -- > > 2.7.4 > > > > Thanks, > Jens
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org> To: Jens Wiklander <jens.wiklander@linaro.org> Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, corbet@lwn.net, dhowells@redhat.com, jejb@linux.ibm.com, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Mimi Zohar <zohar@linux.ibm.com>, jmorris@namei.org, serge@hallyn.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, linux-doc@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, tee-dev@lists.linaro.org Subject: Re: [RFC 3/7] tee: add private login method for kernel clients Date: Tue, 9 Jul 2019 11:26:19 +0530 [thread overview] Message-ID: <CAFA6WYNzs=RErreWaa5BmF-P03Vf9nzQjvY_JpMckw87k9z12w@mail.gmail.com> (raw) In-Reply-To: <20190708153908.GA28253@jax> Thanks Jens for your comments. On Mon, 8 Jul 2019 at 21:09, Jens Wiklander <jens.wiklander@linaro.org> wrote: > > Hi Sumit, > > On Thu, Jun 13, 2019 at 04:00:29PM +0530, Sumit Garg wrote: > > There are use-cases where user-space shouldn't be allowed to communicate > > directly with a TEE device which is dedicated to provide a specific > > service for a kernel client. So add a private login method for kernel > > clients and disallow user-space to open-session using this login method. > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org> > > --- > > drivers/tee/tee_core.c | 6 ++++++ > > include/uapi/linux/tee.h | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > > index 0f16d9f..4581bd1 100644 > > --- a/drivers/tee/tee_core.c > > +++ b/drivers/tee/tee_core.c > > @@ -334,6 +334,12 @@ static int tee_ioctl_open_session(struct tee_context *ctx, > > goto out; > > } > > > > + if (arg.clnt_login == TEE_IOCTL_LOGIN_REE_KERNEL) { > TEE_IOCTL_LOGIN_REE_KERNEL is defined as 0x80000000 which is in the > range specified and implementation defined by the GP spec. I wonder if > we shouldn't filter the entire implementation defined range instead of > just this value. Agree. Will rather check for entire implementation defined range: 0x80000000 - 0xFFFFFFFF. > > > + pr_err("login method not allowed for user-space client\n"); > pr_debug(), if it's needed at all. > Ok will use pr_debug() instead. > > + rc = -EPERM; > > + goto out; > > + } > > + > > rc = ctx->teedev->desc->ops->open_session(ctx, &arg, params); > > if (rc) > > goto out; > > diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h > > index 4b9eb06..f33c69c 100644 > > --- a/include/uapi/linux/tee.h > > +++ b/include/uapi/linux/tee.h > > @@ -172,6 +172,8 @@ struct tee_ioctl_buf_data { > > #define TEE_IOCTL_LOGIN_APPLICATION 4 > > #define TEE_IOCTL_LOGIN_USER_APPLICATION 5 > > #define TEE_IOCTL_LOGIN_GROUP_APPLICATION 6 > > +/* Private login method for REE kernel clients */ > It's worth noting that this is filtered by the TEE framework, compared > to everything else which is treated opaquely. > IIUC, you are referring to login filter in optee_os. Change to prevent filter for this login method is part of this PR [1]. [1] https://github.com/OP-TEE/optee_os/pull/3082 -Sumit > > +#define TEE_IOCTL_LOGIN_REE_KERNEL 0x80000000 > > > > /** > > * struct tee_ioctl_param - parameter > > -- > > 2.7.4 > > > > Thanks, > Jens
next prev parent reply other threads:[~2019-07-09 5:56 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-13 10:30 [RFC 0/7] Introduce TEE based Trusted Keys support Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 10:30 ` [RFC 1/7] tee: optee: allow kernel pages to register as shm Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 15:12 ` Jarkko Sakkinen 2019-06-13 15:12 ` Jarkko Sakkinen 2019-06-13 15:17 ` Jarkko Sakkinen 2019-06-13 15:17 ` Jarkko Sakkinen 2019-06-13 15:17 ` Jarkko Sakkinen 2019-06-13 15:17 ` Jarkko Sakkinen 2019-06-14 5:12 ` Sumit Garg 2019-06-14 5:24 ` Sumit Garg 2019-06-14 8:15 ` Jens Wiklander 2019-06-14 8:15 ` Jens Wiklander 2019-06-13 10:30 ` [RFC 2/7] tee: enable support to register kernel memory Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 15:20 ` Jarkko Sakkinen 2019-06-13 15:20 ` Jarkko Sakkinen 2019-06-14 5:13 ` Sumit Garg 2019-06-14 5:25 ` Sumit Garg 2019-06-14 8:16 ` Jens Wiklander 2019-06-14 8:16 ` Jens Wiklander 2019-06-13 10:30 ` [RFC 3/7] tee: add private login method for kernel clients Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-07-08 15:39 ` Jens Wiklander 2019-07-08 15:39 ` Jens Wiklander 2019-07-09 5:56 ` Sumit Garg [this message] 2019-07-09 5:56 ` Sumit Garg 2019-07-09 7:03 ` Jens Wiklander 2019-07-09 7:03 ` Jens Wiklander 2019-07-09 9:36 ` Sumit Garg 2019-07-09 9:48 ` Sumit Garg 2019-07-29 7:08 ` Jens Wiklander 2019-07-29 7:08 ` Jens Wiklander 2019-07-29 13:13 ` Sumit Garg 2019-07-29 13:25 ` Sumit Garg 2019-06-13 10:30 ` [RFC 4/7] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 15:32 ` Jarkko Sakkinen 2019-06-13 15:32 ` Jarkko Sakkinen 2019-06-14 5:43 ` Sumit Garg 2019-06-14 5:55 ` Sumit Garg 2019-06-13 10:30 ` [RFC 5/7] KEYS: encrypted: Allow TEE based trusted master keys Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 10:30 ` [RFC 6/7] doc: keys: Document usage of TEE based Trusted Keys Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 15:34 ` Jarkko Sakkinen 2019-06-13 15:34 ` Jarkko Sakkinen 2019-06-14 5:37 ` Sumit Garg 2019-06-14 5:49 ` Sumit Garg 2019-06-14 15:36 ` Jarkko Sakkinen 2019-06-14 15:36 ` Jarkko Sakkinen 2019-06-13 10:30 ` [RFC 7/7] MAINTAINERS: Add entry for " Sumit Garg 2019-06-13 10:42 ` Sumit Garg 2019-06-13 16:40 ` [RFC 0/7] Introduce TEE based Trusted Keys support Casey Schaufler 2019-06-13 16:40 ` Casey Schaufler 2019-06-14 0:03 ` Mimi Zohar 2019-06-14 0:03 ` Mimi Zohar 2019-06-14 8:17 ` Sumit Garg 2019-06-14 8:29 ` Sumit Garg 2019-06-14 5:58 ` Sumit Garg 2019-06-14 5:58 ` Sumit Garg 2019-07-08 12:41 ` Sumit Garg 2019-07-08 12:53 ` Sumit Garg 2019-07-08 16:31 ` Jens Wiklander 2019-07-08 16:31 ` Jens Wiklander 2019-07-09 5:58 ` Sumit Garg 2019-07-09 5:59 ` Sumit Garg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFA6WYNzs=RErreWaa5BmF-P03Vf9nzQjvY_JpMckw87k9z12w@mail.gmail.com' \ --to=sumit.garg@linaro.org \ --cc=ard.biesheuvel@linaro.org \ --cc=corbet@lwn.net \ --cc=daniel.thompson@linaro.org \ --cc=dhowells@redhat.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jejb@linux.ibm.com \ --cc=jens.wiklander@linaro.org \ --cc=jmorris@namei.org \ --cc=keyrings@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=serge@hallyn.com \ --cc=tee-dev@lists.linaro.org \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.