All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc: khilman@baylibre.com, p.zabel@pengutronix.de, balbi@kernel.org,
	 jbrunet@baylibre.com, linux-amlogic@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use
Date: Sun, 21 Nov 2021 00:39:57 +0100	[thread overview]
Message-ID: <CAFBinCA4UHybSkKX=yRvEE3k7oSwFEzYADkZdsMxfMsp-Cmodg@mail.gmail.com> (raw)
In-Reply-To: <20211112162827.128319-2-aouledameur@baylibre.com>

On Fri, Nov 12, 2021 at 5:33 PM Amjad Ouled-Ameur
<aouledameur@baylibre.com> wrote:
>
> Use reset_control_rearm() call if an error occurs in case
> phy_meson_gxl_usb2_init() fails after reset() has been called ; or in case
> phy_meson_gxl_usb2_exit() is called i.e the resource is no longer used
> and the reset line may be triggered again by other devices.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework. Therefore, use of reset_control_reset() on shared reset line
> should be balanced with reset_control_rearm().
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> Reported-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc: khilman@baylibre.com, p.zabel@pengutronix.de, balbi@kernel.org,
	jbrunet@baylibre.com, linux-amlogic@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use
Date: Sun, 21 Nov 2021 00:39:57 +0100	[thread overview]
Message-ID: <CAFBinCA4UHybSkKX=yRvEE3k7oSwFEzYADkZdsMxfMsp-Cmodg@mail.gmail.com> (raw)
In-Reply-To: <20211112162827.128319-2-aouledameur@baylibre.com>

On Fri, Nov 12, 2021 at 5:33 PM Amjad Ouled-Ameur
<aouledameur@baylibre.com> wrote:
>
> Use reset_control_rearm() call if an error occurs in case
> phy_meson_gxl_usb2_init() fails after reset() has been called ; or in case
> phy_meson_gxl_usb2_exit() is called i.e the resource is no longer used
> and the reset line may be triggered again by other devices.
>
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework. Therefore, use of reset_control_reset() on shared reset line
> should be balanced with reset_control_rearm().
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> Reported-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

  reply	other threads:[~2021-11-20 23:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 16:28 [PATCH v3 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur
2021-11-12 16:28 ` Amjad Ouled-Ameur
2021-11-12 16:28 ` [PATCH v3 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use Amjad Ouled-Ameur
2021-11-12 16:28   ` Amjad Ouled-Ameur
2021-11-20 23:39   ` Martin Blumenstingl [this message]
2021-11-20 23:39     ` Martin Blumenstingl
2021-11-22  9:03   ` Philipp Zabel
2021-11-22  9:03     ` Philipp Zabel
2021-12-05 21:13     ` Amjad Ouled-Ameur
2021-12-05 21:13       ` Amjad Ouled-Ameur
2021-11-12 16:28 ` [PATCH v3 2/3] usb: dwc3: meson-g12a: fix shared reset control use Amjad Ouled-Ameur
2021-11-12 16:28   ` Amjad Ouled-Ameur
2021-11-20 23:51   ` Martin Blumenstingl
2021-11-20 23:51     ` Martin Blumenstingl
2021-11-22  9:04     ` Anand Moon
2021-11-22  9:04       ` Anand Moon
2021-11-12 16:28 ` [PATCH v3 3/3] phy: amlogic: meson8b-usb2: " Amjad Ouled-Ameur
2021-11-12 16:28   ` Amjad Ouled-Ameur
2021-11-20 23:57   ` Martin Blumenstingl
2021-11-20 23:57     ` Martin Blumenstingl
2021-12-05 21:35     ` Amjad Ouled-Ameur
2021-12-05 21:35       ` Amjad Ouled-Ameur
2021-11-19 19:27 ` [PATCH v3 0/3] usb: meson: " Kevin Hilman
2021-11-19 19:27   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBinCA4UHybSkKX=yRvEE3k7oSwFEzYADkZdsMxfMsp-Cmodg@mail.gmail.com' \
    --to=martin.blumenstingl@googlemail.com \
    --cc=aouledameur@baylibre.com \
    --cc=balbi@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.