Re: [PATCH 02/15] phy: mvebu-cp110-comphy: Add SMC call support

From: Grzegorz Jaszczyk <jaz@semihalf.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Marcin Wojtas <mw@semihalf.com>,
	Jason Cooper <jason@lakedaemon.net>,
	devicetree@vger.kernel.org,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Russell King <linux@armlinux.org.uk>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 02/15] phy: mvebu-cp110-comphy: Add SMC call support
Date: Wed, 3 Apr 2019 11:02:15 +0200	[thread overview]
Message-ID: <CAH76GKOJkrQnMVYFCQJKrvX++5kH4be95ytR7CaL8V5duL27yw@mail.gmail.com> (raw)
In-Reply-To: <20190401165131.23370-3-miquel.raynal@bootlin.com>

Hi Miquel,

pon., 1 kwi 2019 o 18:52 Miquel Raynal <miquel.raynal@bootlin.com> napisał(a):
> +static int mvebu_comphy_power_on(struct phy *phy)
> +{
> +       struct mvebu_comphy_lane *lane = phy_get_drvdata(phy);
> +       struct mvebu_comphy_priv *priv = lane->priv;
> +       u32 fw_param = 0;
> +       int fw_mode;
> +       int ret;
> +
> +       fw_mode = mvebu_comphy_get_fw_mode(lane->id, lane->port,
> +                                          lane->mode, lane->submode);
> +       if (fw_mode < 0)
> +               goto try_legacy;
> +
> +       /* Try SMC flow first */
> +       switch (lane->mode) {
> +       case PHY_MODE_ETHERNET:
> +               dev_dbg(priv->dev, "set lane %d to Ethernet mode\n", lane->id);
> +               switch (lane->submode) {
> +               case PHY_INTERFACE_MODE_SGMII:
> +               case PHY_INTERFACE_MODE_2500BASEX:
> +               case PHY_INTERFACE_MODE_10GKR:
> +                       fw_param = COMPHY_FW_PARAM(fw_mode, lane->port);

It seems it will not work for SGMII and 2500BASEX. It is because you
are setting max speed for all comphy modes inside COMPHY_FW_PARAM
macro which is wrong. Did you test it?
BTW can you point to some public temporary git branch where this
patchset can be found?

regards,
Grzegorz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel