From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: Wen Congyang <wency@cn.fujitsu.com> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Date: Fri, 19 Oct 2012 14:19:53 -0400 [thread overview] Message-ID: <CAHGf_=qfzEJ0VjeYkKFVtyew+wYM-rHS4nqmXU4t7HYGuv8k9w@mail.gmail.com> (raw) In-Reply-To: <508118A6.80804@cn.fujitsu.com> > Hmm, IIRC, if the memory is recognized from kerenl before driver initialization, > the memory device is not managed by the driver acpi_memhotplug. Yup. > I think we should also deal with REMOVAL_NORMAL here now. Otherwise it will cause > some critical problem: we unbind the device from the driver but we still use > it. If we eject it, we have no chance to offline and remove it. It is very dangerous. ?? If resource was not allocated a driver, a driver doesn't need to deallocate it when error path. I haven't caught your point.
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> To: Wen Congyang <wency@cn.fujitsu.com> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Date: Fri, 19 Oct 2012 14:19:53 -0400 [thread overview] Message-ID: <CAHGf_=qfzEJ0VjeYkKFVtyew+wYM-rHS4nqmXU4t7HYGuv8k9w@mail.gmail.com> (raw) In-Reply-To: <508118A6.80804@cn.fujitsu.com> > Hmm, IIRC, if the memory is recognized from kerenl before driver initialization, > the memory device is not managed by the driver acpi_memhotplug. Yup. > I think we should also deal with REMOVAL_NORMAL here now. Otherwise it will cause > some critical problem: we unbind the device from the driver but we still use > it. If we eject it, we have no chance to offline and remove it. It is very dangerous. ?? If resource was not allocated a driver, a driver doesn't need to deallocate it when error path. I haven't caught your point. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-19 18:20 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-10-03 9:52 [PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory Yasuaki Ishimatsu 2012-10-03 9:52 ` Yasuaki Ishimatsu 2012-10-03 9:52 ` Yasuaki Ishimatsu 2012-10-03 9:58 ` [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() Yasuaki Ishimatsu 2012-10-03 9:58 ` Yasuaki Ishimatsu 2012-10-04 20:53 ` KOSAKI Motohiro 2012-10-04 20:53 ` KOSAKI Motohiro 2012-10-08 6:58 ` Wen Congyang 2012-10-08 6:58 ` Wen Congyang 2012-10-12 19:10 ` KOSAKI Motohiro 2012-10-12 19:10 ` KOSAKI Motohiro 2012-10-17 6:48 ` Wen Congyang 2012-10-17 6:48 ` Wen Congyang 2012-10-17 8:59 ` KOSAKI Motohiro 2012-10-17 8:59 ` KOSAKI Motohiro 2012-10-17 9:08 ` Wen Congyang 2012-10-17 9:08 ` Wen Congyang 2012-10-17 9:18 ` KOSAKI Motohiro 2012-10-17 9:18 ` KOSAKI Motohiro 2012-10-17 9:52 ` Wen Congyang 2012-10-17 9:52 ` Wen Congyang 2012-10-18 1:25 ` Yasuaki Ishimatsu 2012-10-18 1:25 ` Yasuaki Ishimatsu 2012-10-18 1:25 ` Yasuaki Ishimatsu 2012-10-19 7:35 ` Wen Congyang 2012-10-19 7:35 ` Wen Congyang 2012-10-17 9:18 ` Wen Congyang 2012-10-17 9:18 ` Wen Congyang 2012-10-18 19:44 ` KOSAKI Motohiro 2012-10-18 19:44 ` KOSAKI Motohiro 2012-10-19 9:08 ` Wen Congyang 2012-10-19 9:08 ` Wen Congyang 2012-10-19 18:19 ` KOSAKI Motohiro [this message] 2012-10-19 18:19 ` KOSAKI Motohiro 2012-10-20 5:02 ` Wen Congyang 2012-10-20 5:02 ` Wen Congyang 2012-10-22 15:11 ` KOSAKI Motohiro 2012-10-22 15:11 ` KOSAKI Motohiro 2012-10-22 15:34 ` KOSAKI Motohiro 2012-10-22 15:34 ` KOSAKI Motohiro 2012-10-03 10:02 ` [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory() Yasuaki Ishimatsu 2012-10-03 10:02 ` Yasuaki Ishimatsu 2012-10-04 21:31 ` KOSAKI Motohiro 2012-10-04 21:31 ` KOSAKI Motohiro 2012-10-08 6:45 ` Wen Congyang 2012-10-08 6:45 ` Wen Congyang 2012-10-12 18:57 ` KOSAKI Motohiro 2012-10-12 18:57 ` KOSAKI Motohiro 2012-10-03 10:09 ` [PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c Yasuaki Ishimatsu 2012-10-03 10:09 ` Yasuaki Ishimatsu 2012-10-05 18:54 ` KOSAKI Motohiro 2012-10-05 18:54 ` KOSAKI Motohiro 2012-10-03 10:11 ` [PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device Yasuaki Ishimatsu 2012-10-03 10:11 ` Yasuaki Ishimatsu 2012-10-03 10:11 ` Yasuaki Ishimatsu 2012-10-05 18:56 ` KOSAKI Motohiro 2012-10-05 18:56 ` KOSAKI Motohiro 2012-10-08 6:47 ` Wen Congyang 2012-10-08 6:47 ` Wen Congyang 2012-10-12 18:59 ` KOSAKI Motohiro 2012-10-12 18:59 ` KOSAKI Motohiro 2012-10-06 14:22 ` [PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory Ni zhan Chen 2012-10-06 14:22 ` Ni zhan Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHGf_=qfzEJ0VjeYkKFVtyew+wYM-rHS4nqmXU4t7HYGuv8k9w@mail.gmail.com' \ --to=kosaki.motohiro@jp.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux.com \ --cc=isimatu.yasuaki@jp.fujitsu.com \ --cc=len.brown@intel.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=liuj97@gmail.com \ --cc=minchan.kim@gmail.com \ --cc=rientjes@google.com \ --cc=wency@cn.fujitsu.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.