Re: [PATCH v3 00/16] Add support for AXP192 PMIC

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"brgl@bgdev.pl" <brgl@bgdev.pl>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"wens@csie.org" <wens@csie.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"sre@kernel.org" <sre@kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"rafael@kernel.org" <rafael@kernel.org>,
	"quic_gurus@quicinc.com" <quic_gurus@quicinc.com>,
	"sebastian.reichel@collabora.com"
	<sebastian.reichel@collabora.com>,
	"michael@walle.cc" <michael@walle.cc>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 00/16] Add support for AXP192 PMIC
Date: Sun, 19 Jun 2022 13:12:09 +0200	[thread overview]
Message-ID: <CAHp75VcG-rkyJ6Sy_ya5Asrzp1hBAofY1qvK+o4iue=FmNGXxA@mail.gmail.com> (raw)
In-Reply-To: <20220619121743.2b259153@jic23-huawei>

On Sun, Jun 19, 2022 at 1:08 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Sun, 19 Jun 2022 00:43:07 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Saturday, June 18, 2022, Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> > wrote:
> >
> > > Changes in v3:
> > >
> > > * Update pinctrl driver to address Andy Shevchenko's review comments
> > >   from v1, and fix a few other
> >
> > I believe I gave more comments than just against pin control driver. Even
> > though, some comments are still not addressed in the series, including pin
> > control. Am I mistaken?
>
> Hi Andy,
>
> Maybe, it's a question of clarity/misunderstanding? You had some 'global' comments
> at the end of the pinctrl review. Perhaps not clear enough you meant
> they should apply to the rest of the patch series (and more generally to
> the driver being modified I think).

Yeah, I think that is.
I don't remember if we have somewhere a documentation on how to
respond to the review comments, in which the point of addressing
comment everywhere in the series, and not only in the place(s) where
it was given.

-- 
With Best Regards,
Andy Shevchenko